* [PATCH 1/1] drm/i915: prevent possible pin leak on error path
@ 2012-06-18 22:03 Eugeni Dodonov
2012-06-18 22:04 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Eugeni Dodonov @ 2012-06-18 22:03 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, stable, Eugeni Dodonov
We should not hit this under any sane conditions, but still, this does not
looks right.
CC: Chris Wilson <chris@chris-wilson.co.uk>
CC: Daniel Vetter <daniel.vetter@ffwll.ch>
CC: stable@vger.kernel.org
Reported-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7b3990e..5b50b5f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6178,7 +6178,7 @@ static int intel_gen7_queue_flip(struct drm_device *dev,
default:
WARN_ONCE(1, "unknown plane in flip command\n");
ret = -ENODEV;
- goto err;
+ goto err_unpin;
}
ret = intel_ring_begin(ring, 4);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/i915: prevent possible pin leak on error path
2012-06-18 22:03 [PATCH 1/1] drm/i915: prevent possible pin leak on error path Eugeni Dodonov
@ 2012-06-18 22:04 ` Chris Wilson
2012-07-26 20:32 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-06-18 22:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, stable, Eugeni Dodonov
On Mon, 18 Jun 2012 19:03:38 -0300, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> We should not hit this under any sane conditions, but still, this does not
> looks right.
For pedagology.
>
> CC: Chris Wilson <chris@chris-wilson.co.uk>
> CC: Daniel Vetter <daniel.vetter@ffwll.ch>
> CC: stable@vger.kernel.org
> Reported-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Whoever hits this has much bigger issues at hand...
Reviewed-by: Chris Wlison <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/i915: prevent possible pin leak on error path
2012-06-18 22:04 ` Chris Wilson
@ 2012-07-26 20:32 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-07-26 20:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, intel-gfx, stable, Eugeni Dodonov
On Mon, Jun 18, 2012 at 11:04:30PM +0100, Chris Wilson wrote:
> On Mon, 18 Jun 2012 19:03:38 -0300, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> > We should not hit this under any sane conditions, but still, this does not
> > looks right.
>
> For pedagology.
> >
> > CC: Chris Wilson <chris@chris-wilson.co.uk>
> > CC: Daniel Vetter <daniel.vetter@ffwll.ch>
> > CC: stable@vger.kernel.org
> > Reported-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
> > Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
>
> Whoever hits this has much bigger issues at hand...
> Reviewed-by: Chris Wlison <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-26 20:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-18 22:03 [PATCH 1/1] drm/i915: prevent possible pin leak on error path Eugeni Dodonov
2012-06-18 22:04 ` Chris Wilson
2012-07-26 20:32 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox