From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add energy counter support for IVB
Date: Wed, 20 Jun 2012 16:53:12 +0100 [thread overview]
Message-ID: <1340207618_23753@CP5-2952> (raw)
In-Reply-To: <20120620083259.28bf0518@jbarnes-desktop>
On Wed, 20 Jun 2012 08:32:59 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Wed, 20 Jun 2012 09:38:25 +0200
> Daniel Vetter <daniel@ffwll.ch> wrote:
> > And from the bikeshed departement: Can't we just print a running number? I
> > know, substraction is bloody hard, but for anything else than total power
> > consumption (e.g. graphing power over time) the running thing is imo
> > simpler. We've had the same discussion for the rc6 sysfs residency timers
> > and concluded (after Arjan yelled at us) that doing the substraction in
> > userspace is better, least it allows multiple userspace tools to read
> > this.
> >
>
> Yeah that's a good point; this way happened to be simpler for what I
> was doing, but just exposing the cooked register value (converted to
> ujoules) is better. Will fix.
And to keep it easy to parse, just make it return -ENODEV on older
platforms and a simple number for gen6+.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-06-20 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 20:20 [PATCH] drm/i915: add energy counter support for IVB Jesse Barnes
2012-06-19 23:54 ` Ben Widawsky
2012-06-20 0:59 ` Jesse Barnes
2012-06-20 2:00 ` Ben Widawsky
2012-06-20 6:20 ` Jani Nikula
2012-06-20 7:38 ` Daniel Vetter
2012-06-20 15:32 ` Jesse Barnes
2012-06-20 15:53 ` Chris Wilson [this message]
2012-06-20 15:59 ` Daniel Vetter
2012-06-20 16:17 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340207618_23753@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox