public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: add sanity checks for hsync and htotal
Date: Wed, 20 Jun 2012 17:36:26 -0400	[thread overview]
Message-ID: <1340228186.14667.7.camel@atropine> (raw)
In-Reply-To: <68e45eed497d3fef1ee9756f4648eb97b7fdd4aa.1340222977.git.jani.nikula@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 489 bytes --]

On Wed, 2012-06-20 at 23:15 +0300, Jani Nikula wrote:
> Restrict hsync start, end, hdisplay and htotal to be according to hw
> spec. Through drm_mode_set_crtcinfo(), these will also limit hblank start,
> end.

I'm pretty sure any physical hardware would balk at modes like this.
Virtual framebuffers probably wouldn't care, I guess.  Still, seems
wrong to have this in i915 when it should be common.

Is this a problem we've seen in the wild, or is this just paranoia?

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2012-06-20 21:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20 20:15 [PATCH 1/2] drm/i915: add sanity checks for hsync and htotal Jani Nikula
2012-06-20 20:15 ` [PATCH 2/2] drm/i915: Cantiga+ cannot handle a hsync front porch of 0 Jani Nikula
2012-06-20 21:36 ` Adam Jackson [this message]
2012-06-21  7:33   ` [PATCH 1/2] drm/i915: add sanity checks for hsync and htotal Jani Nikula
2012-06-21 10:19 ` [PATCH v2] drm/i915: Cantiga+ cannot handle a hsync front porch of 0 Jani Nikula
2012-06-21 12:16   ` Ville Syrjälä
2012-08-22 15:39   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340228186.14667.7.camel@atropine \
    --to=ajax@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox