From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Cantiga+ cannot handle a hsync front porch of 0
Date: Wed, 22 Aug 2012 17:39:46 +0200 [thread overview]
Message-ID: <20120822153946.GC5186@phenom.ffwll.local> (raw)
In-Reply-To: <1340273999-13342-1-git-send-email-jani.nikula@intel.com>
On Thu, Jun 21, 2012 at 01:19:59PM +0300, Jani Nikula wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> This addresses WaPruneModeWithIncorrectHsyncOffset.
>
> Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=50236
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next (just to close another annoying bugzilla entry), thanks
for the patch.
-Daniel
>
> ---
>
> v2: drop patch 1/2, to be addressed later.
> ---
> drivers/gpu/drm/i915/intel_display.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 9730162..76516b9 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3420,6 +3420,13 @@ static bool intel_crtc_mode_fixup(struct drm_crtc *crtc,
> if (!(adjusted_mode->private_flags & INTEL_MODE_CRTC_TIMINGS_SET))
> drm_mode_set_crtcinfo(adjusted_mode, 0);
>
> + /* WaPruneModeWithIncorrectHsyncOffset: Cantiga+ cannot handle modes
> + * with a hsync front porch of 0.
> + */
> + if ((INTEL_INFO(dev)->gen > 4 || IS_G4X(dev)) &&
> + adjusted_mode->hsync_start == adjusted_mode->hdisplay)
> + return false;
> +
> return true;
> }
>
> --
> 1.7.4.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-08-22 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 20:15 [PATCH 1/2] drm/i915: add sanity checks for hsync and htotal Jani Nikula
2012-06-20 20:15 ` [PATCH 2/2] drm/i915: Cantiga+ cannot handle a hsync front porch of 0 Jani Nikula
2012-06-20 21:36 ` [PATCH 1/2] drm/i915: add sanity checks for hsync and htotal Adam Jackson
2012-06-21 7:33 ` Jani Nikula
2012-06-21 10:19 ` [PATCH v2] drm/i915: Cantiga+ cannot handle a hsync front porch of 0 Jani Nikula
2012-06-21 12:16 ` Ville Syrjälä
2012-08-22 15:39 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822153946.GC5186@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox