From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 09/09] drm/i915: init DP instead of HDMI on port B
Date: Fri, 29 Jun 2012 16:03:41 -0300 [thread overview]
Message-ID: <1340996621-14345-9-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1340996621-14345-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
This is needed if you want to test DisplayPort on Haswell, but this is
not the correct solution.
Not-signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 ++
1 file changed, 2 insertions(+)
This patch is equivalent to this one:
[PATCH 06/21] drm/i915: Hook DP init in ddi module
Just as I don't expect 06/21 be committed, I don't expect this one to
be committed. IMHO these patches should be used just for testing. You
can't test DP on Haswell if you don't have this patch.
What we really need to do is to either create a DP and an HDMI
connector for each port (and then try to properly detect what is
connected to the port, and this is not as easy on Haswell as it was on
previous gens) or we create a new "Digital" connector and use it
instead of the DP and HDMI ones...
The main diference between this patch and 06/21 is that this patch
calls intel_dp_init with DDI_BUF_CTL_B as an argument instead of using
PCH_DP_B. The intel_dp->output_reg will contain the value we pass in
this argument. PCH_DP_B does not exist on Haswell, so code using
intel_dp->output_reg will be writing to an inexistent register. If we
pass DDI_BUF_CTL_B to it, intel_dp->output_reg will point to the
actual DP register, so code writing to output_reg will be correct.
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 082b923..a6b84e5 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -249,6 +249,8 @@ void intel_ddi_init(struct drm_device *dev, enum port port)
break;
/* Assume that the ports B, C and D are working in HDMI mode for now */
case PORT_B:
+ intel_dp_init(dev, DDI_BUF_CTL_B);
+ break;
case PORT_C:
case PORT_D:
intel_hdmi_init(dev, DDI_BUF_CTL(port));
--
1.7.10.2
next prev parent reply other threads:[~2012-06-29 19:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 19:03 [PATCH 01/09] drm/i915: move common code to intel_dp_set_link_train Paulo Zanoni
2012-06-29 19:03 ` [PATCH 02/09] drm/i915: try to train DP even harder Paulo Zanoni
2012-07-12 14:58 ` Daniel Vetter
2012-06-29 19:03 ` [PATCH 03/09] drm/i915: Move DP structs to shared location Paulo Zanoni
2012-07-12 15:13 ` Daniel Vetter
2012-06-29 19:03 ` [PATCH 04/09] drm/i915: Add "port" field to struct intel_dp Paulo Zanoni
2012-07-12 15:04 ` Daniel Vetter
2012-06-29 19:03 ` [PATCH 05/09] drm/i915: add basic Haswell DP enablement Paulo Zanoni
2012-06-29 19:03 ` [PATCH 06/09] drm/i915: fix Haswell M/N registers Paulo Zanoni
2012-06-29 19:03 ` [PATCH 07/09] drm/i915: implement Haswell DP link train Paulo Zanoni
2012-06-29 19:03 ` [PATCH 08/09] drm/i915: fix DP AUX register definitions on Haswell Paulo Zanoni
2012-06-29 19:03 ` Paulo Zanoni [this message]
2012-07-12 14:52 ` [PATCH 01/09] drm/i915: move common code to intel_dp_set_link_train Daniel Vetter
2012-07-17 19:55 ` [PATCH 1/2] " Paulo Zanoni
2012-07-17 20:53 ` [PATCH 2/2] drm/i915: add port field to struct intel_dp and use it Paulo Zanoni
2012-07-18 10:42 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340996621-14345-9-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox