Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] drm/i915: fix typo in gen6_enable_rps
@ 2012-07-04 23:07 Eugeni Dodonov
  2012-07-05  0:00 ` Chris Wilson
  0 siblings, 1 reply; 3+ messages in thread
From: Eugeni Dodonov @ 2012-07-04 23:07 UTC (permalink / raw)
  To: intel-gfx; +Cc: Eugeni Dodonov

Noticed by Chris Wilson, this got through in the last iteration of the rps
for Haswell patch.

CC: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 0350bab..e697df7 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -2460,7 +2460,7 @@ static void gen6_enable_rps(struct drm_device *dev)
 		   GEN6_RP_MEDIA_IS_GFX |
 		   GEN6_RP_ENABLE |
 		   GEN6_RP_UP_BUSY_AVG |
-		   (IS_HASWELL(dev)) ? GEN7_RP_DOWN_IDLE_AVG : GEN6_RP_DOWN_IDLE_CONT);
+		   (IS_HASWELL(dev) ? GEN7_RP_DOWN_IDLE_AVG : GEN6_RP_DOWN_IDLE_CONT));
 
 	if (wait_for((I915_READ(GEN6_PCODE_MAILBOX) & GEN6_PCODE_READY) == 0,
 		     500))
-- 
1.7.11.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] drm/i915: fix typo in gen6_enable_rps
  2012-07-04 23:07 [PATCH 1/1] drm/i915: fix typo in gen6_enable_rps Eugeni Dodonov
@ 2012-07-05  0:00 ` Chris Wilson
  2012-07-05  7:59   ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-07-05  0:00 UTC (permalink / raw)
  To: intel-gfx; +Cc: Eugeni Dodonov

On Wed,  4 Jul 2012 20:07:02 -0300, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> Noticed by Chris Wilson, this got through in the last iteration of the rps
> for Haswell patch.

That's the fix. Hopefully there is enough time for Daniel to rewrite
history and spare our blushes.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] drm/i915: fix typo in gen6_enable_rps
  2012-07-05  0:00 ` Chris Wilson
@ 2012-07-05  7:59   ` Daniel Vetter
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-07-05  7:59 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx, Eugeni Dodonov

On Thu, Jul 05, 2012 at 01:00:10AM +0100, Chris Wilson wrote:
> On Wed,  4 Jul 2012 20:07:02 -0300, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> > Noticed by Chris Wilson, this got through in the last iteration of the rps
> > for Haswell patch.
> 
> That's the fix. Hopefully there is enough time for Daniel to rewrite
> history and spare our blushes.

History is fixed, it never happened.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-07-05  7:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-04 23:07 [PATCH 1/1] drm/i915: fix typo in gen6_enable_rps Eugeni Dodonov
2012-07-05  0:00 ` Chris Wilson
2012-07-05  7:59   ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox