From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Rahul Sharma <rahul.sharma@samsung.com>
Subject: Re: [PATCH 4/4] drm/i915: create compact dma scatter lists for gem objects
Date: Sun, 10 Feb 2013 00:46:51 +0200 [thread overview]
Message-ID: <1360450011.5252.8.camel@ideak-mobl> (raw)
In-Reply-To: <20130209185934.GU5813@phenom.ffwll.local>
On Sat, 2013-02-09 at 19:59 +0100, Daniel Vetter wrote:
> On Sat, Feb 09, 2013 at 05:27:36PM +0200, Imre Deak wrote:
> > So far we created a sparse dma scatter list for gem objects, where each
> > scatter list entry represented only a single page. In the future we'll
> > have to handle compact scatter lists too where each entry can consist of
> > multiple pages, for example for objects imported through PRIME.
> >
> > The previous patches have already fixed up all other places where the
> > i915 driver _walked_ these lists. Here we have the corresponding fix to
> > _create_ compact lists. It's not a performance or memory footprint
> > improvement, but it helps to better exercise the new logic.
> >
> > Reference: http://www.spinics.net/lists/dri-devel/msg33917.html
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> Just a quick question: Have you checked with printks or so that we indeed
> create such coalesced sg entries every once in a while?
Yes, quite often that was the case, so we at least are really testing
the thing..
next prev parent reply other threads:[~2013-02-09 22:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 15:27 [PATCH 0/4] drm/i915: handle compact dma scatter lists Imre Deak
2013-02-09 15:27 ` [PATCH 1/4] drm: add helper to walk a dma scatter list a page at a time Imre Deak
2013-02-09 18:56 ` [Intel-gfx] " Daniel Vetter
2013-02-09 22:55 ` Imre Deak
2013-02-09 15:27 ` [PATCH 2/4] drm: handle compact dma scatter lists in drm_clflush_sg() Imre Deak
2013-02-09 15:27 ` [PATCH 3/4] drm/i915: handle walking compact dma scatter lists Imre Deak
2013-02-09 15:50 ` Chris Wilson
2013-02-09 22:51 ` Daniel Vetter
2013-02-09 22:59 ` Imre Deak
2013-02-09 15:27 ` [PATCH 4/4] drm/i915: create compact dma scatter lists for gem objects Imre Deak
2013-02-09 18:59 ` Daniel Vetter
2013-02-09 22:46 ` Imre Deak [this message]
2013-02-18 17:28 ` [PATCH v2 0/4] drm/i915: handle compact dma scatter lists Imre Deak
2013-02-18 17:28 ` [PATCH v2 1/4] drm: handle compact dma scatter lists in drm_clflush_sg() Imre Deak
2013-02-18 17:28 ` [PATCH v2 2/4] drm/i915: handle walking compact dma scatter lists Imre Deak
2013-02-18 17:28 ` [PATCH v2 3/4] drm/i915: create compact dma scatter lists for gem objects Imre Deak
2013-02-18 17:28 ` [PATCH v2 4/4] drm/i915: use for_each_sg_page for setting up the gtt ptes Imre Deak
2013-03-19 9:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360450011.5252.8.camel@ideak-mobl \
--to=imre.deak@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rahul.sharma@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox