From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 12/13] drm/i915: fix DP get_hw_state return value
Date: Tue, 2 Apr 2013 10:03:56 -0700 [thread overview]
Message-ID: <1364922237-3620-13-git-send-email-jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <1364922237-3620-1-git-send-email-jbarnes@virtuousgeek.org>
If we couldn't find a pipe we shouldn't return true. This might be even
better as a WARN though, since it should be impossible to have the port
enabled without a pipe selected.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index e1b0c94..720ff50 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1366,7 +1366,7 @@ static bool intel_dp_get_hw_state(struct intel_encoder *encoder,
intel_dp->output_reg);
}
- return true;
+ return false;
}
static unsigned intel_dp_get_mode_flags(struct intel_encoder *encoder)
--
1.7.9.5
next prev parent reply other threads:[~2013-04-02 17:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 17:03 Updated fastboot bits Jesse Barnes
2013-04-02 17:03 ` [PATCH 01/13] drm/i915: Skip modifying PCH DREF if not changing clock sources Jesse Barnes
2013-04-02 17:03 ` [PATCH 02/13] drm/i915: Split the framebuffer_info creation into a separate routine Jesse Barnes
2013-04-02 17:13 ` Chris Wilson
2013-04-02 17:03 ` [PATCH 03/13] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v3 Jesse Barnes
2013-04-02 18:24 ` Daniel Vetter
2013-04-02 17:03 ` [PATCH 04/13] drm/i915: Retrieve the current mode upon KMS takeover v2 Jesse Barnes
2013-04-02 17:03 ` [PATCH 05/13] drm/i915: Only preserve the BIOS modes if they are the preferred ones Jesse Barnes
2013-04-02 17:03 ` [PATCH 06/13] drm/i915: Validate that the framebuffer accommodates the current mode Jesse Barnes
2013-04-02 17:03 ` [PATCH 07/13] drm/i915: check panel fit status at update_plane time v2 Jesse Barnes
2013-04-02 17:58 ` Daniel Vetter
2013-04-02 18:00 ` Jesse Barnes
2013-04-02 17:03 ` [PATCH 08/13] drm/i915: treat no fb -> fb as simple flip instead of full mode set Jesse Barnes
2013-04-02 17:03 ` [PATCH 09/13] drm/i915: add debug messages for mode_valid checks Jesse Barnes
2013-04-02 17:03 ` [PATCH 10/13] drm/i915: fetch PCH PLL state at init time Jesse Barnes
2013-04-02 17:03 ` [PATCH 11/13] drm/i915: fix DDI get_hw_state return value Jesse Barnes
2013-04-02 17:03 ` Jesse Barnes [this message]
2013-04-02 18:11 ` [PATCH 12/13] drm/i915: fix DP " Daniel Vetter
2013-04-03 23:15 ` Daniel Vetter
2013-04-03 23:18 ` Daniel Vetter
2013-04-04 0:12 ` Jesse Barnes
2013-04-04 7:56 ` Daniel Vetter
2013-04-04 16:42 ` Jesse Barnes
2013-04-02 17:03 ` [PATCH 13/13] drm/i915: drop check for invalid pipe after fetching current hw state Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364922237-3620-13-git-send-email-jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox