From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 07/13] drm/i915: check panel fit status at update_plane time v2
Date: Tue, 2 Apr 2013 11:00:53 -0700 [thread overview]
Message-ID: <20130402110053.3c9c6acb@jbarnes-desktop> (raw)
In-Reply-To: <20130402175837.GW2228@phenom.ffwll.local>
On Tue, 2 Apr 2013 19:58:37 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Apr 02, 2013 at 10:03:51AM -0700, Jesse Barnes wrote:
> > We may need to disable the panel when flipping to a new buffer, so check
> > the state here and zero it out if needed, otherwise leave it alone.
> >
> > v2: fixup pipe_set_base check (Imre)
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> tbh I have no idea yet how we should best handle this and the following
> patch. My current guess is that we need a special pipe_update path, which
> sits in between the fb_update and the full modeset we currently have. A
> bunch of things we might want to do in that case:
> - kill the vga plane
> - update watermarks to our (hopefully power-efficient) ones
> - adjust pfit state (the bios tends to enable that even on non-lvds/edp
> outputs)
> - update other/global pm state (power well, refclocks, ...)
> - update infoframes/audio bits (not relevant for panels luckily)
>
> Of course I'd prefer if the code is somehow shared between the update_pipe
> path and the full modeset, since we'll inevitably get something wrong ...
Agree that we should share code paths where possible.
I think we could add new paths in enable/disable crtc for adjusting the
global state. pfit would probably fit better there anyway, since it's
not really panel specific.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-04-02 18:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 17:03 Updated fastboot bits Jesse Barnes
2013-04-02 17:03 ` [PATCH 01/13] drm/i915: Skip modifying PCH DREF if not changing clock sources Jesse Barnes
2013-04-02 17:03 ` [PATCH 02/13] drm/i915: Split the framebuffer_info creation into a separate routine Jesse Barnes
2013-04-02 17:13 ` Chris Wilson
2013-04-02 17:03 ` [PATCH 03/13] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v3 Jesse Barnes
2013-04-02 18:24 ` Daniel Vetter
2013-04-02 17:03 ` [PATCH 04/13] drm/i915: Retrieve the current mode upon KMS takeover v2 Jesse Barnes
2013-04-02 17:03 ` [PATCH 05/13] drm/i915: Only preserve the BIOS modes if they are the preferred ones Jesse Barnes
2013-04-02 17:03 ` [PATCH 06/13] drm/i915: Validate that the framebuffer accommodates the current mode Jesse Barnes
2013-04-02 17:03 ` [PATCH 07/13] drm/i915: check panel fit status at update_plane time v2 Jesse Barnes
2013-04-02 17:58 ` Daniel Vetter
2013-04-02 18:00 ` Jesse Barnes [this message]
2013-04-02 17:03 ` [PATCH 08/13] drm/i915: treat no fb -> fb as simple flip instead of full mode set Jesse Barnes
2013-04-02 17:03 ` [PATCH 09/13] drm/i915: add debug messages for mode_valid checks Jesse Barnes
2013-04-02 17:03 ` [PATCH 10/13] drm/i915: fetch PCH PLL state at init time Jesse Barnes
2013-04-02 17:03 ` [PATCH 11/13] drm/i915: fix DDI get_hw_state return value Jesse Barnes
2013-04-02 17:03 ` [PATCH 12/13] drm/i915: fix DP " Jesse Barnes
2013-04-02 18:11 ` Daniel Vetter
2013-04-03 23:15 ` Daniel Vetter
2013-04-03 23:18 ` Daniel Vetter
2013-04-04 0:12 ` Jesse Barnes
2013-04-04 7:56 ` Daniel Vetter
2013-04-04 16:42 ` Jesse Barnes
2013-04-02 17:03 ` [PATCH 13/13] drm/i915: drop check for invalid pipe after fetching current hw state Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402110053.3c9c6acb@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox