Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Xingchao <xingchao.wang@linux.intel.com>
To: daniel@ffwll.ch, tiwai@suse.de
Cc: alsa-devel@alsa-project.org, jocelyn.li@intel.com,
	intel-gfx@lists.freedesktop.org,
	Wang Xingchao <xingchao.wang@linux.intel.com>,
	xingchao.wang@intel.com, liam.r.girdwood@intel.com,
	david.henningsson@canonical.com
Subject: [PATCH 3/4] ALSA: hda - Fix runtime PM check
Date: Thu, 23 May 2013 01:04:15 +0800	[thread overview]
Message-ID: <1369242256-32112-4-git-send-email-xingchao.wang@linux.intel.com> (raw)
In-Reply-To: <1369242256-32112-1-git-send-email-xingchao.wang@linux.intel.com>

The device can support runtime PM no matter whether
it support signal wakeup or not. For some chips like Haswell
which doesnot support PME by default, this patch let haswell
Display HD-A controller enter runtime suspend, and bring more
power saving whith power-well feature enabled.
Signed-off-by: Wang Xingchao <xingchao.wang@linux.intel.com>
---
 sound/pci/hda/hda_intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 54c7c22..f20a88c 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -3755,7 +3755,7 @@ static int azx_probe(struct pci_dev *pci,
 			goto out_free_power;
 	}
 
-	if (pci_dev_run_wake(pci))
+	if (chip->driver_caps & AZX_DCAPS_PM_RUNTIME)
 		pm_runtime_put_noidle(&pci->dev);
 
 	dev++;
@@ -3834,7 +3834,7 @@ static void azx_remove(struct pci_dev *pci)
 	struct snd_card *card = pci_get_drvdata(pci);
 	struct azx *chip = card->private_data;
 
-	if (pci_dev_run_wake(pci))
+	if (chip->driver_caps & AZX_DCAPS_PM_RUNTIME)
 		pm_runtime_get_noresume(&pci->dev);
 
 	if (card)
-- 
1.8.1.2

  parent reply	other threads:[~2013-05-22 17:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 17:04 [PATCH 0/4 V5] Power-well API implementation for Haswell Wang Xingchao
2013-05-22 17:04 ` [PATCH 1/4 V5] i915/drm: Add private api for power well usage Wang Xingchao
2013-05-23 15:14   ` Takashi Iwai
2013-05-22 17:04 ` [PATCH 2/4 V5] ALSA: hda - Add power-welll support for haswell HDA Wang Xingchao
2013-05-22 17:04 ` Wang Xingchao [this message]
2013-05-23  6:02   ` [PATCH 3/4] ALSA: hda - Fix runtime PM check Takashi Iwai
2013-05-23  7:53     ` Wang, Xingchao
2013-05-23  8:09       ` Takashi Iwai
2013-05-23 10:20         ` Wang, Xingchao
2013-05-23 12:34   ` David Henningsson
2013-05-23 12:39     ` [alsa-devel] " Takashi Iwai
2013-05-22 17:04 ` [PATCH 4/4] ALSA: hda - Continue probe in work context to avoid request_module deadlock Wang Xingchao
2013-05-23  6:47   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369242256-32112-4-git-send-email-xingchao.wang@linux.intel.com \
    --to=xingchao.wang@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@ffwll.ch \
    --cc=david.henningsson@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jocelyn.li@intel.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=tiwai@suse.de \
    --cc=xingchao.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox