From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Ben Widawsky <ben@bwidawsk.net>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH 3/5] drm/i915: Remove node only when allocated
Date: Fri, 9 Aug 2013 22:12:14 -0700 [thread overview]
Message-ID: <1376111536-12461-3-git-send-email-benjamin.widawsky@intel.com> (raw)
In-Reply-To: <1376111536-12461-1-git-send-email-benjamin.widawsky@intel.com>
In upcoming code, it will be possible for a vma to have been created,
but no space reserved for it in the address space. The drm_mm semantics
are such that trying to remove an unallocated node is not allowed.
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
drivers/gpu/drm/i915/i915_gem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index a60c773..c287072 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2629,7 +2629,8 @@ int i915_vma_unbind(struct i915_vma *vma)
if (i915_is_ggtt(vma->vm))
obj->map_and_fenceable = true;
- drm_mm_remove_node(&vma->node);
+ if (drm_mm_node_allocated(&vma->node))
+ drm_mm_remove_node(&vma->node);
i915_gem_vma_destroy(vma);
/* Since the unbound list is global, only move to that list if
--
1.8.3.4
next prev parent reply other threads:[~2013-08-10 5:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 5:12 [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable Ben Widawsky
2013-08-10 5:12 ` [PATCH 2/5] drm/i915: bind m&f cleanup Ben Widawsky
2013-08-10 8:41 ` Chris Wilson
2013-08-13 0:17 ` Ben Widawsky
2013-08-10 5:12 ` Ben Widawsky [this message]
2013-08-10 8:45 ` [PATCH 3/5] drm/i915: Remove node only when allocated Chris Wilson
2013-08-13 1:37 ` Ben Widawsky
2013-08-10 5:12 ` [PATCH 4/5] drm: WARN when removing unallocated node Ben Widawsky
2013-08-10 8:48 ` Chris Wilson
2013-08-10 5:12 ` [PATCH 5/5] drm/i915: Convert execbuf code to use vmas Ben Widawsky
2013-08-10 9:01 ` Chris Wilson
2013-08-10 9:10 ` Chris Wilson
2013-08-10 9:13 ` Chris Wilson
2013-08-13 1:50 ` Ben Widawsky
2013-08-10 8:43 ` [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable Chris Wilson
2013-08-10 8:58 ` Daniel Vetter
2013-08-10 8:58 ` Daniel Vetter
2013-08-10 17:17 ` Ben Widawsky
2013-08-10 18:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376111536-12461-3-git-send-email-benjamin.widawsky@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox