From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Ben Widawsky <benjamin.widawsky@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable
Date: Sat, 10 Aug 2013 10:58:01 +0200 [thread overview]
Message-ID: <20130810085801.GG31670@phenom.ffwll.local> (raw)
In-Reply-To: <20130810084348.GC3561@cantiga.alporthouse.com>
On Sat, Aug 10, 2013 at 09:43:48AM +0100, Chris Wilson wrote:
> On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote:
> > I just noticed in our code we don't really check the assertion, and
> > given some of the code I am changing in this area, I feel a WARN is very
> > nice to have.
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> This is BUG() class. A WARN by itself here isn't going to prevent
> calamity, so cleanup and let userspace die gracefully. The alternative
> is random hw borkage (hopefully triggering an OOPS before it gets too
> far).
I think WARN is ok, there should be enough time for it to hit the logs
before the evenutal machine death. Generally if a WARN requires us to add
more cleanup code it's imo not worth it.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-08-10 8:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 5:12 [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable Ben Widawsky
2013-08-10 5:12 ` [PATCH 2/5] drm/i915: bind m&f cleanup Ben Widawsky
2013-08-10 8:41 ` Chris Wilson
2013-08-13 0:17 ` Ben Widawsky
2013-08-10 5:12 ` [PATCH 3/5] drm/i915: Remove node only when allocated Ben Widawsky
2013-08-10 8:45 ` Chris Wilson
2013-08-13 1:37 ` Ben Widawsky
2013-08-10 5:12 ` [PATCH 4/5] drm: WARN when removing unallocated node Ben Widawsky
2013-08-10 8:48 ` Chris Wilson
2013-08-10 5:12 ` [PATCH 5/5] drm/i915: Convert execbuf code to use vmas Ben Widawsky
2013-08-10 9:01 ` Chris Wilson
2013-08-10 9:10 ` Chris Wilson
2013-08-10 9:13 ` Chris Wilson
2013-08-13 1:50 ` Ben Widawsky
2013-08-10 8:43 ` [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable Chris Wilson
2013-08-10 8:58 ` Daniel Vetter [this message]
2013-08-10 8:58 ` Daniel Vetter
2013-08-10 17:17 ` Ben Widawsky
2013-08-10 18:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130810085801.GG31670@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox