public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/6] drm/i915: Downgrade pipe state mismatches to DRM_DEBUG_KMS
Date: Mon,  2 Dec 2013 11:26:08 -0200	[thread overview]
Message-ID: <1385990771-3877-4-git-send-email-rodrigo.vivi@gmail.com> (raw)
In-Reply-To: <1385990771-3877-1-git-send-email-rodrigo.vivi@gmail.com>

From: Adam Jackson <ajax@redhat.com>

This is, by far, the most common kernel retrace in i915 I'm seeing:

https://retrace.fedoraproject.org/faf/problems/1346879/

There's not enough information in the backtrace to know if something
actually went wrong or if this is just an assertion failure, so it's
pretty useless.  Downgrade this to DRM_DEBUG_KMS so we can still see it
if we want it.

Signed-off-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 035588a..a403611 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9463,7 +9463,7 @@ check_crtc_state(struct drm_device *dev)
 
 		if (active &&
 		    !intel_pipe_config_compare(dev, &crtc->config, &pipe_config)) {
-			WARN(1, "pipe state doesn't match!\n");
+			DRM_DEBUG_KMS("pipe state doesn't match!\n");
 			intel_dump_pipe_config(crtc, &pipe_config,
 					       "[hw state]");
 			intel_dump_pipe_config(crtc, &crtc->config,
-- 
1.8.3.1

  parent reply	other threads:[~2013-12-02 13:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 13:26 [PATCH 0/6] drm-intel-collector - update Rodrigo Vivi
2013-12-02 13:26 ` [PATCH 1/6] drm/i915: Asynchronously perform the set-base for a simple modeset Rodrigo Vivi
2013-12-02 13:26 ` [PATCH 2/6] drm/i915: Do hw quiescing first during unload Rodrigo Vivi
2013-12-05 11:49   ` Daniel Vetter
2013-12-02 13:26 ` Rodrigo Vivi [this message]
2013-12-05 11:49   ` [PATCH 3/6] drm/i915: Downgrade pipe state mismatches to DRM_DEBUG_KMS Daniel Vetter
2013-12-02 13:26 ` [PATCH 4/6] drm/i915: use __packed instead of __attribute__((packed)) Rodrigo Vivi
2013-12-03 11:34   ` Damien Lespiau
2013-12-02 13:26 ` [PATCH 5/6] drm/i915: parse backlight modulation frequency from the BIOS VBT Rodrigo Vivi
2013-12-06 12:45   ` Rodrigo Vivi
2013-12-02 13:26 ` [PATCH 6/6] drm/i915: i830M has watermarks like i855 Rodrigo Vivi
2013-12-02 14:27   ` Thomas Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385990771-3877-4-git-send-email-rodrigo.vivi@gmail.com \
    --to=rodrigo.vivi@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox