From: Kenneth Graunke <kenneth@whitecape.org>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: [PATCH 2/2] rendercopy/bdw: Fix length of a bunch of zeroed out packets.
Date: Mon, 9 Dec 2013 23:29:36 -0800 [thread overview]
Message-ID: <1386660576-1861-2-git-send-email-kenneth@whitecape.org> (raw)
In-Reply-To: <1386660576-1861-1-git-send-email-kenneth@whitecape.org>
A bunch of packets were too short.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Cc: Ben Widawsky <ben@bwidawsk.net>
Cc: Damien Lespiau <damien.lespiau@intel.com>
---
lib/rendercopy_gen8.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
The test is still broken for me, but I figure these patches are necessary
(if not sufficient)
diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
index 38dc0e7..45a134c 100644
--- a/lib/rendercopy_gen8.c
+++ b/lib/rendercopy_gen8.c
@@ -584,7 +584,10 @@ gen8_emit_vs(struct intel_batchbuffer *batch) {
OUT_BATCH(0);
OUT_BATCH(0);
- OUT_BATCH(GEN6_3DSTATE_VS | (6-2));
+ OUT_BATCH(GEN6_3DSTATE_VS | (9-2));
+ OUT_BATCH(0);
+ OUT_BATCH(0);
+ OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
@@ -606,7 +609,9 @@ gen8_emit_hs(struct intel_batchbuffer *batch) {
OUT_BATCH(0);
OUT_BATCH(0);
- OUT_BATCH(GEN7_3DSTATE_HS | (7-2));
+ OUT_BATCH(GEN7_3DSTATE_HS | (9-2));
+ OUT_BATCH(0);
+ OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
@@ -635,7 +640,10 @@ gen8_emit_gs(struct intel_batchbuffer *batch) {
OUT_BATCH(0);
OUT_BATCH(0);
- OUT_BATCH(GEN7_3DSTATE_GS | (7-2));
+ OUT_BATCH(GEN7_3DSTATE_GS | (10-2));
+ OUT_BATCH(0);
+ OUT_BATCH(0);
+ OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
@@ -664,7 +672,10 @@ gen8_emit_ds(struct intel_batchbuffer *batch) {
OUT_BATCH(0);
OUT_BATCH(0);
- OUT_BATCH(GEN7_3DSTATE_DS | (6-2));
+ OUT_BATCH(GEN7_3DSTATE_DS | (9-2));
+ OUT_BATCH(0);
+ OUT_BATCH(0);
+ OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
@@ -786,7 +797,8 @@ gen8_emit_ps(struct intel_batchbuffer *batch, uint32_t kernel) {
static void
gen8_emit_depth(struct intel_batchbuffer *batch) {
- OUT_BATCH(GEN7_3DSTATE_DEPTH_BUFFER | (7-2));
+ OUT_BATCH(GEN7_3DSTATE_DEPTH_BUFFER | (8-2));
+ OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
@@ -937,7 +949,9 @@ void gen8_render_copyfunc(struct intel_batchbuffer *batch,
gen8_emit_null_state(batch);
- OUT_BATCH(GEN7_3DSTATE_STREAMOUT | 1);
+ OUT_BATCH(GEN7_3DSTATE_STREAMOUT | (5-2));
+ OUT_BATCH(0);
+ OUT_BATCH(0);
OUT_BATCH(0);
OUT_BATCH(0);
--
1.8.4.2
next prev parent reply other threads:[~2013-12-10 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 7:29 [PATCH 1/2] rendercopy/bdw: Emit 3DSTATE_WM_HZ_OP Kenneth Graunke
2013-12-10 7:29 ` Kenneth Graunke [this message]
2013-12-10 11:40 ` Damien Lespiau
2013-12-10 17:04 ` Kenneth Graunke
2013-12-11 1:44 ` Xiang, Haihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386660576-1861-2-git-send-email-kenneth@whitecape.org \
--to=kenneth@whitecape.org \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox