Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/8] drm/i915/vlv: split DPIO init and reset
Date: Mon, 16 Dec 2013 16:34:24 -0800	[thread overview]
Message-ID: <1387240469-932-3-git-send-email-jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <1387240469-932-1-git-send-email-jbarnes@virtuousgeek.org>

We only need to init the reg offset for DPIO once, but we need to reset
DPIO at resume time and at init time.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_display.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a30176b..a2cd692 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1368,6 +1368,15 @@ static void intel_init_dpio(struct drm_device *dev)
 		return;
 
 	DPIO_PHY_IOSF_PORT(DPIO_PHY0) = IOSF_PORT_DPIO;
+}
+
+static void intel_reset_dpio(struct drm_device *dev)
+{
+	struct drm_i915_private *dev_priv = dev->dev_private;
+
+	if (!IS_VALLEYVIEW(dev))
+		return;
+
 	/*
 	 * From VLV2A0_DP_eDP_DPIO_driver_vbios_notes_10.docx -
 	 *  6.	De-assert cmn_reset/side_reset. Same as VLV X0.
@@ -10799,7 +10808,7 @@ void intel_modeset_init_hw(struct drm_device *dev)
 		I915_WRITE(DPLL(PIPE_B), I915_READ(DPLL(PIPE_B)) |
 			   DPLL_INTEGRATED_CRI_CLK_VLV);
 
-	intel_init_dpio(dev);
+	intel_reset_dpio(dev);
 
 	mutex_lock(&dev->struct_mutex);
 	intel_enable_gt_powersave(dev);
@@ -10862,6 +10871,7 @@ void intel_modeset_init(struct drm_device *dev)
 	}
 
 	intel_init_dpio(dev);
+	intel_reset_dpio(dev);
 
 	intel_cpu_pll_init(dev);
 	intel_shared_dpll_init(dev);
-- 
1.8.4.2

  parent reply	other threads:[~2013-12-17  0:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  0:34 [PATCH 1/8] drm/i915: unconditionally copy mode into crtc at boot time Jesse Barnes
2013-12-17  0:34 ` [PATCH 2/8] drm/i915/vlv: add early DPIO init v3 Jesse Barnes
2013-12-17  0:34 ` Jesse Barnes [this message]
2013-12-17  0:34 ` [PATCH 4/8] drm/i915: read out hw state earlier Jesse Barnes
2013-12-17  8:47   ` Daniel Vetter
2013-12-17  0:34 ` [PATCH 5/8] drm/i915: retrieve current fb config into new plane_config structure at init v7 Jesse Barnes
2013-12-17 10:03   ` Chris Wilson
2013-12-17 21:03     ` Jesse Barnes
2013-12-17  0:34 ` [PATCH 6/8] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7 Jesse Barnes
2013-12-17 10:34   ` Chris Wilson
2013-12-17 21:05     ` Jesse Barnes
2013-12-17 21:17       ` Daniel Vetter
2013-12-17 21:30         ` Jesse Barnes
2013-12-17 21:58           ` Daniel Vetter
2013-12-17 22:51             ` Chris Wilson
2013-12-18  8:07               ` Daniel Vetter
2013-12-17 19:29   ` Chris Wilson
2013-12-17 21:11     ` Jesse Barnes
2013-12-17  0:34 ` [PATCH 7/8] drm/i915: don't memset the fb buffer if preallocated Jesse Barnes
2013-12-17  0:34 ` [PATCH 8/8] drm/i915: inform drm_fb_helper if we abandoned a connected output v2 Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387240469-932-3-git-send-email-jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox