From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 7/8] drm/i915: don't memset the fb buffer if preallocated
Date: Mon, 16 Dec 2013 16:34:28 -0800 [thread overview]
Message-ID: <1387240469-932-7-git-send-email-jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <1387240469-932-1-git-send-email-jbarnes@virtuousgeek.org>
We want to preserve the BIOS/bootloader contents for later.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
drivers/gpu/drm/i915/intel_fbdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
index db75f22..53675d2 100644
--- a/drivers/gpu/drm/i915/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/intel_fbdev.c
@@ -132,6 +132,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
struct drm_framebuffer *fb;
struct drm_i915_gem_object *obj;
int size, ret;
+ bool prealloc = false;
mutex_lock(&dev->struct_mutex);
@@ -142,6 +143,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
goto out_unlock;
} else {
DRM_DEBUG_KMS("re-using BIOS fb\n");
+ prealloc = true;
sizes->fb_width = intel_fb->base.width;
sizes->fb_height = intel_fb->base.height;
}
@@ -203,7 +205,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
* If the object is stolen however, it will be full of whatever
* garbage was left in there.
*/
- if (ifbdev->fb->obj->stolen)
+ if (ifbdev->fb->obj->stolen && !prealloc)
memset_io(info->screen_base, 0, info->screen_size);
/* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
--
1.8.4.2
next prev parent reply other threads:[~2013-12-17 0:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 0:34 [PATCH 1/8] drm/i915: unconditionally copy mode into crtc at boot time Jesse Barnes
2013-12-17 0:34 ` [PATCH 2/8] drm/i915/vlv: add early DPIO init v3 Jesse Barnes
2013-12-17 0:34 ` [PATCH 3/8] drm/i915/vlv: split DPIO init and reset Jesse Barnes
2013-12-17 0:34 ` [PATCH 4/8] drm/i915: read out hw state earlier Jesse Barnes
2013-12-17 8:47 ` Daniel Vetter
2013-12-17 0:34 ` [PATCH 5/8] drm/i915: retrieve current fb config into new plane_config structure at init v7 Jesse Barnes
2013-12-17 10:03 ` Chris Wilson
2013-12-17 21:03 ` Jesse Barnes
2013-12-17 0:34 ` [PATCH 6/8] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7 Jesse Barnes
2013-12-17 10:34 ` Chris Wilson
2013-12-17 21:05 ` Jesse Barnes
2013-12-17 21:17 ` Daniel Vetter
2013-12-17 21:30 ` Jesse Barnes
2013-12-17 21:58 ` Daniel Vetter
2013-12-17 22:51 ` Chris Wilson
2013-12-18 8:07 ` Daniel Vetter
2013-12-17 19:29 ` Chris Wilson
2013-12-17 21:11 ` Jesse Barnes
2013-12-17 0:34 ` Jesse Barnes [this message]
2013-12-17 0:34 ` [PATCH 8/8] drm/i915: inform drm_fb_helper if we abandoned a connected output v2 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387240469-932-7-git-send-email-jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox