Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] uxa: fix pageflips on 3 head scenarios
@ 2014-05-20  1:44 Dave Airlie
  2014-05-20  6:48 ` Chris Wilson
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Airlie @ 2014-05-20  1:44 UTC (permalink / raw)
  To: intel-gfx

From: Dave Airlie <airlied@redhat.com>

While fixing up UXA for MST I eventually fell over this bug.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 src/uxa/intel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/uxa/intel.h b/src/uxa/intel.h
index 6ac770e..f9dbd96 100644
--- a/src/uxa/intel.h
+++ b/src/uxa/intel.h
@@ -334,7 +334,7 @@ typedef struct intel_screen_private {
 	Bool has_kernel_flush;
 	Bool needs_flush;
 
-	struct _DRI2FrameEvent *pending_flip[2];
+	struct _DRI2FrameEvent *pending_flip[3];
 
 	/* Broken-out options. */
 	OptionInfoPtr Options;
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] uxa: fix pageflips on 3 head scenarios
  2014-05-20  1:44 [PATCH] uxa: fix pageflips on 3 head scenarios Dave Airlie
@ 2014-05-20  6:48 ` Chris Wilson
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2014-05-20  6:48 UTC (permalink / raw)
  To: Dave Airlie; +Cc: intel-gfx

On Tue, May 20, 2014 at 11:44:04AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> While fixing up UXA for MST I eventually fell over this bug.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Oops, that's bad - sorry for sending you on that chase.

I amended the commit to use MAX_PIPES so hopefully it is easier to spot
the bad code again in future and pushed.

commit 197ab0cda06c44aa1a2b17bf69ac08612811b107
Author: Dave Airlie <airlied@gmail.com>
Date:   Tue May 20 07:45:14 2014 +0100

    uxa: fix pageflips on 3 head scenarios

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-20  6:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-20  1:44 [PATCH] uxa: fix pageflips on 3 head scenarios Dave Airlie
2014-05-20  6:48 ` Chris Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox