From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/i915: make userspace mode sets asynchronous
Date: Fri, 30 May 2014 11:05:22 -0700 [thread overview]
Message-ID: <1401473122-3451-2-git-send-email-jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <1401473122-3451-1-git-send-email-jbarnes@virtuousgeek.org>
Now that we can queue CRTC enable/disable calls for later, we can allow
userspace mode sets to return immediately. This may mean that userspace
will draw into a buffer that's not yet displayed (which is fine) or that
it may draw into a buffer it thinks is no longer displayed (which could
lead to some visual artifacts until the mode set completes, but is
otherwise harmless). Page flip and cursor activity will synchronize
with any outstanding activity to avoid problems with the display being
off for those operations.
It should be possible to queue those ops as well though and further
de-couple driver updates of the hw state from userspace queueing of
commands.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
drivers/gpu/drm/i915/intel_display.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8c52038..74310b5 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -10545,10 +10545,6 @@ static int intel_set_mode(struct drm_crtc *crtc,
ret = __intel_set_mode(crtc, mode, x, y, fb);
- intel_sync_crtcs(crtc->dev->dev_private);
- if (ret == 0)
- intel_modeset_check_state(crtc->dev);
-
return ret;
}
--
1.9.1
next prev parent reply other threads:[~2014-05-30 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 18:05 [PATCH 1/2] drm/i915: make CRTC enable/disable asynchronous v2 Jesse Barnes
2014-05-30 18:05 ` Jesse Barnes [this message]
2014-05-30 18:47 ` Chris Wilson
2014-05-30 18:50 ` Jesse Barnes
2014-05-30 18:53 ` Chris Wilson
2014-05-30 18:56 ` Chris Wilson
2014-05-30 19:06 ` Jesse Barnes
2014-05-30 21:28 ` [PATCH] drm/i915: make CRTC enable/disable asynchronous v3 Jesse Barnes
2014-05-30 22:02 ` Chris Wilson
2014-05-30 22:10 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401473122-3451-2-git-send-email-jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox