From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: make CRTC enable/disable asynchronous v2
Date: Fri, 30 May 2014 11:50:22 -0700 [thread overview]
Message-ID: <20140530115022.178f5e49@jbarnes-desktop> (raw)
In-Reply-To: <20140530184756.GC10916@nuc-i3427.alporthouse.com>
On Fri, 30 May 2014 19:47:56 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, May 30, 2014 at 11:05:21AM -0700, Jesse Barnes wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index e2bfdda..e7fa84f 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -530,7 +530,7 @@ static int i915_drm_freeze(struct drm_device *dev)
> > mutex_lock(&dev->mode_config.mutex);
> > for_each_crtc(dev, crtc) {
> > mutex_lock(&crtc->mutex);
> > - dev_priv->display.crtc_disable(crtc);
> > + dev_priv->display._crtc_disable(crtc);
>
> Don't you want to cancel the pending work here or it will be run on
> resume - but on resume, we just want to send the hotplug event and let
> userspace set itself up in the new configuration.
No you're right I need to cancel it here and in unload, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-05-30 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 18:05 [PATCH 1/2] drm/i915: make CRTC enable/disable asynchronous v2 Jesse Barnes
2014-05-30 18:05 ` [PATCH 2/2] drm/i915: make userspace mode sets asynchronous Jesse Barnes
2014-05-30 18:47 ` [PATCH 1/2] drm/i915: make CRTC enable/disable asynchronous v2 Chris Wilson
2014-05-30 18:50 ` Jesse Barnes [this message]
2014-05-30 18:53 ` Chris Wilson
2014-05-30 18:56 ` Chris Wilson
2014-05-30 19:06 ` Jesse Barnes
2014-05-30 21:28 ` [PATCH] drm/i915: make CRTC enable/disable asynchronous v3 Jesse Barnes
2014-05-30 22:02 ` Chris Wilson
2014-05-30 22:10 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530115022.178f5e49@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox