From: Damien Lespiau <damien.lespiau@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915: Remove return; at the end of a function returning void
Date: Tue, 3 Jun 2014 14:21:16 +0100 [thread overview]
Message-ID: <1401801676-8116-1-git-send-email-damien.lespiau@intel.com> (raw)
intel_dsi_init() lost its return value in:
Damien Lespiau <damien.lespiau@intel.com>
Date: Wed May 28 12:30:56 2014 +0100
drm/i915: Make intel_dsi_init() return void
However, I left a return; at the end of the function and, as Jani noticed, it
looks silly.
Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/i915/intel_dsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 9d789b3..bd89de5 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -759,6 +759,4 @@ err:
drm_encoder_cleanup(&intel_encoder->base);
kfree(intel_dsi);
kfree(intel_connector);
-
- return;
}
--
1.8.3.1
next reply other threads:[~2014-06-03 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 13:21 Damien Lespiau [this message]
2014-06-03 13:35 ` [PATCH] drm/i915: Remove return; at the end of a function returning void Jani Nikula
2014-06-03 13:37 ` Damien Lespiau
2014-06-03 14:36 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401801676-8116-1-git-send-email-damien.lespiau@intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox