From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove return; at the end of a function returning void
Date: Tue, 3 Jun 2014 16:36:11 +0200 [thread overview]
Message-ID: <20140603143611.GG7416@phenom.ffwll.local> (raw)
In-Reply-To: <20140603133727.GD17813@strange.amr.corp.intel.com>
On Tue, Jun 03, 2014 at 02:37:27PM +0100, Damien Lespiau wrote:
> On Tue, Jun 03, 2014 at 04:35:01PM +0300, Jani Nikula wrote:
> > On Tue, 03 Jun 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > > intel_dsi_init() lost its return value in:
> > >
> > > Damien Lespiau <damien.lespiau@intel.com>
> > > Date: Wed May 28 12:30:56 2014 +0100
> > >
> > > drm/i915: Make intel_dsi_init() return void
> > >
> > > However, I left a return; at the end of the function and, as Jani noticed, it
> > > looks silly.
> >
> > Thanks. R-b and all that if Daniel needs it.
>
> If it's not too late to rewrite history, please consider squashing it
> with:
> drm/i915: Make intel_dsi_init() return void
History is rectified.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-06-03 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 13:21 [PATCH] drm/i915: Remove return; at the end of a function returning void Damien Lespiau
2014-06-03 13:35 ` Jani Nikula
2014-06-03 13:37 ` Damien Lespiau
2014-06-03 14:36 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603143611.GG7416@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox