[PATCH] drm/i915: BDW: Adding missing cursor offsets.

[PATCH] drm/i915: BDW: Adding missing cursor offsets.

[Rodrigo Vivi]

BDW uses IVB cursor offsets.

Whithout this patch it is not possible to use multiple outputs with cursor
on BDW.
The cursor gets completely crazy because update position uses the wrong
cursor register for the second pipe.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index f9cd5ff..615b62f 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -315,6 +315,7 @@ static const struct intel_device_info intel_broadwell_m_info = {
 	.has_ddi = 1,
 	.has_fbc = 1,
 	GEN_DEFAULT_PIPEOFFSETS,
+	IVB_CURSOR_OFFSETS,
 };
 
 static const struct intel_device_info intel_broadwell_gt3d_info = {
@@ -325,6 +326,7 @@ static const struct intel_device_info intel_broadwell_gt3d_info = {
 	.has_ddi = 1,
 	.has_fbc = 1,
 	GEN_DEFAULT_PIPEOFFSETS,
+	IVB_CURSOR_OFFSETS,
 };
 
 static const struct intel_device_info intel_broadwell_gt3m_info = {
-- 
1.9.3

Re: [PATCH] drm/i915: BDW: Adding missing cursor offsets.

[Ben Widawsky]

On Wed, Jun 04, 2014 at 05:09:30PM -0700, Rodrigo Vivi wrote:
> BDW uses IVB cursor offsets.
> 
> Whithout this patch it is not possible to use multiple outputs with cursor
> on BDW.
> The cursor gets completely crazy because update position uses the wrong
> cursor register for the second pipe.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Should be cc: stable IMO
[snip]

-- 
Ben Widawsky, Intel Open Source Technology Center

Re: [PATCH] drm/i915: BDW: Adding missing cursor offsets.

[Rodrigo Vivi]

[-- Attachment #1.1: Type: text/plain, Size: 749 bytes --]

I just noticed and verified this patch fixes this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=79621



On Wed, Jun 4, 2014 at 5:16 PM, Ben Widawsky <ben@bwidawsk.net> wrote:

> On Wed, Jun 04, 2014 at 05:09:30PM -0700, Rodrigo Vivi wrote:
> > BDW uses IVB cursor offsets.
> >
> > Whithout this patch it is not possible to use multiple outputs with
> cursor
> > on BDW.
> > The cursor gets completely crazy because update position uses the wrong
> > cursor register for the second pipe.
> >
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
>
> Should be cc: stable IMO
> [snip]
>
> --
> Ben Widawsky, Intel Open Source Technology Center
>



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

[-- Attachment #1.2: Type: text/html, Size: 1501 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: BDW: Adding missing cursor offsets.

[Daniel Vetter]

On Wed, Jun 04, 2014 at 05:16:25PM -0700, Ben Widawsky wrote:
> On Wed, Jun 04, 2014 at 05:09:30PM -0700, Rodrigo Vivi wrote:
> > BDW uses IVB cursor offsets.
> > 
> > Whithout this patch it is not possible to use multiple outputs with cursor
> > on BDW.
> > The cursor gets completely crazy because update position uses the wrong
> > cursor register for the second pipe.
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Thanks.
> 
> Should be cc: stable IMO
> [snip]

Agreed.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch