public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tom.O'Rourke@intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/i915: Keep min freq above floor on HSW/BDW
Date: Wed,  5 Nov 2014 17:31:35 -0800	[thread overview]
Message-ID: <1415237495-89576-3-git-send-email-Tom.O'Rourke@intel.com> (raw)
In-Reply-To: <1415237495-89576-1-git-send-email-Tom.O'Rourke@intel.com>

From: Tom O'Rourke <Tom.O'Rourke@intel.com>

Set the min_freq_softlimit to max(RPe, 450MHz).

Setting a floor can ensure a minimum experience
level.  The 450MHz value came from a power and
performance study of various types of workloads
(3D, Media, GPGPU, idle, etc).

Signed-off-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index e4347d9..1244ff8 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4779,7 +4779,8 @@ static void gen8_enable_rps(struct drm_device *dev)
 
 	if (IS_BROADWELL(dev)) {
 		hsw_use_efficient_freq(dev_priv);
-		dev_priv->rps.min_freq_softlimit = dev_priv->rps.efficient_freq;
+		dev_priv->rps.min_freq_softlimit =
+			max(dev_priv->rps.efficient_freq, (u8) 9); /* 450 MHz */
 	}
 
 	/* 2b: Program RC6 thresholds.*/
@@ -4879,7 +4880,8 @@ static void gen6_enable_rps(struct drm_device *dev)
 
 	if (IS_HASWELL(dev)) {
 		hsw_use_efficient_freq(dev_priv);
-		dev_priv->rps.min_freq_softlimit = dev_priv->rps.efficient_freq;
+		dev_priv->rps.min_freq_softlimit =
+			max(dev_priv->rps.efficient_freq, (u8) 9); /* 450 MHz */
 	}
 
 	/* disable the counters and set deterministic thresholds */
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2014-11-06  1:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  1:31 [PATCH 0/2] Update turbo (rps) min frequency for HSW/BDW Tom.O'Rourke
2014-11-06  1:31 ` [PATCH 1/2] drm/i915: Use efficient " Tom.O'Rourke
2014-11-07  9:50   ` Daniel Vetter
2014-11-07 22:20     ` O'Rourke, Tom
2014-11-11 15:11       ` Daniel Vetter
2014-11-07 10:41   ` Chris Wilson
2014-11-07 22:25     ` O'Rourke, Tom
2014-11-08  8:25       ` Chris Wilson
2014-11-11 15:13         ` Daniel Vetter
2014-11-11 16:12           ` Chris Wilson
2014-11-12  8:37             ` Daniel Vetter
2014-11-06  1:31 ` Tom.O'Rourke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1415237495-89576-3-git-send-email-Tom.O'\''Rourke@intel.com' \
    --to=tom.o'rourke@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox