From: "Lahtinen, Joonas" <joonas.lahtinen@intel.com>
To: "daniel@ffwll.ch" <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT
Date: Tue, 17 Mar 2015 05:34:49 +0000 [thread overview]
Message-ID: <1426570488.3385.3.camel@jlahtine-mobl1> (raw)
In-Reply-To: <1426570290.3385.0.camel@jlahtine-mobl1>
On ti, 2015-03-17 at 07:31 +0200, Joonas Lahtinen wrote:
> On ma, 2015-03-16 at 18:50 +0100, Daniel Vetter wrote:
> > On Mon, Mar 16, 2015 at 02:11:13PM +0200, Joonas Lahtinen wrote:
> > [snip]
> > > int i915_vma_bind(struct i915_vma *vma, enum i915_cache_level cache_level,
> > > u32 flags);
> > > @@ -2800,60 +2796,48 @@ struct dma_buf *i915_gem_prime_export(struct drm_device *dev,
> > >
> > > void i915_gem_restore_fences(struct drm_device *dev);
> > >
> > > -unsigned long i915_gem_obj_offset_view(struct drm_i915_gem_object *o,
> > > - struct i915_address_space *vm,
> > > - enum i915_ggtt_view_type view);
> > > -static inline
> > > -unsigned long i915_gem_obj_offset(struct drm_i915_gem_object *o,
> > > - struct i915_address_space *vm)
> > > +static inline bool i915_is_ggtt(struct i915_address_space *vm);
Indeed it is. Thanks!
Regards, Joonas
PS. Sorry for spam, the enter key is so close to the space bar.
> >
> > This forward decl seems unneeded leftover from earlier patch iterations.
> > I've removed it and merged the patch.
> >
> > Thanks, Daniel
> >
> > [snip]
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-17 5:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 12:11 [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT Joonas Lahtinen
2015-03-16 13:26 ` Tvrtko Ursulin
2015-03-16 14:48 ` Joonas Lahtinen
2015-03-16 14:50 ` Tvrtko Ursulin
2015-03-16 14:52 ` shuang.he
2015-03-16 17:50 ` Daniel Vetter
2015-03-17 5:31 ` Joonas Lahtinen
2015-03-17 5:34 ` Lahtinen, Joonas [this message]
2015-03-17 14:19 ` Tvrtko Ursulin
2015-03-18 8:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426570488.3385.3.camel@jlahtine-mobl1 \
--to=joonas.lahtinen@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox