public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT
Date: Tue, 17 Mar 2015 14:19:18 +0000	[thread overview]
Message-ID: <550837E6.7030802@linux.intel.com> (raw)
In-Reply-To: <1426507873.5166.1.camel@jlahtine-mobl1>


Hi,

On 03/16/2015 12:11 PM, Joonas Lahtinen wrote:
> GGTT views are only applicable when dealing with GGTT. Change the code to
> reject ggtt_view where it should not be used and require it when it should
> be.
>
> v2:
> - Dropped _ppgtt_ infixes, allow both types to be passed
> - Disregard other but normal views when no view is specified
> - More checks that valid parameters are passed
> - More readable error checking
>
> v3:
> - Prefer WARN_ONCE over BUG_ON when there is code path for failure

[snip]

> +unsigned long
> +i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
> +			      enum i915_ggtt_view_type view)
>   {
> +	struct drm_i915_private *dev_priv = o->base.dev->dev_private;

Unused variable slipped through, oops! :)

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-03-17 14:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 12:11 [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT Joonas Lahtinen
2015-03-16 13:26 ` Tvrtko Ursulin
2015-03-16 14:48   ` Joonas Lahtinen
2015-03-16 14:50     ` Tvrtko Ursulin
2015-03-16 14:52 ` shuang.he
2015-03-16 17:50 ` Daniel Vetter
2015-03-17  5:31   ` Joonas Lahtinen
2015-03-17  5:34     ` Lahtinen, Joonas
2015-03-17 14:19 ` Tvrtko Ursulin [this message]
2015-03-18  8:22   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550837E6.7030802@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox