* [PATCH] drm/i915: Remove redundant memset in skl_clear_wm
@ 2016-03-14 15:15 Gabriel Feceoru
2016-03-14 16:31 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-21 10:54 ` [PATCH] " Ander Conselvan De Oliveira
0 siblings, 2 replies; 3+ messages in thread
From: Gabriel Feceoru @ 2016-03-14 15:15 UTC (permalink / raw)
To: intel-gfx
Since I915_MAX_PLANES = PLANE_CURSOR + 1, explicit clearing the wm
values for PLANE_CURSOR is already done earlier by a memset.
Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index f65e841..f6afeae 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3641,7 +3641,6 @@ static void skl_clear_wm(struct skl_wm_values *watermarks, enum pipe pipe)
sizeof(uint32_t) * 8 * I915_MAX_PLANES);
memset(watermarks->plane_trans[pipe],
0, sizeof(uint32_t) * I915_MAX_PLANES);
- watermarks->plane_trans[pipe][PLANE_CURSOR] = 0;
/* Clear ddb entries for pipe */
memset(&watermarks->ddb.pipe[pipe], 0, sizeof(struct skl_ddb_entry));
@@ -3649,9 +3648,6 @@ static void skl_clear_wm(struct skl_wm_values *watermarks, enum pipe pipe)
sizeof(struct skl_ddb_entry) * I915_MAX_PLANES);
memset(&watermarks->ddb.y_plane[pipe], 0,
sizeof(struct skl_ddb_entry) * I915_MAX_PLANES);
- memset(&watermarks->ddb.plane[pipe][PLANE_CURSOR], 0,
- sizeof(struct skl_ddb_entry));
-
}
static void skl_update_wm(struct drm_crtc *crtc)
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Remove redundant memset in skl_clear_wm
2016-03-14 15:15 [PATCH] drm/i915: Remove redundant memset in skl_clear_wm Gabriel Feceoru
@ 2016-03-14 16:31 ` Patchwork
2016-03-21 10:54 ` [PATCH] " Ander Conselvan De Oliveira
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2016-03-14 16:31 UTC (permalink / raw)
To: Feceoru, Gabriel; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove redundant memset in skl_clear_wm
URL : https://patchwork.freedesktop.org/series/4436/
State : failure
== Summary ==
Series 4436v1 drm/i915: Remove redundant memset in skl_clear_wm
http://patchwork.freedesktop.org/api/1.0/series/4436/revisions/1/mbox/
Test drv_hangman:
Subgroup error-state-basic:
pass -> INCOMPLETE (snb-dellxps)
Test gem_exec_basic:
Subgroup readonly-render:
incomplete -> PASS (ilk-hp8440p)
Test gem_mmap_gtt:
Subgroup basic-write-no-prefault:
incomplete -> PASS (ilk-hp8440p)
Test gem_ringfill:
Subgroup basic-default-s3:
dmesg-warn -> PASS (bsw-nuc-2)
incomplete -> DMESG-WARN (ilk-hp8440p)
Test gem_tiled_pread_basic:
incomplete -> PASS (byt-nuc)
Test kms_addfb_basic:
Subgroup addfb25-yf-tiled:
incomplete -> PASS (ilk-hp8440p)
Subgroup bad-pitch-1024:
incomplete -> PASS (ilk-hp8440p)
Subgroup size-max:
incomplete -> PASS (ilk-hp8440p)
Subgroup small-bo:
incomplete -> PASS (ilk-hp8440p)
Subgroup unused-offsets:
incomplete -> PASS (ilk-hp8440p)
Test kms_flip:
Subgroup basic-flip-vs-dpms:
dmesg-warn -> PASS (bdw-ultra)
Subgroup basic-flip-vs-modeset:
incomplete -> PASS (bsw-nuc-2)
Subgroup basic-flip-vs-wf_vblank:
pass -> DMESG-WARN (bdw-ultra)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
incomplete -> PASS (hsw-gt2)
Test pm_rpm:
Subgroup basic-pci-d3-state:
dmesg-warn -> PASS (bsw-nuc-2)
pass -> DMESG-WARN (snb-dellxps)
Test prime_self_import:
Subgroup basic-llseek-size:
incomplete -> PASS (ilk-hp8440p)
bdw-nuci7 total:194 pass:182 dwarn:0 dfail:0 fail:0 skip:12
bdw-ultra total:194 pass:172 dwarn:1 dfail:0 fail:0 skip:21
bsw-nuc-2 total:194 pass:156 dwarn:1 dfail:0 fail:0 skip:37
byt-nuc total:194 pass:154 dwarn:4 dfail:0 fail:1 skip:35
hsw-brixbox total:194 pass:172 dwarn:0 dfail:0 fail:0 skip:22
hsw-gt2 total:194 pass:177 dwarn:0 dfail:0 fail:0 skip:17
ilk-hp8440p total:194 pass:126 dwarn:4 dfail:0 fail:1 skip:63
ivb-t430s total:194 pass:169 dwarn:0 dfail:0 fail:0 skip:25
skl-i5k-2 total:194 pass:171 dwarn:0 dfail:0 fail:0 skip:23
skl-i7k-2 total:194 pass:171 dwarn:0 dfail:0 fail:0 skip:23
skl-nuci5 total:194 pass:183 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:66 pass:54 dwarn:1 dfail:0 fail:0 skip:10
snb-x220t total:194 pass:159 dwarn:1 dfail:0 fail:1 skip:33
Results at /archive/results/CI_IGT_test/Patchwork_1596/
3e5ecc8c5ff80cb1fb635ce1cf16b7cd4cfb1979 drm-intel-nightly: 2016y-03m-14d-09h-06m-00s UTC integration manifest
f93db4af1658e9b9ab6007b6ba44efd33dd7be5b drm/i915: Remove redundant memset in skl_clear_wm
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: Remove redundant memset in skl_clear_wm
2016-03-14 15:15 [PATCH] drm/i915: Remove redundant memset in skl_clear_wm Gabriel Feceoru
2016-03-14 16:31 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-03-21 10:54 ` Ander Conselvan De Oliveira
1 sibling, 0 replies; 3+ messages in thread
From: Ander Conselvan De Oliveira @ 2016-03-21 10:54 UTC (permalink / raw)
To: Gabriel Feceoru, intel-gfx
On Mon, 2016-03-14 at 17:15 +0200, Gabriel Feceoru wrote:
> Since I915_MAX_PLANES = PLANE_CURSOR + 1, explicit clearing the wm
> values for PLANE_CURSOR is already done earlier by a memset.
This is a leftover from commit 4969d33ed91d ('drm/i915/skl: Simplify wm
structures slightly (v2)').
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
>
> Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index f65e841..f6afeae 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3641,7 +3641,6 @@ static void skl_clear_wm(struct skl_wm_values
> *watermarks, enum pipe pipe)
> sizeof(uint32_t) * 8 * I915_MAX_PLANES);
> memset(watermarks->plane_trans[pipe],
> 0, sizeof(uint32_t) * I915_MAX_PLANES);
> - watermarks->plane_trans[pipe][PLANE_CURSOR] = 0;
>
> /* Clear ddb entries for pipe */
> memset(&watermarks->ddb.pipe[pipe], 0, sizeof(struct skl_ddb_entry));
> @@ -3649,9 +3648,6 @@ static void skl_clear_wm(struct skl_wm_values
> *watermarks, enum pipe pipe)
> sizeof(struct skl_ddb_entry) * I915_MAX_PLANES);
> memset(&watermarks->ddb.y_plane[pipe], 0,
> sizeof(struct skl_ddb_entry) * I915_MAX_PLANES);
> - memset(&watermarks->ddb.plane[pipe][PLANE_CURSOR], 0,
> - sizeof(struct skl_ddb_entry));
> -
> }
>
> static void skl_update_wm(struct drm_crtc *crtc)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-21 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-14 15:15 [PATCH] drm/i915: Remove redundant memset in skl_clear_wm Gabriel Feceoru
2016-03-14 16:31 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-21 10:54 ` [PATCH] " Ander Conselvan De Oliveira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox