From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/4] drm/i915: Add comments about fixed pipe->transcoder/PLL mapping
Date: Thu, 12 May 2016 16:18:50 +0300 [thread overview]
Message-ID: <1463059132-1720-3-git-send-email-imre.deak@intel.com> (raw)
In-Reply-To: <1463059132-1720-1-git-send-email-imre.deak@intel.com>
Code checkers may complain about the explicit casts between different
enum types, so add comments for known-valid cases to help future
triaging of such complaints.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b60d9b6..763726d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9294,6 +9294,7 @@ static bool ironlake_get_pipe_config(struct intel_crtc *crtc,
ironlake_get_fdi_m_n_config(crtc, pipe_config);
if (HAS_PCH_IBX(dev_priv)) {
+ /* the pipe->pll mapping is fixed */
pll_id = (enum intel_dpll_id) crtc->pipe;
} else {
tmp = I915_READ(PCH_DPLL_SEL);
@@ -9844,6 +9845,10 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
enum intel_display_power_domain power_domain;
u32 tmp;
+ /*
+ * The transcoder->pipe mapping is fixed with the exception of the eDP
+ * transcoder handled below.
+ */
pipe_config->cpu_transcoder = (enum transcoder) crtc->pipe;
/*
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-12 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 13:18 [PATCH 0/4] drm/i915: Fix a few code checker errors Imre Deak
2016-05-12 13:18 ` [PATCH 1/4] drm/i915/gen9: Avoid using negative array index in skl_update_plane() Imre Deak
2016-05-12 13:22 ` Ville Syrjälä
2016-05-12 13:18 ` Imre Deak [this message]
2016-05-12 13:30 ` [PATCH 2/4] drm/i915: Add comments about fixed pipe->transcoder/PLL mapping Ville Syrjälä
2016-05-12 14:00 ` Imre Deak
2016-05-12 14:53 ` Ville Syrjälä
2016-05-12 13:18 ` [PATCH 3/4] drm/i915: Handle error return from dma_set_coherent_mask() Imre Deak
2016-05-12 13:56 ` Ville Syrjälä
2016-05-12 13:18 ` [PATCH 4/4] drm/i915: Remove redundant const from function return type Imre Deak
2016-05-12 13:31 ` Ville Syrjälä
2016-05-12 15:31 ` ✗ Ro.CI.BAT: failure for drm/i915: Fix a few code checker errors Patchwork
2016-05-13 12:24 ` Imre Deak
2016-05-13 13:07 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463059132-1720-3-git-send-email-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox