From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] drm/i915: Remove redundant const from function return type
Date: Thu, 12 May 2016 16:18:52 +0300 [thread overview]
Message-ID: <1463059132-1720-5-git-send-email-imre.deak@intel.com> (raw)
In-Reply-To: <1463059132-1720-1-git-send-email-imre.deak@intel.com>
Marking function return types as const is redundant, as these are
rvalues and as such constant by definition. Code checkers and GCC will
warn about this so remove the modifier.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 5e5b5cc..24f4105 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -89,17 +89,17 @@ static int i915_capabilities(struct seq_file *m, void *data)
return 0;
}
-static const char get_active_flag(struct drm_i915_gem_object *obj)
+static char get_active_flag(struct drm_i915_gem_object *obj)
{
return obj->active ? '*' : ' ';
}
-static const char get_pin_flag(struct drm_i915_gem_object *obj)
+static char get_pin_flag(struct drm_i915_gem_object *obj)
{
return obj->pin_display ? 'p' : ' ';
}
-static const char get_tiling_flag(struct drm_i915_gem_object *obj)
+static char get_tiling_flag(struct drm_i915_gem_object *obj)
{
switch (obj->tiling_mode) {
default:
@@ -109,12 +109,12 @@ static const char get_tiling_flag(struct drm_i915_gem_object *obj)
}
}
-static inline const char get_global_flag(struct drm_i915_gem_object *obj)
+static char get_global_flag(struct drm_i915_gem_object *obj)
{
return i915_gem_obj_to_ggtt(obj) ? 'g' : ' ';
}
-static inline const char get_pin_mapped_flag(struct drm_i915_gem_object *obj)
+static char get_pin_mapped_flag(struct drm_i915_gem_object *obj)
{
return obj->mapping ? 'M' : ' ';
}
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-12 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 13:18 [PATCH 0/4] drm/i915: Fix a few code checker errors Imre Deak
2016-05-12 13:18 ` [PATCH 1/4] drm/i915/gen9: Avoid using negative array index in skl_update_plane() Imre Deak
2016-05-12 13:22 ` Ville Syrjälä
2016-05-12 13:18 ` [PATCH 2/4] drm/i915: Add comments about fixed pipe->transcoder/PLL mapping Imre Deak
2016-05-12 13:30 ` Ville Syrjälä
2016-05-12 14:00 ` Imre Deak
2016-05-12 14:53 ` Ville Syrjälä
2016-05-12 13:18 ` [PATCH 3/4] drm/i915: Handle error return from dma_set_coherent_mask() Imre Deak
2016-05-12 13:56 ` Ville Syrjälä
2016-05-12 13:18 ` Imre Deak [this message]
2016-05-12 13:31 ` [PATCH 4/4] drm/i915: Remove redundant const from function return type Ville Syrjälä
2016-05-12 15:31 ` ✗ Ro.CI.BAT: failure for drm/i915: Fix a few code checker errors Patchwork
2016-05-13 12:24 ` Imre Deak
2016-05-13 13:07 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463059132-1720-5-git-send-email-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox