public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gvt: drop checks for early Skylake revisions
@ 2016-11-16 10:13 Jani Nikula
  2016-11-16 11:47 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jani Nikula @ 2016-11-16 10:13 UTC (permalink / raw)
  To: igvt-g-dev; +Cc: Jani Nikula, intel-gfx

We no longer cater for pre-production revisions of Skylake.

Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping info")
Cc: Ping Gao <ping.a.gao@intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/gvt/handlers.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 1b3db0c7a6db..12cd9b2a415c 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -1279,14 +1279,12 @@ static int skl_misc_ctl_write(struct intel_vgpu *vgpu, unsigned int offset,
 	case 0x4ddc:
 		vgpu_vreg(vgpu, offset) = 0x8000003c;
 		/* WaCompressedResourceSamplerPbeMediaNewHashMode:skl */
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_C0, REVID_FOREVER))
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
 		break;
 	case 0x42080:
 		vgpu_vreg(vgpu, offset) = 0x8000;
 		/* WaCompressedResourceDisplayNewHashMode:skl */
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_E0, REVID_FOREVER))
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
 		break;
 	default:
 		return -EINVAL;
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/gvt: drop checks for early Skylake revisions
  2016-11-16 10:13 [PATCH] drm/i915/gvt: drop checks for early Skylake revisions Jani Nikula
@ 2016-11-16 11:47 ` Patchwork
  2016-11-16 12:30 ` [PATCH] " Paulo Zanoni
  2016-11-17  1:01 ` Zhenyu Wang
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-11-16 11:47 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/gvt: drop checks for early Skylake revisions
URL   : https://patchwork.freedesktop.org/series/15400/
State : success

== Summary ==

Series 15400v1 drm/i915/gvt: drop checks for early Skylake revisions
https://patchwork.freedesktop.org/api/1.0/series/15400/revisions/1/mbox/


fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

6294f67611ebe69006c0e85c372efadcac8e9d66 drm-intel-nightly: 2016y-11m-16d-09h-57m-25s UTC integration manifest
892646c drm/i915/gvt: drop checks for early Skylake revisions

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3015/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/i915/gvt: drop checks for early Skylake revisions
  2016-11-16 10:13 [PATCH] drm/i915/gvt: drop checks for early Skylake revisions Jani Nikula
  2016-11-16 11:47 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2016-11-16 12:30 ` Paulo Zanoni
  2016-11-17  1:01 ` Zhenyu Wang
  2 siblings, 0 replies; 4+ messages in thread
From: Paulo Zanoni @ 2016-11-16 12:30 UTC (permalink / raw)
  To: Jani Nikula, igvt-g-dev; +Cc: intel-gfx

Em Qua, 2016-11-16 às 12:13 +0200, Jani Nikula escreveu:
> We no longer cater for pre-production revisions of Skylake.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> 
> Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on
> stepping info")
> Cc: Ping Gao <ping.a.gao@intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: <intel-gfx@lists.freedesktop.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/handlers.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c
> b/drivers/gpu/drm/i915/gvt/handlers.c
> index 1b3db0c7a6db..12cd9b2a415c 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -1279,14 +1279,12 @@ static int skl_misc_ctl_write(struct
> intel_vgpu *vgpu, unsigned int offset,
>  	case 0x4ddc:
>  		vgpu_vreg(vgpu, offset) = 0x8000003c;
>  		/*
> WaCompressedResourceSamplerPbeMediaNewHashMode:skl */
> -		if (IS_SKL_REVID(dev_priv, SKL_REVID_C0,
> REVID_FOREVER))
> -			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
> +		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
>  		break;
>  	case 0x42080:
>  		vgpu_vreg(vgpu, offset) = 0x8000;
>  		/* WaCompressedResourceDisplayNewHashMode:skl */
> -		if (IS_SKL_REVID(dev_priv, SKL_REVID_E0,
> REVID_FOREVER))
> -			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
> +		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
>  		break;
>  	default:
>  		return -EINVAL;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/i915/gvt: drop checks for early Skylake revisions
  2016-11-16 10:13 [PATCH] drm/i915/gvt: drop checks for early Skylake revisions Jani Nikula
  2016-11-16 11:47 ` ✓ Fi.CI.BAT: success for " Patchwork
  2016-11-16 12:30 ` [PATCH] " Paulo Zanoni
@ 2016-11-17  1:01 ` Zhenyu Wang
  2 siblings, 0 replies; 4+ messages in thread
From: Zhenyu Wang @ 2016-11-17  1:01 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx, igvt-g-dev


[-- Attachment #1.1: Type: text/plain, Size: 1629 bytes --]

On 2016.11.16 12:13:59 +0200, Jani Nikula wrote:
> We no longer cater for pre-production revisions of Skylake.
> 
> Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping info")
> Cc: Ping Gao <ping.a.gao@intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: <intel-gfx@lists.freedesktop.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---

applied, thanks!

>  drivers/gpu/drm/i915/gvt/handlers.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index 1b3db0c7a6db..12cd9b2a415c 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -1279,14 +1279,12 @@ static int skl_misc_ctl_write(struct intel_vgpu *vgpu, unsigned int offset,
>  	case 0x4ddc:
>  		vgpu_vreg(vgpu, offset) = 0x8000003c;
>  		/* WaCompressedResourceSamplerPbeMediaNewHashMode:skl */
> -		if (IS_SKL_REVID(dev_priv, SKL_REVID_C0, REVID_FOREVER))
> -			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
> +		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
>  		break;
>  	case 0x42080:
>  		vgpu_vreg(vgpu, offset) = 0x8000;
>  		/* WaCompressedResourceDisplayNewHashMode:skl */
> -		if (IS_SKL_REVID(dev_priv, SKL_REVID_E0, REVID_FOREVER))
> -			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
> +		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
>  		break;
>  	default:
>  		return -EINVAL;
> -- 
> 2.1.4
> 

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-17  1:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 10:13 [PATCH] drm/i915/gvt: drop checks for early Skylake revisions Jani Nikula
2016-11-16 11:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-16 12:30 ` [PATCH] " Paulo Zanoni
2016-11-17  1:01 ` Zhenyu Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox