From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h
Date: Thu, 23 Feb 2017 10:38:38 +0200 [thread overview]
Message-ID: <1487839118.3052.39.camel@linux.intel.com> (raw)
In-Reply-To: <20170222124125.4437-3-arkadiusz.hiler@intel.com>
On ke, 2017-02-22 at 13:41 +0100, Arkadiusz Hiler wrote:
> Externs are implicit and we generally try to avoid them.
>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Yeah, for actual "extern" there's EXPORT_SYMBOL (which is not needed
here).
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-23 8:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 12:41 [PATCH v4 0/8] GuC Scrub vol. 1 Arkadiusz Hiler
2017-02-22 12:41 ` [PATCH 1/8] drm/i915/uc: Rename intel_?uc_{setup, load}() to _init_hw() Arkadiusz Hiler
2017-02-22 12:41 ` [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h Arkadiusz Hiler
2017-02-23 8:38 ` Joonas Lahtinen [this message]
2017-02-22 12:41 ` [PATCH 3/8] drm/i915/huc: Add huc_to_i915 Arkadiusz Hiler
2017-02-22 12:41 ` [PATCH 4/8] drm/i915/uc: Rename intel_?uc_init() to intel_?uc_fetch_fw() Arkadiusz Hiler
2017-02-22 13:59 ` Joonas Lahtinen
2017-02-22 15:29 ` Arkadiusz Hiler
2017-02-23 7:45 ` Joonas Lahtinen
2017-02-22 12:41 ` [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static Arkadiusz Hiler
2017-02-22 14:17 ` Joonas Lahtinen
2017-02-22 15:04 ` Arkadiusz Hiler
2017-02-22 12:41 ` [PATCH 6/8] drm/i915/guc: Extract param logic form guc_init Arkadiusz Hiler
2017-02-23 8:37 ` Joonas Lahtinen
2017-02-22 12:41 ` [PATCH 7/8] drm/i915/guc: Simplify intel_guc_init_hw() Arkadiusz Hiler
2017-02-23 8:32 ` Joonas Lahtinen
2017-02-22 12:41 ` [PATCH 8/8] drm/i915/uc: Simplify firmware path handling Arkadiusz Hiler
2017-02-22 12:53 ` Chris Wilson
2017-02-22 15:30 ` Arkadiusz Hiler
2017-02-22 15:52 ` Arkadiusz Hiler
2017-02-23 7:58 ` Joonas Lahtinen
2017-02-23 8:09 ` Joonas Lahtinen
2017-02-22 16:22 ` ✓ Fi.CI.BAT: success for GuC Scrub vol. 1 (rev4) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-02-17 13:05 [PATCH v3 0/8] GuC Scrub vol. 1 Arkadiusz Hiler
2017-02-17 13:05 ` [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h Arkadiusz Hiler
2017-02-17 13:13 ` Michal Wajdeczko
2017-02-21 9:15 ` Arkadiusz Hiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487839118.3052.39.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox