public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h
Date: Tue, 21 Feb 2017 10:15:20 +0100	[thread overview]
Message-ID: <20170221091519.GA29883@ahiler-desk.igk.intel.com> (raw)
In-Reply-To: <20170217131306.GB10072@mwajdecz-MOBL1.ger.corp.intel.com>

On Fri, Feb 17, 2017 at 02:13:06PM +0100, Michal Wajdeczko wrote:
> On Fri, Feb 17, 2017 at 02:05:51PM +0100, Arkadiusz Hiler wrote:
> 
> I think one line with description will not kill us ;)

Comment title is exactly that. If you have something that won't be just
simple restatement of the title / saying what this trivial diff says
then please share.

> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Thanks.

> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_uc.h | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h
> > index dd34a1b..41b7351 100644
> > --- a/drivers/gpu/drm/i915/intel_uc.h
> > +++ b/drivers/gpu/drm/i915/intel_uc.h
> > @@ -189,12 +189,12 @@ int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len);
> >  int intel_guc_sample_forcewake(struct intel_guc *guc);
> >  
> >  /* intel_guc_loader.c */
> > -extern void intel_guc_init(struct drm_i915_private *dev_priv);
> > -extern int intel_guc_init_hw(struct drm_i915_private *dev_priv);
> > -extern void intel_guc_fini(struct drm_i915_private *dev_priv);
> > -extern const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status);
> > -extern int intel_guc_suspend(struct drm_i915_private *dev_priv);
> > -extern int intel_guc_resume(struct drm_i915_private *dev_priv);
> > +void intel_guc_init(struct drm_i915_private *dev_priv);
> > +int intel_guc_init_hw(struct drm_i915_private *dev_priv);
> > +void intel_guc_fini(struct drm_i915_private *dev_priv);
> > +const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status);
> > +int intel_guc_suspend(struct drm_i915_private *dev_priv);
> > +int intel_guc_resume(struct drm_i915_private *dev_priv);
> >  void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
> >  	struct intel_uc_fw *uc_fw);
> >  u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv);
> > -- 
> > 2.9.3
> > 

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-02-21  9:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 13:05 [PATCH v3 0/8] GuC Scrub vol. 1 Arkadiusz Hiler
2017-02-17 13:05 ` [PATCH 1/8] drm/i915/uc: Rename intel_?uc_{setup, load}() to _init_hw() Arkadiusz Hiler
2017-02-17 13:10   ` Michal Wajdeczko
2017-02-17 13:05 ` [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h Arkadiusz Hiler
2017-02-17 13:13   ` Michal Wajdeczko
2017-02-21  9:15     ` Arkadiusz Hiler [this message]
2017-02-17 13:05 ` [PATCH 3/8] drm/i915/huc: Add huc_to_i915 Arkadiusz Hiler
2017-02-17 13:14   ` Michal Wajdeczko
2017-02-17 13:05 ` [PATCH 4/8] drm/i915/uc: Rename intel_?uc_init() to intel_?uc_fetch_fw() Arkadiusz Hiler
2017-02-17 13:31   ` Michal Wajdeczko
2017-02-21 11:37     ` Arkadiusz Hiler
2017-02-17 13:05 ` [PATCH 5/8] drm/i915/uc: Make intel_uc_fw_fetch() static Arkadiusz Hiler
2017-02-17 13:39   ` Michal Wajdeczko
2017-02-21 11:44     ` Arkadiusz Hiler
2017-02-17 13:05 ` [PATCH 6/8] drm/i915/guc: Extract param logic form guc_init Arkadiusz Hiler
2017-02-17 13:52   ` Michal Wajdeczko
2017-02-21 13:38     ` Arkadiusz Hiler
2017-02-17 13:05 ` [PATCH 7/8] drm/i915/guc: Simplify intel_guc_init_hw() Arkadiusz Hiler
2017-02-17 14:03   ` Michal Wajdeczko
2017-02-21 13:56     ` Arkadiusz Hiler
2017-02-21 14:08       ` Arkadiusz Hiler
2017-02-17 13:05 ` [PATCH 8/8] drm/i915/uc: Simplify firwmare path handling Arkadiusz Hiler
2017-02-17 14:29   ` Michal Wajdeczko
2017-02-21 14:44     ` Arkadiusz Hiler
2017-02-17 14:52 ` ✓ Fi.CI.BAT: success for GuC Scrub vol. 1 (rev3) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2017-02-22 12:41 [PATCH v4 0/8] GuC Scrub vol. 1 Arkadiusz Hiler
2017-02-22 12:41 ` [PATCH 2/8] drm/i915/uc: Drop superfluous externs in intel_uc.h Arkadiusz Hiler
2017-02-23  8:38   ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170221091519.GA29883@ahiler-desk.igk.intel.com \
    --to=arkadiusz.hiler@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox