Re: [PATCH v2] drm/i915/gvt: disable GVT-g if host GuC submission is enabled

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On ti, 2017-05-09 at 18:11 +0800, Chuanxiao Dong wrote:
> Currently GVT-g cannot work properly when host GuC submission
> is enabled, so disable GVT in this case.
> 
> v2: update the user message (Joonas)
> 
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_gvt.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_gvt.c b/drivers/gpu/drm/i915/intel_gvt.c
> index e1ab643..d85742c 100644
> --- a/drivers/gpu/drm/i915/intel_gvt.c
> +++ b/drivers/gpu/drm/i915/intel_gvt.c
> @@ -84,6 +84,11 @@ int intel_gvt_init(struct drm_i915_private *dev_priv)
>  		goto bail;
>  	}
>  
> +	if (i915.enable_guc_submission) {
> +		DRM_INFO("GPU guest virtualisation [GVT-g] disabled as Graphics virtualization is not yet supported with GuC submission [i915.enable_guc_submission module parameter]\n");
> +		goto bail;
> +	}

As discussed earlier, driver loading should fail with -EIO when
incompatible options are specified.

Also, the message is now even more cryptic, just:

	DRM_INFO("Graphics virtualization is not yet supported with GuC submission");

Should do.

Please Cc: the people who've previously commented on the patch to make
it easier to spot new versions.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx