From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Dong, Chuanxiao" <chuanxiao.dong@intel.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915/gvt: disable GVT-g if host GuC submission is enabled
Date: Thu, 18 May 2017 13:36:54 +0300 [thread overview]
Message-ID: <1495103814.9811.5.camel@linux.intel.com> (raw)
In-Reply-To: <17296D9F8FF2234F831FC3DF505A87A9632621BE@SHSMSX103.ccr.corp.intel.com>
On ti, 2017-05-16 at 07:53 +0000, Dong, Chuanxiao wrote:
> >
> > Thanks Joonas. If to fail with -EIO, how about for the other two checks: " if
> > (!is_supported_device(dev_priv))" and " if (!i915.enable_execlists)"?
> > Currently these two cases are failed with 0 instead of -EIO. Looks like should
> > also fail with -EIO?
!is_supported_device check should probably be done in parameter
sanitization phase, it should not result in EIO, because enable_gvt is
not marked as an unsafe option.
enable_execlists on the other hand is a an _unsafe option and should
result in -EIO.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-18 10:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 8:58 [PATCH] drm/i915/gvt: disable GVT-g if host GuC submission is enabled Chuanxiao Dong
2017-05-02 10:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-03 8:36 ` [PATCH] " Zhenyu Wang
2017-05-05 8:55 ` Joonas Lahtinen
2017-05-05 9:09 ` Dong, Chuanxiao
2017-05-05 9:10 ` Chris Wilson
2017-05-08 10:30 ` Dong, Chuanxiao
2017-05-08 11:23 ` Joonas Lahtinen
2017-05-05 9:47 ` Zhenyu Wang
2017-05-09 10:11 ` [PATCH v2] " Chuanxiao Dong
2017-05-10 12:48 ` Joonas Lahtinen
2017-05-11 2:33 ` Dong, Chuanxiao
2017-05-11 12:50 ` Joonas Lahtinen
2017-05-11 13:38 ` Dong, Chuanxiao
2017-05-16 7:53 ` Dong, Chuanxiao
2017-05-18 10:36 ` Joonas Lahtinen [this message]
2017-05-22 2:12 ` Dong, Chuanxiao
2017-05-09 10:39 ` ✓ Fi.CI.BAT: success for drm/i915/gvt: disable GVT-g if host GuC submission is enabled (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495103814.9811.5.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chuanxiao.dong@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox