* [PATCH] drm/i915/guc: Fix doorbell id selection
@ 2017-05-31 0:05 Michel Thierry
2017-05-31 0:19 ` Daniele Ceraolo Spurio
2017-05-31 0:21 ` ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 5+ messages in thread
From: Michel Thierry @ 2017-05-31 0:05 UTC (permalink / raw)
To: intel-gfx
We are passing parameters in the wrong order to find next zero bit, and
when it doesn't find anything it returns size (offset in the code), which
is always zero.
For reference the function is defined as:
find_next_bit( *addr, size, offset )
The incorrect parameter order was added by commit abddffdf3620e
("drm/i915/guc: Sanitize GuC client initialization"). Luckily, currently
we only use a single guc client and a single doorbell, which happens to be
zero; therefore it isn't necessary to backport this fix (which would be for
v4.12).
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Oscar Mateo <oscar.mateo@intel.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
---
drivers/gpu/drm/i915/i915_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index fb936bb5cb93..ec391ef981aa 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -105,7 +105,7 @@ static int __reserve_doorbell(struct i915_guc_client *client)
end += offset;
}
- id = find_next_zero_bit(client->guc->doorbell_bitmap, offset, end);
+ id = find_next_zero_bit(client->guc->doorbell_bitmap, end, offset);
if (id == end)
return -ENOSPC;
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/guc: Fix doorbell id selection
2017-05-31 0:05 [PATCH] drm/i915/guc: Fix doorbell id selection Michel Thierry
@ 2017-05-31 0:19 ` Daniele Ceraolo Spurio
2017-05-31 7:37 ` Joonas Lahtinen
2017-05-31 0:21 ` ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 1 reply; 5+ messages in thread
From: Daniele Ceraolo Spurio @ 2017-05-31 0:19 UTC (permalink / raw)
To: Michel Thierry, intel-gfx
On 30/05/17 17:05, Michel Thierry wrote:
> We are passing parameters in the wrong order to find next zero bit, and
> when it doesn't find anything it returns size (offset in the code), which
> is always zero.
>
> For reference the function is defined as:
> find_next_bit( *addr, size, offset )
>
> The incorrect parameter order was added by commit abddffdf3620e
> ("drm/i915/guc: Sanitize GuC client initialization"). Luckily, currently
> we only use a single guc client and a single doorbell, which happens to be
> zero; therefore it isn't necessary to backport this fix (which would be for
> v4.12).
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Oscar Mateo <oscar.mateo@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> ---
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Thanks,
Daniele
> drivers/gpu/drm/i915/i915_guc_submission.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
> index fb936bb5cb93..ec391ef981aa 100644
> --- a/drivers/gpu/drm/i915/i915_guc_submission.c
> +++ b/drivers/gpu/drm/i915/i915_guc_submission.c
> @@ -105,7 +105,7 @@ static int __reserve_doorbell(struct i915_guc_client *client)
> end += offset;
> }
>
> - id = find_next_zero_bit(client->guc->doorbell_bitmap, offset, end);
> + id = find_next_zero_bit(client->guc->doorbell_bitmap, end, offset);
> if (id == end)
> return -ENOSPC;
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/guc: Fix doorbell id selection
2017-05-31 0:19 ` Daniele Ceraolo Spurio
@ 2017-05-31 7:37 ` Joonas Lahtinen
0 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-05-31 7:37 UTC (permalink / raw)
To: Daniele Ceraolo Spurio, Michel Thierry, intel-gfx
On ti, 2017-05-30 at 17:19 -0700, Daniele Ceraolo Spurio wrote:
>
> On 30/05/17 17:05, Michel Thierry wrote:
> >
> > We are passing parameters in the wrong order to find next zero bit, and
> > when it doesn't find anything it returns size (offset in the code), which
> > is always zero.
> >
> > For reference the function is defined as:
> > find_next_bit( *addr, size, offset )
> >
> > The incorrect parameter order was added by commit abddffdf3620e
> > ("drm/i915/guc: Sanitize GuC client initialization"). Luckily, currently
> > we only use a single guc client and a single doorbell, which happens to be
> > zero; therefore it isn't necessary to backport this fix (which would be for
> > v4.12).
Whoops, a good catch.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/guc: Fix doorbell id selection
2017-05-31 0:05 [PATCH] drm/i915/guc: Fix doorbell id selection Michel Thierry
2017-05-31 0:19 ` Daniele Ceraolo Spurio
@ 2017-05-31 0:21 ` Patchwork
2017-05-31 7:37 ` Joonas Lahtinen
1 sibling, 1 reply; 5+ messages in thread
From: Patchwork @ 2017-05-31 0:21 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Fix doorbell id selection
URL : https://patchwork.freedesktop.org/series/25076/
State : success
== Summary ==
Series 25076v1 drm/i915/guc: Fix doorbell id selection
https://patchwork.freedesktop.org/api/1.0/series/25076/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:446s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:431s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:584s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:511s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:487s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:484s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:429s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:415s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:414s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:496s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:464s
fi-kbl-7500u total:278 pass:255 dwarn:5 dfail:0 fail:0 skip:18 time:464s
fi-kbl-7560u total:278 pass:263 dwarn:5 dfail:0 fail:0 skip:10 time:578s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:466s
fi-skl-6700hq total:278 pass:229 dwarn:1 dfail:0 fail:26 skip:22 time:403s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:471s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:500s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:439s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:534s
fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time:403s
0af3152d8e2034d1491ef8738e7dfc6e08852606 drm-tip: 2017y-05m-30d-17h-20m-32s UTC integration manifest
ef9cf39 drm/i915/guc: Fix doorbell id selection
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4835/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-31 7:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 0:05 [PATCH] drm/i915/guc: Fix doorbell id selection Michel Thierry
2017-05-31 0:19 ` Daniele Ceraolo Spurio
2017-05-31 7:37 ` Joonas Lahtinen
2017-05-31 0:21 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-31 7:37 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox