* [PATCH] drm/i915: Silently fallback to 4k scratch
@ 2017-10-10 11:10 Chris Wilson
2017-10-10 11:21 ` Matthew Auld
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2017-10-10 11:10 UTC (permalink / raw)
To: intel-gfx
If we fail to allocate a 64k hugepage for scratch, we try again with a
normal 4k page (with some loss of efficiency at runtime). As we handle
this gracefully, we do not need a noisy allocation failure warning.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 4c605785e2b3..ca7fd34fbe8b 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -538,7 +538,7 @@ setup_scratch_page(struct i915_address_space *vm, gfp_t gfp)
if (i915_vm_is_48bit(vm) &&
HAS_PAGE_SIZES(vm->i915, I915_GTT_PAGE_SIZE_64K)) {
order = get_order(I915_GTT_PAGE_SIZE_64K);
- page = alloc_pages(gfp | __GFP_ZERO, order);
+ page = alloc_pages(gfp | __GFP_ZERO | __GFP_NOWARN, order);
if (page) {
addr = dma_map_page(vm->dma, page, 0,
I915_GTT_PAGE_SIZE_64K,
--
2.15.0.rc0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Silently fallback to 4k scratch
2017-10-10 11:10 [PATCH] drm/i915: Silently fallback to 4k scratch Chris Wilson
@ 2017-10-10 11:21 ` Matthew Auld
2017-10-10 11:30 ` Joonas Lahtinen
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2017-10-10 11:21 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development
On 10 October 2017 at 12:10, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> If we fail to allocate a 64k hugepage for scratch, we try again with a
> normal 4k page (with some loss of efficiency at runtime). As we handle
> this gracefully, we do not need a noisy allocation failure warning.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Silently fallback to 4k scratch
2017-10-10 11:10 [PATCH] drm/i915: Silently fallback to 4k scratch Chris Wilson
2017-10-10 11:21 ` Matthew Auld
@ 2017-10-10 11:30 ` Joonas Lahtinen
2017-10-10 11:48 ` Chris Wilson
2017-10-10 11:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 14:17 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Joonas Lahtinen @ 2017-10-10 11:30 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Tue, 2017-10-10 at 12:10 +0100, Chris Wilson wrote:
> If we fail to allocate a 64k hugepage for scratch, we try again with a
> normal 4k page (with some loss of efficiency at runtime). As we handle
> this gracefully, we do not need a noisy allocation failure warning.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Do we want to maybe add a DRM_INFO to else branch?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Silently fallback to 4k scratch
2017-10-10 11:10 [PATCH] drm/i915: Silently fallback to 4k scratch Chris Wilson
2017-10-10 11:21 ` Matthew Auld
2017-10-10 11:30 ` Joonas Lahtinen
@ 2017-10-10 11:47 ` Patchwork
2017-10-10 14:17 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-10-10 11:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Silently fallback to 4k scratch
URL : https://patchwork.freedesktop.org/series/31646/
State : success
== Summary ==
Series 31646v1 drm/i915: Silently fallback to 4k scratch
https://patchwork.freedesktop.org/api/1.0/series/31646/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:452s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:471s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:391s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:559s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:283s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:520s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:529s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:530s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:512s
fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:552s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:620s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:601s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:435s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:416s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:452s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:498s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:472s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:500s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:579s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:496s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:589s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:657s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:467s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:654s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:530s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:512s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:466s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:576s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:427s
6bcaf2275e52e258c737bc355e73072640be5ac3 drm-tip: 2017y-10m-10d-10h-57m-51s UTC integration manifest
af83b9339850 drm/i915: Silently fallback to 4k scratch
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5969/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Silently fallback to 4k scratch
2017-10-10 11:30 ` Joonas Lahtinen
@ 2017-10-10 11:48 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2017-10-10 11:48 UTC (permalink / raw)
To: Joonas Lahtinen, intel-gfx
Quoting Joonas Lahtinen (2017-10-10 12:30:17)
> On Tue, 2017-10-10 at 12:10 +0100, Chris Wilson wrote:
> > If we fail to allocate a 64k hugepage for scratch, we try again with a
> > normal 4k page (with some loss of efficiency at runtime). As we handle
> > this gracefully, we do not need a noisy allocation failure warning.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Auld <matthew.william.auld@gmail.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Do we want to maybe add a DRM_INFO to else branch?
What do you want the user to do? Shutdown firefox and start again?
Maybe debug, but then what do you expect us to do?
The ultimate aide would be a diagnostic for slow runtime, for that we
could do with a tracepoint to tell us how each binding went (page_sizes
vs sg_sizes).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Silently fallback to 4k scratch
2017-10-10 11:10 [PATCH] drm/i915: Silently fallback to 4k scratch Chris Wilson
` (2 preceding siblings ...)
2017-10-10 11:47 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-10 14:17 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-10-10 14:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Silently fallback to 4k scratch
URL : https://patchwork.freedesktop.org/series/31646/
State : success
== Summary ==
shard-hsw total:2552 pass:1431 dwarn:5 dfail:0 fail:13 skip:1103 time:9667s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5969/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-10 14:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 11:10 [PATCH] drm/i915: Silently fallback to 4k scratch Chris Wilson
2017-10-10 11:21 ` Matthew Auld
2017-10-10 11:30 ` Joonas Lahtinen
2017-10-10 11:48 ` Chris Wilson
2017-10-10 11:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-10 14:17 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox