From: Ramalingam C <ramalingam.c@intel.com>
To: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com,
paulo.r.zanoni@intel.com, chris@chris-wilson.co.uk
Subject: [PATCH 1/2] drm/i915: Runtime disable for eDP DRRS
Date: Tue, 31 Oct 2017 14:50:42 +0530 [thread overview]
Message-ID: <1509441644-4765-2-git-send-email-ramalingam.c@intel.com> (raw)
In-Reply-To: <1509441644-4765-1-git-send-email-ramalingam.c@intel.com>
From: "C, Ramalingam" <ramalingam.c@intel.com>
Module parameter enable_drrs(Boolean flag) is added to control the
eDP Idleness drrs enable flow.
Modification to this module parameter will be considered on next
eDP_DRRS enable flow. So after module parameter update, a modeset
will help to modify the feature state as per the module parameter's
current state.
Possibility of disabling the DRRS, enables the testing of the
frontbuffer tracking based features (FBC, DRRS and PSR) as standalone
or any combination of the set.
Signed-off-by: C, Ramalingam <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/i915_params.c | 3 +++
drivers/gpu/drm/i915/i915_params.h | 3 ++-
drivers/gpu/drm/i915/intel_dp.c | 6 ++++++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index b4faeb6aa2bd..32f06bb74f9d 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -190,3 +190,6 @@ i915_param_named(enable_dpcd_backlight, bool, 0600,
i915_param_named(enable_gvt, bool, 0400,
"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
+
+i915_param_named_unsafe(enable_drrs, bool, 0600,
+ "Enable DRRS. (True=Enabled, False=Disabled [Default])");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index c7292268ed43..3c6fdce1c122 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -67,7 +67,8 @@
param(bool, nuclear_pageflip, false) \
param(bool, enable_dp_mst, true) \
param(bool, enable_dpcd_backlight, false) \
- param(bool, enable_gvt, false)
+ param(bool, enable_gvt, false) \
+ param(bool, enable_drrs, false)
#define MEMBER(T, member, ...) T member;
struct i915_params {
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index ca48bce23a6f..ff9964cf15cd 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -5568,6 +5568,11 @@ void intel_edp_drrs_enable(struct intel_dp *intel_dp,
return;
}
+ if (!i915_modparams.enable_drrs) {
+ DRM_DEBUG_KMS("DRRS is disabled from modparams\n");
+ return;
+ }
+
mutex_lock(&dev_priv->drrs.mutex);
if (WARN_ON(dev_priv->drrs.dp)) {
DRM_ERROR("DRRS already enabled\n");
@@ -5817,6 +5822,7 @@ intel_dp_drrs_init(struct intel_connector *intel_connector,
}
dev_priv->drrs.type = dev_priv->vbt.drrs_type;
+ i915_modparams.enable_drrs = true;
dev_priv->drrs.refresh_rate_type = DRRS_HIGH_RR;
DRM_DEBUG_KMS("seamless DRRS supported for eDP panel.\n");
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-31 9:23 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1505724732-17529-1-git-send-email-lohith.bs@intel.com>
2017-09-18 19:54 ` [PATCH] Idleness DRRS: Rodrigo Vivi
2017-09-19 10:46 ` Ramalingam C
2017-09-19 18:12 ` Rodrigo Vivi
2017-10-31 9:20 ` [PATCH 0/2] DRRS coverage in frontbuffer tracking IGT Ramalingam C
2017-10-31 9:20 ` Ramalingam C [this message]
2017-10-31 18:57 ` [PATCH 1/2] drm/i915: Runtime disable for eDP DRRS Rodrigo Vivi
2017-11-01 16:44 ` C, Ramalingam
2017-11-07 18:38 ` [PATCH v2 " Ramalingam C
2017-11-17 18:53 ` Rodrigo Vivi
2017-11-19 14:55 ` C, Ramalingam
2017-11-21 20:59 ` Rodrigo Vivi
2017-10-31 9:20 ` [PATCH 2/2] i915/drrs/debugfs: module param and psr status Ramalingam C
2017-11-07 18:40 ` [PATCH v2 2/2] i915/drrs/debugfs: crtc id " Ramalingam C
2017-11-17 18:56 ` Rodrigo Vivi
2017-11-20 3:39 ` C, Ramalingam
2017-11-20 4:23 ` [PATCH v3] i915/drrs/debugfs: psr status info addition Ramalingam C
2017-11-21 20:56 ` Rodrigo Vivi
2017-10-31 9:20 ` [PATCH i-g-t] tests/kms_frontbuffer_tracking: Idleness DRRS coverage Ramalingam C
2017-11-10 16:22 ` [PATCH i-g-t] Idleness DRRS: Lohith BS
2017-12-06 15:13 ` [PATCH i-g-t v8] tests/kms_frontbuffer_tracking: Including DRRS test coverage Lohith BS
2017-12-06 18:30 ` Paulo Zanoni
2017-12-11 13:12 ` [PATCH i-g-t v9] " Lohith BS
2018-01-01 13:45 ` [PATCH i-g-t v10] " Lohith BS
2018-01-02 20:34 ` Rodrigo Vivi
2018-01-03 16:02 ` Bs, Lohith
2018-01-03 15:02 ` [PATCH i-g-t v11] " Lohith BS
2018-01-03 19:21 ` Rodrigo Vivi
2018-01-03 22:14 ` Ramalingam C
2018-01-05 11:40 ` [PATCH i-g-t v12] " Lohith BS
2018-01-05 17:55 ` Rodrigo Vivi
2018-01-06 10:48 ` Ramalingam C
2018-01-06 13:37 ` Ramalingam C
2018-01-10 14:47 ` [PATCH i-g-t v13] " Lohith BS
2018-01-10 18:15 ` Rodrigo Vivi
2018-01-11 5:27 ` Ramalingam C
2018-01-11 20:22 ` Rodrigo Vivi
2018-01-11 8:40 ` Daniel Vetter
2018-01-17 5:05 ` Ramalingam C
2017-10-31 9:28 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Runtime disable for eDP DRRS Patchwork
2017-10-31 9:48 ` ✓ Fi.CI.BAT: success " Patchwork
2017-10-31 10:33 ` ✗ Fi.CI.BAT: warning for tests/kms_frontbuffer_tracking: Idleness DRRS coverage Patchwork
2017-11-08 7:26 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Runtime disable for eDP DRRS (rev3) Patchwork
2017-11-08 8:11 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-10 16:49 ` ✗ Fi.CI.BAT: warning for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev2) Patchwork
2017-11-20 4:46 ` ✗ Fi.CI.BAT: warning for series starting with [v2,1/2] drm/i915: Runtime disable for eDP DRRS (rev4) Patchwork
2017-12-06 16:32 ` ✗ Fi.CI.BAT: warning for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev3) Patchwork
2017-12-11 15:56 ` ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev4) Patchwork
2017-12-11 17:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-12-28 15:59 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Runtime disable for eDP DRRS (rev4) Patchwork
2017-12-28 16:45 ` ✓ Fi.CI.IGT: " Patchwork
2018-01-02 10:37 ` ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev5) Patchwork
2018-01-02 13:26 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-03 15:30 ` ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev6) Patchwork
2018-01-03 18:49 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-05 12:04 ` ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev7) Patchwork
2018-01-05 13:25 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-10 15:11 ` ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev8) Patchwork
2018-01-10 16:14 ` ✓ Fi.CI.IGT: " Patchwork
2017-09-19 10:14 ` [PATCH] Idleness DRRS: Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509441644-4765-2-git-send-email-ramalingam.c@intel.com \
--to=ramalingam.c@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox