Re: [PATCH v11 04/11] drm/i915/vrr: Add helper for PSR to enable Frame Change event on trans push

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Wed, 2026-01-28 at 08:12 +0530, Nautiyal, Ankit K wrote:
> 
> On 1/27/2026 6:11 PM, Jouni Högander wrote:
> > Add new helper to enable PSR Frame Change event generation using
> > trans push
> > mechanism. This helper is to be used by PSR code on PSR enable.
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> 
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Thank you Ankit for your review. This set is now pushed to drm-intel-
next.

BR,
Jouni Högander

> 
> 
> > ---
> >   drivers/gpu/drm/i915/display/intel_vrr.c | 9 +++++++++
> >   drivers/gpu/drm/i915/display/intel_vrr.h | 1 +
> >   2 files changed, 10 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> > b/drivers/gpu/drm/i915/display/intel_vrr.c
> > index f26989c74268..66c68e7f3a49 100644
> > --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> > @@ -973,6 +973,15 @@ void intel_vrr_transcoder_disable(const struct
> > intel_crtc_state *old_crtc_state)
> >   		intel_vrr_tg_disable(old_crtc_state);
> >   }
> >   
> > +void intel_vrr_psr_frame_change_enable(const struct
> > intel_crtc_state *crtc_state)
> > +{
> > +	struct intel_display *display =
> > to_intel_display(crtc_state);
> > +	enum transcoder cpu_transcoder = crtc_state-
> > >cpu_transcoder;
> > +
> > +	intel_de_write(display, TRANS_PUSH(display,
> > cpu_transcoder),
> > +		       trans_vrr_push(crtc_state, false));
> > +}
> > +
> >   bool intel_vrr_is_fixed_rr(const struct intel_crtc_state
> > *crtc_state)
> >   {
> >   	return crtc_state->vrr.flipline &&
> > diff --git a/drivers/gpu/drm/i915/display/intel_vrr.h
> > b/drivers/gpu/drm/i915/display/intel_vrr.h
> > index bedcc8c4bff2..4f16ca4af91f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_vrr.h
> > +++ b/drivers/gpu/drm/i915/display/intel_vrr.h
> > @@ -33,6 +33,7 @@ void intel_vrr_dcb_increment_flip_count(struct
> > intel_crtc_state *crtc_state,
> >   					struct intel_crtc *crtc);
> >   bool intel_vrr_is_push_sent(const struct intel_crtc_state
> > *crtc_state);
> >   void intel_vrr_disable(const struct intel_crtc_state
> > *old_crtc_state);
> > +void intel_vrr_psr_frame_change_enable(const struct
> > intel_crtc_state *crtc_state);
> >   void intel_vrr_get_config(struct intel_crtc_state *crtc_state);
> >   int intel_vrr_vmax_vtotal(const struct intel_crtc_state
> > *crtc_state);
> >   int intel_vrr_vmin_vtotal(const struct intel_crtc_state
> > *crtc_state);