public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>,
	"Ankit Nautiyal" <ankit.k.nautiyal@intel.com>
Subject: [PATCH v11 09/11] drm/i915/psr: Do PSR exit on frontbuffer flush on LunarLake and onwards
Date: Tue, 27 Jan 2026 14:41:18 +0200	[thread overview]
Message-ID: <20260127124120.1069026-10-jouni.hogander@intel.com> (raw)
In-Reply-To: <20260127124120.1069026-1-jouni.hogander@intel.com>

We need to use intel_psr_exit in frontbuffer flush on LunarLake and
onwards if we want to move using trans push mechanism to trigger Frame
Change event.

Keep PSR1 and PSR2 HW tracking as it is for older platforms as this was
seen causing problems there.

v2: typo fixed

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 9613c50623dc..9a4354c6bdda 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -3559,7 +3559,14 @@ static void _psr_flush_handle(struct intel_dp *intel_dp)
 {
 	struct intel_display *display = to_intel_display(intel_dp);
 
-	if (DISPLAY_VER(display) < 20 && intel_dp->psr.psr2_sel_fetch_enabled) {
+	if (DISPLAY_VER(display) >= 20) {
+		/*
+		 * We can use PSR exit on LunarLake onwards. Also
+		 * using trans push mechanism to trigger Frame Change
+		 * event requires using PSR exit.
+		 */
+		intel_psr_exit(intel_dp);
+	} else if (intel_dp->psr.psr2_sel_fetch_enabled) {
 		/* Selective fetch prior LNL */
 		if (intel_dp->psr.psr2_sel_fetch_cff_enabled) {
 			/* can we turn CFF off? */
@@ -3579,16 +3586,11 @@ static void _psr_flush_handle(struct intel_dp *intel_dp)
 		intel_psr_configure_full_frame_update(intel_dp);
 
 		intel_psr_force_update(intel_dp);
-	} else if (!intel_dp->psr.psr2_sel_fetch_enabled) {
+	} else {
 		/*
-		 * PSR1 on all platforms
-		 * PSR2 HW tracking
-		 * Panel Replay Full frame update
+		 * On older platforms using PSR exit was seen causing problems
 		 */
 		intel_psr_force_update(intel_dp);
-	} else {
-		/* Selective update LNL onwards */
-		intel_psr_exit(intel_dp);
 	}
 
 	if (!intel_dp->psr.active && !intel_dp->psr.busy_frontbuffer_bits)
-- 
2.43.0


  parent reply	other threads:[~2026-01-27 12:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 12:41 [PATCH v11 00/11] Use trans push mechanism to generate frame change event Jouni Högander
2026-01-27 12:41 ` [PATCH v11 01/11] drm/i915/psr: Add TRANS_PUSH register bit definition for PSR Jouni Högander
2026-01-27 12:41 ` [PATCH v11 02/11] drm/i915/psr: Add intel_psr_use_trans_push to query if TRANS_PUSH is used Jouni Högander
2026-01-27 12:41 ` [PATCH v11 03/11] drm/i915/vrr: Add helper for parsing value to be written into TRANS_PUSH Jouni Högander
2026-01-27 12:41 ` [PATCH v11 04/11] drm/i915/vrr: Add helper for PSR to enable Frame Change event on trans push Jouni Högander
2026-01-28  2:42   ` Nautiyal, Ankit K
2026-02-02  6:49     ` Hogander, Jouni
2026-01-27 12:41 ` [PATCH v11 05/11] drm/i915/vrr: Prepare to Use TRANS_PUSH mechanism for PSR frame change Jouni Högander
2026-01-28  2:37   ` Nautiyal, Ankit K
2026-01-27 12:41 ` [PATCH v11 06/11] drm/i915/dsb: Set DSB_SKIP_WAITS_EN chicken bit for LunarLake and onwards Jouni Högander
2026-01-27 12:41 ` [PATCH v11 07/11] drm/i915/display: Wait for vblank in case of PSR is using trans push Jouni Högander
2026-01-27 12:41 ` [PATCH v11 08/11] drm/i915/psr: Wait for idle only after possible send push Jouni Högander
2026-01-27 12:41 ` Jouni Högander [this message]
2026-01-27 12:41 ` [PATCH v11 10/11] drm/i915/display: Add HAS_PSR_TRANS_PUSH_FRAME_CHANGE macro Jouni Högander
2026-01-27 12:41 ` [PATCH v11 11/11] drm/i915/psr: Use TRANS_PUSH to trigger frame change event Jouni Högander
2026-01-27 13:48 ` ✓ i915.CI.BAT: success for Use trans push mechanism to generate " Patchwork
2026-01-27 20:59 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260127124120.1069026-10-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox