Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Core-for-CI:ICL_only Disable ACPI idle driver
@ 2019-04-08 12:22 Anshuman Gupta
  2019-04-08 13:08 ` Saarinen, Jani
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Anshuman Gupta @ 2019-04-08 12:22 UTC (permalink / raw)
  To: intel-gfx; +Cc: martin.peres, daniel.vetter

There were system hung observed while running i915_pm_rpm test.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
Root cause is believed to due to page fault in ACPI idle (FDO comment 18)
driver, it has been suggested by Daniel to disable ACPI idle
driver for CI system, this patch only meant for ICL.

Cc: martin.peres@intel.com
Cc: daniel.vetter@intel.com

Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 drivers/acpi/processor_driver.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index 9d6aff2..6e3ef2d 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -35,6 +35,9 @@
 
 #include <acpi/processor.h>
 
+#include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
+
 #include "internal.h"
 
 #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
@@ -58,6 +61,13 @@ static const struct acpi_device_id processor_device_ids[] = {
 };
 MODULE_DEVICE_TABLE(acpi, processor_device_ids);
 
+#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
+static const struct x86_cpu_id intel_cpu_ids[] = {
+	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
+
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -226,6 +236,7 @@ static inline void acpi_pss_perf_exit(struct acpi_processor *pr,
 static int __acpi_processor_start(struct acpi_device *device)
 {
 	struct acpi_processor *pr = acpi_driver_data(device);
+	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
 
@@ -239,7 +250,9 @@ static int __acpi_processor_start(struct acpi_device *device)
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
+	id = x86_match_cpu(intel_cpu_ids);
+	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
+		&acpi_idle_driver))
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-04-10  8:50 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-08 12:22 [PATCH] Core-for-CI:ICL_only Disable ACPI idle driver Anshuman Gupta
2019-04-08 13:08 ` Saarinen, Jani
2019-04-08 15:13 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-08 17:48 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-09  1:33 ` [PATCH] " kbuild test robot
2019-04-09  4:26 ` kbuild test robot
2019-04-09  6:29 ` [PATCH v2] " Anshuman Gupta
2019-04-09 15:49   ` Rafael J. Wysocki
2019-04-10  8:50     ` Peres, Martin
2019-04-09  7:57 ` ✗ Fi.CI.BAT: failure for Core-for-CI:ICL_only Disable ACPI idle driver (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox