public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Uma Shankar <uma.shankar@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: dcastagna@chromium.org, jonas@kwiboo.se, seanpaul@chromium.org
Subject: [v10 11/12] video/hdmi: Add Unpack function for DRM infoframe
Date: Tue, 14 May 2019 23:06:33 +0530	[thread overview]
Message-ID: <1557855394-12214-12-git-send-email-uma.shankar@intel.com> (raw)
In-Reply-To: <1557855394-12214-1-git-send-email-uma.shankar@intel.com>

Added unpack function for DRM infoframe for dynamic
range and mastering infoframe readout.

v2: Addressed Ville's review comments.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 drivers/video/hdmi.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/hdmi.h |  1 +
 2 files changed, 71 insertions(+)

diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index c5ecd16..b99ba01 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -675,6 +675,9 @@ static int hdmi_drm_infoframe_check_only(const struct hdmi_drm_infoframe *frame)
 	    frame->version != 1)
 		return -EINVAL;
 
+	if (frame->length != HDMI_DRM_INFOFRAME_SIZE)
+		return -EINVAL;
+
 	return 0;
 }
 
@@ -1802,6 +1805,70 @@ static int hdmi_audio_infoframe_unpack(struct hdmi_audio_infoframe *frame,
 }
 
 /**
+ * hdmi_drm_infoframe_unpack() - unpack binary buffer to a HDMI DRM infoframe
+ * @frame: HDMI DRM infoframe
+ * @buffer: source buffer
+ * @size: size of buffer
+ *
+ * Unpacks the information contained in binary @buffer into a structured
+ * @frame of the HDMI Dynamic Range and Mastering (DRM) information frame.
+ * Also verifies the checksum as required by section 5.3.5 of the HDMI 1.4
+ * specification.
+ *
+ * Returns 0 on success or a negative error code on failure.
+ */
+static int hdmi_drm_infoframe_unpack(struct hdmi_drm_infoframe *frame,
+				     const void *buffer, size_t size)
+{
+	const u8 *ptr = buffer;
+	const u8 *temp;
+	u8 x_lsb, x_msb;
+	u8 y_lsb, y_msb;
+	int ret;
+	int i;
+
+	if (size < HDMI_INFOFRAME_SIZE(DRM))
+		return -EINVAL;
+
+	if (ptr[0] != HDMI_INFOFRAME_TYPE_DRM ||
+	    ptr[1] != 1 ||
+	    ptr[2] != HDMI_DRM_INFOFRAME_SIZE)
+		return -EINVAL;
+
+	if (hdmi_infoframe_checksum(buffer, HDMI_INFOFRAME_SIZE(DRM)) != 0)
+		return -EINVAL;
+
+	ret = hdmi_drm_infoframe_init(frame);
+	if (ret)
+		return ret;
+
+	ptr += HDMI_INFOFRAME_HEADER_SIZE;
+
+	frame->eotf = ptr[0] & 0x7;
+	frame->metadata_type = ptr[1] & 0x7;
+
+	temp = ptr + 2;
+	for (i = 0; i < 3; i++) {
+		x_lsb = *temp++;
+		x_msb = *temp++;
+		frame->display_primaries[i].x =  (x_msb << 8) | x_lsb;
+		y_lsb = *temp++;
+		y_msb = *temp++;
+		frame->display_primaries[i].y = (y_msb << 8) | y_lsb;
+	}
+
+	frame->white_point.x = (ptr[15] << 8) | ptr[14];
+	frame->white_point.y = (ptr[17] << 8) | ptr[16];
+
+	frame->max_display_mastering_luminance = (ptr[19] << 8) | ptr[18];
+	frame->min_display_mastering_luminance = (ptr[21] << 8) | ptr[20];
+	frame->max_cll = (ptr[23] << 8) | ptr[22];
+	frame->max_fall = (ptr[25] << 8) | ptr[24];
+
+	return 0;
+}
+
+/**
  * hdmi_infoframe_unpack() - unpack binary buffer to a HDMI infoframe
  * @frame: HDMI infoframe
  * @buffer: source buffer
@@ -1827,6 +1894,9 @@ int hdmi_infoframe_unpack(union hdmi_infoframe *frame,
 	case HDMI_INFOFRAME_TYPE_AVI:
 		ret = hdmi_avi_infoframe_unpack(&frame->avi, buffer, size);
 		break;
+	case HDMI_INFOFRAME_TYPE_DRM:
+		ret = hdmi_drm_infoframe_unpack(&frame->drm, buffer, size);
+		break;
 	case HDMI_INFOFRAME_TYPE_SPD:
 		ret = hdmi_spd_infoframe_unpack(&frame->spd, buffer, size);
 		break;
diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
index 3d7f10f..ee55ba5 100644
--- a/include/linux/hdmi.h
+++ b/include/linux/hdmi.h
@@ -56,6 +56,7 @@ enum hdmi_infoframe_type {
 #define HDMI_AVI_INFOFRAME_SIZE    13
 #define HDMI_SPD_INFOFRAME_SIZE    25
 #define HDMI_AUDIO_INFOFRAME_SIZE  10
+#define HDMI_DRM_INFOFRAME_SIZE    26
 
 #define HDMI_INFOFRAME_SIZE(type)	\
 	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-05-14 17:36 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 17:36 [v10 00/12] Add HDR Metadata Parsing and handling in DRM layer Uma Shankar
2019-05-14 17:29 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev10) Patchwork
2019-05-14 17:36 ` [v10 01/12] drm: Add HDR source metadata property Uma Shankar
2019-05-15 19:10   ` Ville Syrjälä
2019-05-15 19:33     ` Jonas Karlman
2019-05-15 19:45       ` Ville Syrjälä
2019-05-15 19:50         ` Jonas Karlman
2019-05-16  7:21     ` Shankar, Uma
2019-05-14 17:36 ` [v10 02/12] drm: Add reference counting on HDR metadata blob Uma Shankar
2019-05-14 17:36 ` [v10 03/12] drm: Parse HDR metadata info from EDID Uma Shankar
2019-05-15 19:36   ` Ville Syrjälä
2019-05-16  7:25     ` Shankar, Uma
2019-05-14 17:36 ` [v10 04/12] drm: Enable HDR infoframe support Uma Shankar
2019-05-15 19:15   ` Ville Syrjälä
2019-05-16  7:22     ` Shankar, Uma
2019-05-14 17:36 ` [v10 05/12] drm/i915: Attach HDR metadata property to connector Uma Shankar
2019-05-14 17:36 ` [v10 06/12] drm/i915: Write HDR infoframe and send to panel Uma Shankar
2019-05-14 17:36 ` [v10 07/12] drm: Add HLG EOTF Uma Shankar
2019-05-14 17:36 ` [v10 08/12] drm/i915: Enable infoframes on GLK+ for HDR Uma Shankar
2019-05-14 17:36 ` [v10 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes Uma Shankar
2019-05-15 19:27   ` Ville Syrjälä
2019-05-16 10:54     ` Shankar, Uma
2019-05-16 13:13       ` Ville Syrjälä
2019-05-14 17:36 ` [v10 10/12] drm/i915: Added DRM Infoframe handling for BYT/CHT Uma Shankar
2019-05-14 17:36 ` Uma Shankar [this message]
2019-05-14 17:36 ` [v10 12/12] drm/i915: Add state readout for DRM infoframe Uma Shankar
2019-05-15 19:29   ` Ville Syrjälä
2019-05-16  7:23     ` Shankar, Uma
2019-05-14 17:50 ` ✓ Fi.CI.BAT: success for Add HDR Metadata Parsing and handling in DRM layer (rev10) Patchwork
2019-05-15  1:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-15  8:59   ` Shankar, Uma
2019-05-15 10:34     ` Saarinen, Jani
2019-05-15 19:32     ` Ville Syrjälä
2019-05-16  7:28       ` Shankar, Uma
2019-05-16 13:15         ` Ville Syrjälä
2019-05-16 13:18           ` Shankar, Uma
2019-05-16 14:08             ` Martin Peres
2019-05-17 13:04             ` Ville Syrjälä
2019-05-17 13:09               ` Peres, Martin
2019-05-17 13:17                 ` Shankar, Uma
2019-05-17 13:24                   ` Ville Syrjälä
2019-05-17 13:38                     ` Shankar, Uma
2019-05-15 12:33 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557855394-12214-12-git-send-email-uma.shankar@intel.com \
    --to=uma.shankar@intel.com \
    --cc=dcastagna@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonas@kwiboo.se \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox