From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: dcastagna@chromium.org, jonas@kwiboo.se,
intel-gfx@lists.freedesktop.org, emil.l.velikov@gmail.com,
dri-devel@lists.freedesktop.org, seanpaul@chromium.org
Subject: Re: [v10 12/12] drm/i915: Add state readout for DRM infoframe
Date: Wed, 15 May 2019 22:29:56 +0300 [thread overview]
Message-ID: <20190515192956.GG24299@intel.com> (raw)
In-Reply-To: <1557855394-12214-13-git-send-email-uma.shankar@intel.com>
On Tue, May 14, 2019 at 11:06:34PM +0530, Uma Shankar wrote:
> Added state readout for DRM infoframe and enabled
> state validation for DRM infoframe.
>
> v2: Addressed Ville's review comments and dropped the
> unused drm infoframe read at intel_hdmi_init.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 ++++
> drivers/gpu/drm/i915/intel_display.c | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 0af47f3..f574315 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3834,6 +3834,10 @@ void intel_ddi_get_config(struct intel_encoder *encoder,
> intel_read_infoframe(encoder, pipe_config,
> HDMI_INFOFRAME_TYPE_VENDOR,
> &pipe_config->infoframes.hdmi);
> + if ((INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)))
Silly extra parens. Actually, I think the check can be
removed entirely since intel_read_infoframe() also checks
infoframes.enable.
> + intel_read_infoframe(encoder, pipe_config,
> + HDMI_INFOFRAME_TYPE_DRM,
> + &pipe_config->infoframes.drm);
> }
>
> static enum intel_output_type
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index e35ba8d..c89b214 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12274,6 +12274,7 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv)
> PIPE_CONF_CHECK_INFOFRAME(avi);
> PIPE_CONF_CHECK_INFOFRAME(spd);
> PIPE_CONF_CHECK_INFOFRAME(hdmi);
> + PIPE_CONF_CHECK_INFOFRAME(drm);
>
> #undef PIPE_CONF_CHECK_X
> #undef PIPE_CONF_CHECK_I
> --
> 1.9.1
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-15 19:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 17:36 [v10 00/12] Add HDR Metadata Parsing and handling in DRM layer Uma Shankar
2019-05-14 17:29 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev10) Patchwork
2019-05-14 17:36 ` [v10 01/12] drm: Add HDR source metadata property Uma Shankar
2019-05-15 19:10 ` Ville Syrjälä
2019-05-15 19:33 ` Jonas Karlman
2019-05-15 19:45 ` Ville Syrjälä
2019-05-15 19:50 ` Jonas Karlman
2019-05-16 7:21 ` Shankar, Uma
2019-05-14 17:36 ` [v10 02/12] drm: Add reference counting on HDR metadata blob Uma Shankar
2019-05-14 17:36 ` [v10 03/12] drm: Parse HDR metadata info from EDID Uma Shankar
2019-05-15 19:36 ` Ville Syrjälä
2019-05-16 7:25 ` Shankar, Uma
2019-05-14 17:36 ` [v10 04/12] drm: Enable HDR infoframe support Uma Shankar
2019-05-15 19:15 ` Ville Syrjälä
2019-05-16 7:22 ` Shankar, Uma
2019-05-14 17:36 ` [v10 05/12] drm/i915: Attach HDR metadata property to connector Uma Shankar
2019-05-14 17:36 ` [v10 06/12] drm/i915: Write HDR infoframe and send to panel Uma Shankar
2019-05-14 17:36 ` [v10 07/12] drm: Add HLG EOTF Uma Shankar
2019-05-14 17:36 ` [v10 08/12] drm/i915: Enable infoframes on GLK+ for HDR Uma Shankar
2019-05-14 17:36 ` [v10 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes Uma Shankar
2019-05-15 19:27 ` Ville Syrjälä
2019-05-16 10:54 ` Shankar, Uma
2019-05-16 13:13 ` Ville Syrjälä
2019-05-14 17:36 ` [v10 10/12] drm/i915: Added DRM Infoframe handling for BYT/CHT Uma Shankar
2019-05-14 17:36 ` [v10 11/12] video/hdmi: Add Unpack function for DRM infoframe Uma Shankar
2019-05-14 17:36 ` [v10 12/12] drm/i915: Add state readout " Uma Shankar
2019-05-15 19:29 ` Ville Syrjälä [this message]
2019-05-16 7:23 ` Shankar, Uma
2019-05-14 17:50 ` ✓ Fi.CI.BAT: success for Add HDR Metadata Parsing and handling in DRM layer (rev10) Patchwork
2019-05-15 1:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-15 8:59 ` Shankar, Uma
2019-05-15 10:34 ` Saarinen, Jani
2019-05-15 19:32 ` Ville Syrjälä
2019-05-16 7:28 ` Shankar, Uma
2019-05-16 13:15 ` Ville Syrjälä
2019-05-16 13:18 ` Shankar, Uma
2019-05-16 14:08 ` Martin Peres
2019-05-17 13:04 ` Ville Syrjälä
2019-05-17 13:09 ` Peres, Martin
2019-05-17 13:17 ` Shankar, Uma
2019-05-17 13:24 ` Ville Syrjälä
2019-05-17 13:38 ` Shankar, Uma
2019-05-15 12:33 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515192956.GG24299@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dcastagna@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonas@kwiboo.se \
--cc=seanpaul@chromium.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox