From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [RFC 16/28] drm/i915: Compartmentalize i915_ggtt_probe_hw
Date: Fri, 14 Jun 2019 10:35:57 +0100 [thread overview]
Message-ID: <15623051-38a0-88a6-a1d2-578abb0117ea@linux.intel.com> (raw)
In-Reply-To: <156043460670.17012.7120509194419771135@skylake-alporthouse-com>
On 13/06/2019 15:03, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-13 14:35:27)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Having made start to better code compartmentalization by introducing
>> struct intel_gt, continue the theme elsewhere in code by making functions
>> take parameters take what logically makes most sense for them instead of
>> the global struct drm_i915_private.
>
> Is that a can of worms I see? :)
>
> While you are here, care to pull in the gmch probe so we can drop the
> frankenstein approach.
What exactly do you mean? Pull in what from where to where?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-14 9:35 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 13:35 [RFC v3 00/28] Implicit dev_priv removal and GT compartmentalization Tvrtko Ursulin
2019-06-13 13:35 ` [RFC 01/28] drm/i915: Convert intel_vgt_(de)balloon to uncore Tvrtko Ursulin
2019-06-13 13:41 ` Chris Wilson
2019-06-13 13:35 ` [RFC 02/28] drm/i915: Introduce struct intel_gt as replacement for anonymous i915->gt Tvrtko Ursulin
2019-06-13 13:42 ` Chris Wilson
2019-06-13 13:35 ` [RFC 03/28] drm/i915: Move intel_gt initialization to a separate file Tvrtko Ursulin
2019-06-13 13:43 ` Chris Wilson
2019-06-13 13:35 ` [RFC 04/28] drm/i915: Store some backpointers in struct intel_gt Tvrtko Ursulin
2019-06-13 13:44 ` Chris Wilson
2019-06-13 13:35 ` [RFC 05/28] drm/i915: Make i915_check_and_clear_faults take intel_gt Tvrtko Ursulin
2019-06-13 13:45 ` Chris Wilson
2019-06-13 13:35 ` [RFC 06/28] drm/i915: Convert i915_gem_init_swizzling to intel_gt Tvrtko Ursulin
2019-06-13 13:49 ` Chris Wilson
2019-06-14 9:06 ` Tvrtko Ursulin
2019-06-14 9:24 ` Chris Wilson
2019-06-14 9:42 ` Tvrtko Ursulin
2019-06-14 9:59 ` Chris Wilson
2019-06-13 13:35 ` [RFC 07/28] drm/i915: Convert init_unused_rings " Tvrtko Ursulin
2019-06-13 13:49 ` Chris Wilson
2019-06-13 13:35 ` [RFC 08/28] drm/i915: Convert gt workarounds " Tvrtko Ursulin
2019-06-13 13:50 ` Chris Wilson
2019-06-13 13:35 ` [RFC 09/28] drm/i915: Store backpointer to intel_gt in the engine Tvrtko Ursulin
2019-06-13 13:50 ` Chris Wilson
2019-06-13 13:52 ` Chris Wilson
2019-06-13 13:35 ` [RFC 10/28] drm/i915: Convert intel_mocs_init_l3cc_table to intel_gt Tvrtko Ursulin
2019-06-13 13:53 ` Chris Wilson
2019-06-13 13:35 ` [RFC 11/28] drm/i915: Convert i915_ppgtt_init_hw " Tvrtko Ursulin
2019-06-13 13:55 ` Chris Wilson
2019-06-13 13:35 ` [RFC 12/28] drm/i915: Consolidate some open coded mmio rmw Tvrtko Ursulin
2019-06-13 13:35 ` [RFC 13/28] drm/i915: Convert i915_gem_init_hw to intel_gt Tvrtko Ursulin
2019-06-13 13:59 ` Chris Wilson
2019-06-13 16:11 ` Tvrtko Ursulin
2019-06-13 16:30 ` Chris Wilson
2019-06-14 9:34 ` Tvrtko Ursulin
2019-06-14 9:41 ` Chris Wilson
2019-06-14 15:00 ` Tvrtko Ursulin
2019-06-14 15:10 ` Chris Wilson
2019-06-13 13:35 ` [RFC 14/28] drm/i915: Move intel_engines_resume into common init Tvrtko Ursulin
2019-06-13 14:01 ` Chris Wilson
2019-06-13 13:35 ` [RFC 15/28] drm/i915: Stop using I915_READ/WRITE in intel_wopcm_init_hw Tvrtko Ursulin
2019-06-13 13:35 ` [RFC 16/28] drm/i915: Compartmentalize i915_ggtt_probe_hw Tvrtko Ursulin
2019-06-13 14:03 ` Chris Wilson
2019-06-14 9:35 ` Tvrtko Ursulin [this message]
2019-06-14 10:23 ` Chris Wilson
2019-06-14 15:01 ` Tvrtko Ursulin
2019-06-13 13:35 ` [RFC 17/28] drm/i915: Compartmentalize i915_ggtt_init_hw Tvrtko Ursulin
2019-06-13 14:05 ` Chris Wilson
2019-06-13 13:35 ` [RFC 18/28] drm/i915: Make ggtt invalidation work on ggtt Tvrtko Ursulin
2019-06-13 14:05 ` Chris Wilson
2019-06-13 13:35 ` [RFC 19/28] drm/i915: Store intel_gt backpointer in vm Tvrtko Ursulin
2019-06-13 13:35 ` [RFC 20/28] drm/i915: Compartmentalize i915_gem_suspend/restore_gtt_mappings Tvrtko Ursulin
2019-06-13 14:08 ` Chris Wilson
2019-06-14 9:51 ` Tvrtko Ursulin
2019-06-14 10:26 ` Chris Wilson
2019-06-13 13:35 ` [RFC 21/28] drm/i915/gtt: Reduce source verbosity by caching repeated dereferences Tvrtko Ursulin
2019-06-13 14:12 ` Chris Wilson
2019-06-13 15:44 ` Tvrtko Ursulin
2019-06-13 15:18 ` [RFC 22/28] drm/i915: Convert i915_gem_flush_ggtt_writes to intel_gt Tvrtko Ursulin
2019-06-13 15:28 ` Chris Wilson
2019-06-13 15:18 ` [RFC 23/28] drm/i915: Compartmentalize timeline_init/park/fini Tvrtko Ursulin
2019-06-13 15:31 ` Chris Wilson
2019-06-13 15:19 ` [RFC 24/28] drm/i915: Compartmentalize i915_ggtt_cleanup_hw Tvrtko Ursulin
2019-06-13 15:19 ` [RFC 25/28] drm/i915: Compartmentalize i915_gem_init_ggtt Tvrtko Ursulin
2019-06-13 15:38 ` Chris Wilson
2019-06-13 15:48 ` Tvrtko Ursulin
2019-06-13 15:19 ` [RFC 26/28] drm/i915: Store ggtt pointer in intel_gt Tvrtko Ursulin
2019-06-13 15:42 ` Chris Wilson
2019-06-13 15:55 ` Tvrtko Ursulin
2019-06-13 15:19 ` [RFC 27/28] drm/i915: Compartmentalize ring buffer creation Tvrtko Ursulin
2019-06-13 15:46 ` Chris Wilson
2019-06-13 15:56 ` Tvrtko Ursulin
2019-06-13 16:33 ` Chris Wilson
2019-06-13 15:19 ` [RFC 28/28] drm/i915: Make timelines gt centric Tvrtko Ursulin
2019-06-13 15:47 ` Chris Wilson
2019-06-13 21:36 ` Chris Wilson
2019-06-13 15:36 ` [RFC 24/28] drm/i915: Compartmentalize i915_ggtt_cleanup_hw Chris Wilson
2019-06-14 10:28 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15623051-38a0-88a6-a1d2-578abb0117ea@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox