From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fbdev: Remove DRM's helpers for fbdev I/O (rev5)
Date: Wed, 31 May 2023 08:46:05 -0000 [thread overview]
Message-ID: <168552276556.17618.9723111988225066364@emeril.freedesktop.org> (raw)
In-Reply-To: <20230530151228.22979-1-tzimmermann@suse.de>
== Series Details ==
Series: drm/fbdev: Remove DRM's helpers for fbdev I/O (rev5)
URL : https://patchwork.freedesktop.org/series/117671/
State : warning
== Summary ==
Error: dim checkpatch failed
c2b77e5dfd8d fbdev: Add Kconfig options to select different fb_ops helpers
ff5e482b5d47 fbdev: Add initializer macros for struct fb_ops
-:50: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#50: FILE: include/linux/fb.h:557:
+#define FB_DEFAULT_IO_OPS \
+ __FB_DEFAULT_IO_OPS_RDWR, \
+ __FB_DEFAULT_IO_OPS_DRAW, \
+ __FB_DEFAULT_IO_OPS_MMAP
-:82: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#82: FILE: include/linux/fb.h:590:
+#define FB_DEFAULT_SYS_OPS \
+ __FB_DEFAULT_SYS_OPS_RDWR, \
+ __FB_DEFAULT_SYS_OPS_DRAW, \
+ __FB_DEFAULT_SYS_OPS_MMAP
-:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__damage_area' - possible side-effects?
#114: FILE: include/linux/fb.h:670:
+#define __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, __mode) \
+ static void __prefix ## _defio_fillrect(struct fb_info *info, \
+ const struct fb_fillrect *rect) \
+ { \
+ __mode ## _fillrect(info, rect); \
+ __damage_area(info, rect->dx, rect->dy, rect->width, rect->height); \
+ } \
+ static void __prefix ## _defio_copyarea(struct fb_info *info, \
+ const struct fb_copyarea *area) \
+ { \
+ __mode ## _copyarea(info, area); \
+ __damage_area(info, area->dx, area->dy, area->width, area->height); \
+ } \
+ static void __prefix ## _defio_imageblit(struct fb_info *info, \
+ const struct fb_image *image) \
+ { \
+ __mode ## _imageblit(info, image); \
+ __damage_area(info, image->dx, image->dy, image->width, image->height); \
+ }
-:134: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#134: FILE: include/linux/fb.h:690:
+#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb)
-:134: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects?
#134: FILE: include/linux/fb.h:690:
+#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb)
-:138: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#138: FILE: include/linux/fb.h:694:
+#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys)
-:138: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects?
#138: FILE: include/linux/fb.h:694:
+#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \
+ __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys)
-:158: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#158: FILE: include/linux/fb.h:714:
+#define FB_DEFAULT_DEFERRED_OPS(__prefix) \
+ __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \
+ __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \
+ __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix)
-:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects?
#158: FILE: include/linux/fb.h:714:
+#define FB_DEFAULT_DEFERRED_OPS(__prefix) \
+ __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \
+ __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \
+ __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix)
total: 5 errors, 0 warnings, 4 checks, 133 lines checked
e14669fc8202 drm/armada: Use regular fbdev I/O helpers
f150181e6d5f drm/exynos: Use regular fbdev I/O helpers
96df051db90b drm/gma500: Use regular fbdev I/O helpers
b80040be5a32 drm/radeon: Use regular fbdev I/O helpers
830521199632 drm/fbdev-dma: Use regular fbdev I/O helpers
1a2c3c860665 drm/omapdrm: Use regular fbdev I/O helpers
f9bbb729d14a drm/tegra: Use regular fbdev I/O helpers
578b9365edb4 drm/fb-helper: Export helpers for marking damage areas
4ac0e8af7214 drm/msm: Use regular fbdev I/O helpers
8d46b2319aff drm/fbdev-generic: Implement dedicated fbdev I/O helpers
0ed42c8fdeca drm/i915: Implement dedicated fbdev I/O helpers
next prev parent reply other threads:[~2023-05-31 8:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 15:12 [Intel-gfx] [PATCH v5 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 01/13] fbdev: Add Kconfig options to select different fb_ops helpers Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 02/13] fbdev: Add initializer macros for struct fb_ops Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 03/13] drm/armada: Use regular fbdev I/O helpers Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 04/13] drm/exynos: " Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 05/13] drm/gma500: " Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 06/13] drm/radeon: " Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 07/13] drm/fbdev-dma: " Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 08/13] drm/omapdrm: " Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 09/13] drm/tegra: " Thomas Zimmermann
2023-06-01 9:42 ` Thierry Reding
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 10/13] drm/fb-helper: Export helpers for marking damage areas Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 11/13] drm/msm: Use regular fbdev I/O helpers Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 12/13] drm/fbdev-generic: Implement dedicated " Thomas Zimmermann
2023-05-30 15:12 ` [Intel-gfx] [PATCH v5 13/13] drm/i915: " Thomas Zimmermann
2023-05-31 8:46 ` Patchwork [this message]
2023-05-31 8:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/fbdev: Remove DRM's helpers for fbdev I/O (rev5) Patchwork
2023-05-31 9:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-01 16:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168552276556.17618.9723111988225066364@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox