From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH v3 4/5] drm/i915: cpu-map based dumb buffers
Date: Tue, 15 Oct 2019 14:34:45 +0300 [thread overview]
Message-ID: <1732c6ff-c55e-c1b4-2708-87c6ec95fd5d@linux.intel.com> (raw)
In-Reply-To: <157113815409.22469.15481252246242687026@skylake-alporthouse-com>
On 15/10/2019 14.15, Chris Wilson wrote:
> Quoting Abdiel Janulgue (2019-10-15 09:37:23)
>> +int
>> +i915_gem_mmap_dumb(struct drm_file *file,
>> + struct drm_device *dev,
>> + u32 handle,
>> + u64 *offset)
>> +{
>> + struct drm_i915_private *i915 = to_i915(dev);
>> + enum i915_mmap_type mmap_type = HAS_MAPPABLE_APERTURE(i915) ?
>> + I915_MMAP_TYPE_GTT : I915_MMAP_TYPE_WC;
>
> Is there any reason to prefer GTT at all?
> -Chris
I'm not aware of any. :/ Yeah this could be all CPU mmaps
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-15 11:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 8:37 [PATCH v3 1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue
2019-10-15 8:37 ` [PATCH v3 2/5] drm/i915: define HAS_MAPPABLE_APERTURE Abdiel Janulgue
2019-10-15 8:37 ` [PATCH v3 3/5] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue
2019-10-15 11:14 ` Chris Wilson
2019-10-15 8:37 ` [PATCH v3 4/5] drm/i915: cpu-map based dumb buffers Abdiel Janulgue
2019-10-15 11:15 ` Chris Wilson
2019-10-15 11:34 ` Abdiel Janulgue [this message]
2019-10-15 8:37 ` [PATCH v3 5/5] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue
2019-10-15 8:48 ` Chris Wilson
2019-10-15 9:05 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Patchwork
2019-10-15 10:14 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-15 11:06 ` [PATCH v3 1/5] " Chris Wilson
2019-10-15 16:43 ` ✓ Fi.CI.IGT: success for series starting with [v3,1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732c6ff-c55e-c1b4-2708-87c6ec95fd5d@linux.intel.com \
--to=abdiel.janulgue@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox