public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core
Date: Tue, 15 Oct 2019 09:05:44 -0000	[thread overview]
Message-ID: <20191015090544.22842.59541@emeril.freedesktop.org> (raw)
In-Reply-To: <20191015083724.24390-1-abdiel.janulgue@linux.intel.com>

== Series Details ==

Series: series starting with [v3,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core
URL   : https://patchwork.freedesktop.org/series/68010/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
020865777f8a drm/i915: Allow i915 to manage the vma offset nodes instead of drm core
-:337: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#337: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:648:
+
+	}

-:503: CHECK:LINE_SPACING: Please don't use multiple blank lines
#503: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:573:
 
+

total: 0 errors, 0 warnings, 2 checks, 559 lines checked
6fdb184775a4 drm/i915: define HAS_MAPPABLE_APERTURE
-:20: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues
#20: FILE: drivers/gpu/drm/i915/i915_drv.h:1738:
+#define HAS_MAPPABLE_APERTURE(dev_priv) (dev_priv->ggtt.mappable_end > 0)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
c3709716f57f drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET
-:118: WARNING:LONG_LINE: line over 100 characters
#118: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_MMAP_GTT	DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MMAP_GTT, struct drm_i915_gem_mmap_offset)

total: 0 errors, 1 warnings, 0 checks, 111 lines checked
3fa09534bd30 drm/i915: cpu-map based dumb buffers
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:568:
+i915_gem_mmap_dumb(struct drm_file *file,
+		  struct drm_device *dev,

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/gpu/drm/i915/i915_drv.h:1937:
+int i915_gem_mmap_dumb(struct drm_file *file_priv, struct drm_device *dev,
+		      u32 handle, u64 *offset);

total: 0 errors, 0 warnings, 2 checks, 34 lines checked
e932227102bb drm/i915: Add cpu fault handler for mmap_offset

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-15  9:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15  8:37 [PATCH v3 1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue
2019-10-15  8:37 ` [PATCH v3 2/5] drm/i915: define HAS_MAPPABLE_APERTURE Abdiel Janulgue
2019-10-15  8:37 ` [PATCH v3 3/5] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue
2019-10-15 11:14   ` Chris Wilson
2019-10-15  8:37 ` [PATCH v3 4/5] drm/i915: cpu-map based dumb buffers Abdiel Janulgue
2019-10-15 11:15   ` Chris Wilson
2019-10-15 11:34     ` Abdiel Janulgue
2019-10-15  8:37 ` [PATCH v3 5/5] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue
2019-10-15  8:48   ` Chris Wilson
2019-10-15  9:05 ` Patchwork [this message]
2019-10-15 10:14 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Patchwork
2019-10-15 11:06 ` [PATCH v3 1/5] " Chris Wilson
2019-10-15 16:43 ` ✓ Fi.CI.IGT: success for series starting with [v3,1/5] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015090544.22842.59541@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=abdiel.janulgue@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox