* [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs
@ 2023-06-24 17:17 Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 1/6] drm/i915/gt: Move wal_get_fw_for_rmw() Lucas De Marchi
` (9 more replies)
0 siblings, 10 replies; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-24 17:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Kenneth Graunke, Matt Roper, dri-devel
v2 of https://patchwork.freedesktop.org/series/119766/
Main change from v1 is the preparatory patch to handle GEN12_FF_MODE2.
This is a register that can't be read back since it's affected by
another workaround.
Also add some other cleanups/fixes nearby. Tested on DG2 with intel_reg
reading 0xb158 with a busy render engine. Now it's not losing the upper
bit anymore.
Also removed the Cc to stable. This will be handled separately once the
patch is merged. With graphics version 12 not being affected, this needs
to be backported only to kernel versions after DG2/MTL started to be
supported. But in that case the preparatory patch would also need to be
backported so it doesn't branch graphics version 12.
Lucas De Marchi (6):
drm/i915/gt: Move wal_get_fw_for_rmw()
drm/i915/gt: Clear all bits from GEN12_FF_MODE2
drm/i915/gt: Fix context workarounds with non-masked regs
drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround
drm/i915/gt: Enable read back on XEHP_FF_MODE2
drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER
drivers/gpu/drm/i915/gt/intel_workarounds.c | 124 ++++++++++----------
1 file changed, 63 insertions(+), 61 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH v2 1/6] drm/i915/gt: Move wal_get_fw_for_rmw()
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
@ 2023-06-24 17:17 ` Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/gt: Clear all bits from GEN12_FF_MODE2 Lucas De Marchi
` (8 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-24 17:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Kenneth Graunke, Matt Roper, dri-devel
Move helper function to get all the forcewakes required by the wa list
to the top, so it can be re-used by other functions.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 32 ++++++++++-----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 01807a7dd2c1..8f8346df3c18 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -123,6 +123,22 @@ static void wa_init_finish(struct i915_wa_list *wal)
wal->wa_count, wal->name, wal->engine_name);
}
+static enum forcewake_domains
+wal_get_fw_for_rmw(struct intel_uncore *uncore, const struct i915_wa_list *wal)
+{
+ enum forcewake_domains fw = 0;
+ struct i915_wa *wa;
+ unsigned int i;
+
+ for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
+ fw |= intel_uncore_forcewake_for_reg(uncore,
+ wa->reg,
+ FW_REG_READ |
+ FW_REG_WRITE);
+
+ return fw;
+}
+
static void _wa_add(struct i915_wa_list *wal, const struct i915_wa *wa)
{
unsigned int addr = i915_mmio_reg_offset(wa->reg);
@@ -1859,22 +1875,6 @@ void intel_gt_init_workarounds(struct intel_gt *gt)
wa_init_finish(wal);
}
-static enum forcewake_domains
-wal_get_fw_for_rmw(struct intel_uncore *uncore, const struct i915_wa_list *wal)
-{
- enum forcewake_domains fw = 0;
- struct i915_wa *wa;
- unsigned int i;
-
- for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
- fw |= intel_uncore_forcewake_for_reg(uncore,
- wa->reg,
- FW_REG_READ |
- FW_REG_WRITE);
-
- return fw;
-}
-
static bool
wa_verify(struct intel_gt *gt, const struct i915_wa *wa, u32 cur,
const char *name, const char *from)
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH v2 2/6] drm/i915/gt: Clear all bits from GEN12_FF_MODE2
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 1/6] drm/i915/gt: Move wal_get_fw_for_rmw() Lucas De Marchi
@ 2023-06-24 17:17 ` Lucas De Marchi
2023-06-25 18:39 ` Matt Roper
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs Lucas De Marchi
` (7 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-24 17:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Kenneth Graunke, Matt Roper, dri-devel
Right now context workarounds don't do a rmw and instead only write to
the register. Since 2 separate programmings to the same register are
coalesced into a single write, this is not problematic for
GEN12_FF_MODE2 since both TDS and GS timer are going to be written
together and the other remaining bits be zeroed.
However in order to fix other workarounds that may want to preserve the
unrelated bits in the same register, context workarounds need to
be changed to a rmw. To prepare for that, move the programming of
GEN12_FF_MODE2 to a single place so the value passed for "clear" can
be all the bits. Otherwise the second workaround would be dropped as
it'd be detected as overwriting a previously programmed workaround.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 51 +++++++--------------
1 file changed, 17 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 8f8346df3c18..7d48bd57b6ef 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -693,40 +693,11 @@ static void dg2_ctx_gt_tuning_init(struct intel_engine_cs *engine,
0, false);
}
-/*
- * These settings aren't actually workarounds, but general tuning settings that
- * need to be programmed on several platforms.
- */
-static void gen12_ctx_gt_tuning_init(struct intel_engine_cs *engine,
- struct i915_wa_list *wal)
-{
- /*
- * Although some platforms refer to it as Wa_1604555607, we need to
- * program it even on those that don't explicitly list that
- * workaround.
- *
- * Note that the programming of this register is further modified
- * according to the FF_MODE2 guidance given by Wa_1608008084:gen12.
- * Wa_1608008084 tells us the FF_MODE2 register will return the wrong
- * value when read. The default value for this register is zero for all
- * fields and there are no bit masks. So instead of doing a RMW we
- * should just write TDS timer value. For the same reason read
- * verification is ignored.
- */
- wa_add(wal,
- GEN12_FF_MODE2,
- FF_MODE2_TDS_TIMER_MASK,
- FF_MODE2_TDS_TIMER_128,
- 0, false);
-}
-
static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
struct i915_wa_list *wal)
{
struct drm_i915_private *i915 = engine->i915;
- gen12_ctx_gt_tuning_init(engine, wal);
-
/*
* Wa_1409142259:tgl,dg1,adl-p
* Wa_1409347922:tgl,dg1,adl-p
@@ -748,15 +719,27 @@ static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
/*
- * Wa_16011163337
+ * Wa_16011163337 - GS_TIMER
+ *
+ * TDS_TIMER: Although some platforms refer to it as Wa_1604555607, we
+ * need to program it even on those that don't explicitly list that
+ * workaround.
+ *
+ * Note that the programming of GEN12_FF_MODE2 is further modified
+ * according to the FF_MODE2 guidance given by Wa_1608008084.
+ * Wa_1608008084 tells us the FF_MODE2 register will return the wrong
+ * value when read from the CPU.
*
- * Like in gen12_ctx_gt_tuning_init(), read verification is ignored due
- * to Wa_1608008084.
+ * The default value for this register is zero for all fields.
+ * So instead of doing a RMW we should just write the desired values
+ * for TDS and GS timers. Note that since the readback can't be trusted,
+ * the clear mask is just set to ~0 to make sure other bits are not
+ * inadvertently set. For the same reason read verification is ignored.
*/
wa_add(wal,
GEN12_FF_MODE2,
- FF_MODE2_GS_TIMER_MASK,
- FF_MODE2_GS_TIMER_224,
+ ~0,
+ FF_MODE2_TDS_TIMER_128 | FF_MODE2_GS_TIMER_224,
0, false);
if (!IS_DG1(i915)) {
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 1/6] drm/i915/gt: Move wal_get_fw_for_rmw() Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/gt: Clear all bits from GEN12_FF_MODE2 Lucas De Marchi
@ 2023-06-24 17:17 ` Lucas De Marchi
2023-06-27 18:32 ` Kenneth Graunke
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 4/6] drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround Lucas De Marchi
` (6 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-24 17:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Kenneth Graunke, Matt Roper, dri-devel
Most of the context workarounds tweak masked registers, but not all. For
masked registers, when writing the value it's sufficient to just write
the wa->set_bits since that will take care of both the clr and set bits
as well as not overwriting other bits.
However there are some workarounds, the registers are non-masked. Up
until now the driver was simply emitting a MI_LOAD_REGISTER_IMM with the
set_bits to program the register via the GPU in the WA bb. This has the
side effect of overwriting the content of the register outside of bits
that should be set and also doesn't handle the bits that should be
cleared.
Kenneth reported that on DG2, mesa was seeing a weird behavior due to
the kernel programming of L3SQCREG5 in dg2_ctx_gt_tuning_init(). With
the GPU idle, that register could be read via intel_reg as 0x00e001ff,
but during a 3D workload it would change to 0x0000007f. So the
programming of that tuning was affecting more than the bits in
L3_PWM_TIMER_INIT_VAL_MASK. Matt Roper noticed the lack of rmw for the
context workarounds due to the use of MI_LOAD_REGISTER_IMM.
So, for registers that are not masked, read its value via mmio, modify
and then set it in the buffer to be written by the GPU. This should take
care in a simple way of programming just the bits required by the
tuning/workaround. If in future there are registers that involved that
can't be read by the CPU, a more complex approach may be required like
a) issuing additional instructions to read and modify; or b) scan the
golden context and patch it in place before saving it; or something
else. But for now this should suffice.
Scanning the context workarounds for all platforms, these are the
impacted ones with the respective registers
mtl: DRAW_WATERMARK
mtl/dg2: XEHP_L3SQCREG5, XEHP_FF_MODE2
ICL has some non-masked registers in the context workarounds:
GEN8_L3CNTLREG, IVB_FBC_RT_BASE and VB_FBC_RT_BASE_UPPER, but there
shouldn't be an impact. The first is already being manually read and the
other 2 are intentionally overwriting the entire register. Same
reasoning applies to GEN12_FF_MODE2: the WA is intentionally
overwriting all the bits to avoid a read-modify-write.
v2: Reword commit message wrt GEN12_FF_MODE2 and the changed behavior
on preparatory patches.
Cc: Kenneth Graunke <kenneth@whitecape.org>
Cc: Matt Roper <matthew.d.roper@intel.com>
Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23783#note_1968971
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 27 ++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 7d48bd57b6ef..9291c2b4ca0e 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -986,6 +986,9 @@ void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
int intel_engine_emit_ctx_wa(struct i915_request *rq)
{
struct i915_wa_list *wal = &rq->engine->ctx_wa_list;
+ struct intel_uncore *uncore = rq->engine->uncore;
+ enum forcewake_domains fw;
+ unsigned long flags;
struct i915_wa *wa;
unsigned int i;
u32 *cs;
@@ -1002,13 +1005,35 @@ int intel_engine_emit_ctx_wa(struct i915_request *rq)
if (IS_ERR(cs))
return PTR_ERR(cs);
+ fw = wal_get_fw_for_rmw(uncore, wal);
+
+ intel_gt_mcr_lock(wal->gt, &flags);
+ spin_lock(&uncore->lock);
+ intel_uncore_forcewake_get__locked(uncore, fw);
+
*cs++ = MI_LOAD_REGISTER_IMM(wal->count);
for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
+ u32 val;
+
+ if (wa->masked_reg || wa->set == U32_MAX) {
+ val = wa->set;
+ } else {
+ val = wa->is_mcr ?
+ intel_gt_mcr_read_any_fw(wal->gt, wa->mcr_reg) :
+ intel_uncore_read_fw(uncore, wa->reg);
+ val &= ~wa->clr;
+ val |= wa->set;
+ }
+
*cs++ = i915_mmio_reg_offset(wa->reg);
- *cs++ = wa->set;
+ *cs++ = val;
}
*cs++ = MI_NOOP;
+ intel_uncore_forcewake_put__locked(uncore, fw);
+ spin_unlock(&uncore->lock);
+ intel_gt_mcr_unlock(wal->gt, flags);
+
intel_ring_advance(rq, cs);
ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH v2 4/6] drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
` (2 preceding siblings ...)
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs Lucas De Marchi
@ 2023-06-24 17:17 ` Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 5/6] drm/i915/gt: Enable read back on XEHP_FF_MODE2 Lucas De Marchi
` (5 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-24 17:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Kenneth Graunke, Matt Roper, dri-devel
Now that non-masked registers are already read before programming the
context reads, the additional read became redudant, so remove it.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 9291c2b4ca0e..8ec3d14dcb08 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -637,10 +637,7 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
struct i915_wa_list *wal)
{
/* Wa_1406697149 (WaDisableBankHangMode:icl) */
- wa_write(wal,
- GEN8_L3CNTLREG,
- intel_uncore_read(engine->uncore, GEN8_L3CNTLREG) |
- GEN8_ERRDETBCTRL);
+ wa_write(wal, GEN8_L3CNTLREG, GEN8_ERRDETBCTRL);
/* WaForceEnableNonCoherent:icl
* This is not the same workaround as in early Gen9 platforms, where
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH v2 5/6] drm/i915/gt: Enable read back on XEHP_FF_MODE2
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
` (3 preceding siblings ...)
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 4/6] drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround Lucas De Marchi
@ 2023-06-24 17:17 ` Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER Lucas De Marchi
` (4 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-24 17:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Kenneth Graunke, Matt Roper, dri-devel
Contrary to GEN12_FF_MODE2, platforms using XEHP_FF_MODE2 are not
affected by Wa_1608008084, hence read back can be enabled.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 8ec3d14dcb08..848519b58e45 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -683,11 +683,8 @@ static void dg2_ctx_gt_tuning_init(struct intel_engine_cs *engine,
wa_mcr_masked_en(wal, CHICKEN_RASTER_2, TBIMR_FAST_CLIP);
wa_mcr_write_clr_set(wal, XEHP_L3SQCREG5, L3_PWM_TIMER_INIT_VAL_MASK,
REG_FIELD_PREP(L3_PWM_TIMER_INIT_VAL_MASK, 0x7f));
- wa_mcr_add(wal,
- XEHP_FF_MODE2,
- FF_MODE2_TDS_TIMER_MASK,
- FF_MODE2_TDS_TIMER_128,
- 0, false);
+ wa_mcr_write_clr_set(wal, XEHP_FF_MODE2, FF_MODE2_TDS_TIMER_MASK,
+ FF_MODE2_TDS_TIMER_128);
}
static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
` (4 preceding siblings ...)
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 5/6] drm/i915/gt: Enable read back on XEHP_FF_MODE2 Lucas De Marchi
@ 2023-06-24 17:17 ` Lucas De Marchi
2023-06-27 18:30 ` Kenneth Graunke
2023-06-25 6:42 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Fix ctx workarounds for non-masked regs Patchwork
` (3 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-24 17:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Kenneth Graunke, Matt Roper, dri-devel
The comment on the parameter being 0 to avoid the read back doesn't
apply as this is not a call to wa_mcr_add(), but rather to
wa_mcr_clr_set(). So, this register is actually checked and it's
according to the Bspec that the register is RW, not RO.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 848519b58e45..5fe85fad91c1 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -666,7 +666,7 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
/* Wa_1604278689:icl,ehl */
wa_write(wal, IVB_FBC_RT_BASE, 0xFFFFFFFF & ~ILK_FBC_RT_VALID);
wa_write_clr_set(wal, IVB_FBC_RT_BASE_UPPER,
- 0, /* write-only register; skip validation */
+ 0,
0xFFFFFFFF);
/* Wa_1406306137:icl,ehl */
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for Fix ctx workarounds for non-masked regs
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
` (5 preceding siblings ...)
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER Lucas De Marchi
@ 2023-06-25 6:42 ` Patchwork
2023-06-29 3:42 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Fix ctx workarounds for non-masked regs (rev2) Patchwork
` (2 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-06-25 6:42 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10702 bytes --]
== Series Details ==
Series: Fix ctx workarounds for non-masked regs
URL : https://patchwork.freedesktop.org/series/119826/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13317 -> Patchwork_119826v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_119826v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_119826v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/index.html
Participating hosts (39 -> 37)
------------------------------
Additional (2): bat-rplp-1 fi-pnv-d510
Missing (4): fi-kbl-soraka fi-bsw-n3050 fi-apl-guc fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_119826v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_fence@basic-await@vecs0:
- bat-adln-1: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/bat-adln-1/igt@gem_exec_fence@basic-await@vecs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-adln-1/igt@gem_exec_fence@basic-await@vecs0.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [PASS][3] -> [DMESG-WARN][4] +76 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
Known issues
------------
Here are the changes found in Patchwork_119826v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rplp-1: NOTRUN -> [SKIP][5] ([i915#7456])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rplp-1/igt@debugfs_test@basic-hwmon.html
* igt@gem_tiled_pread_basic:
- bat-rplp-1: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rplp-1/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@gem_contexts:
- fi-kbl-7567u: [PASS][7] -> [DMESG-WARN][8] ([i915#8218])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@hangcheck:
- fi-kbl-7567u: [PASS][9] -> [DMESG-WARN][10] ([i915#8423])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/fi-kbl-7567u/igt@i915_selftest@live@hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-kbl-7567u/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][11] ([i915#6367])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [PASS][12] -> [DMESG-FAIL][13] ([i915#6763])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][14] ([i915#6687] / [i915#8668])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_busy@basic@flip:
- fi-kbl-7567u: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +38 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/fi-kbl-7567u/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-kbl-7567u/igt@kms_busy@basic@flip.html
* igt@kms_chamelium_frames@dp-crc-fast:
- bat-rplp-1: NOTRUN -> [SKIP][17] ([i915#7828]) +7 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rplp-1/igt@kms_chamelium_frames@dp-crc-fast.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-7567u: [PASS][18] -> [DMESG-FAIL][19] ([i915#180]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/fi-kbl-7567u/igt@kms_chamelium_frames@hdmi-crc-fast.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-kbl-7567u/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-rplp-1: NOTRUN -> [SKIP][20] ([i915#4103] / [i915#4213]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rplp-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rplp-1: NOTRUN -> [SKIP][21] ([fdo#109285])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rplp-1/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][22] ([fdo#109271]) +37 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
- bat-rplp-1: NOTRUN -> [SKIP][23] ([i915#1072]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rplp-1/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: NOTRUN -> [ABORT][24] ([i915#4579] / [i915#8260])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
- fi-pnv-d510: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4579])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-pnv-d510/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [DMESG-FAIL][26] ([i915#7059]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [INCOMPLETE][28] ([i915#4983] / [i915#7913] / [i915#8347]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/bat-rpls-2/igt@i915_selftest@live@reset.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][30] ([i915#6367]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [FAIL][32] ([i915#7932]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1:
- fi-rkl-11600: [FAIL][34] ([fdo#103375]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13317/fi-rkl-11600/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/fi-rkl-11600/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8218]: https://gitlab.freedesktop.org/drm/intel/issues/8218
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8423]: https://gitlab.freedesktop.org/drm/intel/issues/8423
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
Build changes
-------------
* Linux: CI_DRM_13317 -> Patchwork_119826v1
CI-20190529: 20190529
CI_DRM_13317: e77d4da4d2bd8d0accd04f83c0008b206f522bc7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7347: 621c2d3115d40a1ba0b53668413ea21edf03a5ff @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119826v1: e77d4da4d2bd8d0accd04f83c0008b206f522bc7 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
d2c98ba84f62 drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER
37c50040fabe drm/i915/gt: Enable read back on XEHP_FF_MODE2
0da8da1dae4e drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround
233c49ee1d44 drm/i915/gt: Fix context workarounds with non-masked regs
7643ec196fc1 drm/i915/gt: Clear all bits from GEN12_FF_MODE2
e7121916a2c8 drm/i915/gt: Move wal_get_fw_for_rmw()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v1/index.html
[-- Attachment #2: Type: text/html, Size: 12195 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/gt: Clear all bits from GEN12_FF_MODE2
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/gt: Clear all bits from GEN12_FF_MODE2 Lucas De Marchi
@ 2023-06-25 18:39 ` Matt Roper
0 siblings, 0 replies; 15+ messages in thread
From: Matt Roper @ 2023-06-25 18:39 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx, Kenneth Graunke, dri-devel
On Sat, Jun 24, 2023 at 10:17:53AM -0700, Lucas De Marchi wrote:
> Right now context workarounds don't do a rmw and instead only write to
> the register. Since 2 separate programmings to the same register are
> coalesced into a single write, this is not problematic for
> GEN12_FF_MODE2 since both TDS and GS timer are going to be written
> together and the other remaining bits be zeroed.
>
> However in order to fix other workarounds that may want to preserve the
> unrelated bits in the same register, context workarounds need to
> be changed to a rmw. To prepare for that, move the programming of
> GEN12_FF_MODE2 to a single place so the value passed for "clear" can
> be all the bits. Otherwise the second workaround would be dropped as
> it'd be detected as overwriting a previously programmed workaround.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 51 +++++++--------------
> 1 file changed, 17 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 8f8346df3c18..7d48bd57b6ef 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -693,40 +693,11 @@ static void dg2_ctx_gt_tuning_init(struct intel_engine_cs *engine,
> 0, false);
> }
>
> -/*
> - * These settings aren't actually workarounds, but general tuning settings that
> - * need to be programmed on several platforms.
> - */
> -static void gen12_ctx_gt_tuning_init(struct intel_engine_cs *engine,
> - struct i915_wa_list *wal)
> -{
> - /*
> - * Although some platforms refer to it as Wa_1604555607, we need to
> - * program it even on those that don't explicitly list that
> - * workaround.
> - *
> - * Note that the programming of this register is further modified
> - * according to the FF_MODE2 guidance given by Wa_1608008084:gen12.
> - * Wa_1608008084 tells us the FF_MODE2 register will return the wrong
> - * value when read. The default value for this register is zero for all
> - * fields and there are no bit masks. So instead of doing a RMW we
> - * should just write TDS timer value. For the same reason read
> - * verification is ignored.
> - */
> - wa_add(wal,
> - GEN12_FF_MODE2,
> - FF_MODE2_TDS_TIMER_MASK,
> - FF_MODE2_TDS_TIMER_128,
> - 0, false);
> -}
> -
> static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
> struct i915_wa_list *wal)
> {
> struct drm_i915_private *i915 = engine->i915;
>
> - gen12_ctx_gt_tuning_init(engine, wal);
> -
> /*
> * Wa_1409142259:tgl,dg1,adl-p
> * Wa_1409347922:tgl,dg1,adl-p
> @@ -748,15 +719,27 @@ static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
> GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
>
> /*
> - * Wa_16011163337
> + * Wa_16011163337 - GS_TIMER
> + *
> + * TDS_TIMER: Although some platforms refer to it as Wa_1604555607, we
> + * need to program it even on those that don't explicitly list that
> + * workaround.
> + *
> + * Note that the programming of GEN12_FF_MODE2 is further modified
> + * according to the FF_MODE2 guidance given by Wa_1608008084.
> + * Wa_1608008084 tells us the FF_MODE2 register will return the wrong
> + * value when read from the CPU.
> *
> - * Like in gen12_ctx_gt_tuning_init(), read verification is ignored due
> - * to Wa_1608008084.
> + * The default value for this register is zero for all fields.
> + * So instead of doing a RMW we should just write the desired values
> + * for TDS and GS timers. Note that since the readback can't be trusted,
> + * the clear mask is just set to ~0 to make sure other bits are not
> + * inadvertently set. For the same reason read verification is ignored.
> */
> wa_add(wal,
> GEN12_FF_MODE2,
> - FF_MODE2_GS_TIMER_MASK,
> - FF_MODE2_GS_TIMER_224,
> + ~0,
> + FF_MODE2_TDS_TIMER_128 | FF_MODE2_GS_TIMER_224,
> 0, false);
>
> if (!IS_DG1(i915)) {
> --
> 2.40.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER Lucas De Marchi
@ 2023-06-27 18:30 ` Kenneth Graunke
2023-06-28 4:02 ` Lucas De Marchi
0 siblings, 1 reply; 15+ messages in thread
From: Kenneth Graunke @ 2023-06-27 18:30 UTC (permalink / raw)
To: intel-gfx, Lucas De Marchi; +Cc: Lucas De Marchi, Matt Roper, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]
On Saturday, June 24, 2023 10:17:57 AM PDT Lucas De Marchi wrote:
> The comment on the parameter being 0 to avoid the read back doesn't
> apply as this is not a call to wa_mcr_add(), but rather to
> wa_mcr_clr_set(). So, this register is actually checked and it's
> according to the Bspec that the register is RW, not RO.
I think you mean wa_add and wa_write_clr_set here (not mcr).
One thing I've been confused about while reading this code:
static void
wa_write_clr_set(struct i915_wa_list *wal, i915_reg_t reg, u32 clear, u32 set)
{
wa_add(wal, reg, clear, set, clear, false);
}
The second to last parameter is read_mask aka wa->read. We're
initializing it to the...bits to clear. (I would think it should be
(clear | set) to pick up all modified bits.)
wa_verify seems to balk at ((cur ^ wa->set) & wa->read). But...if
wa->read is just the clear mask, that wouldn't actually verify that
any bits were set at all. Or am I misunderstanding something?
If not, we may be failing to verify the majority of our workarounds :(
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 848519b58e45..5fe85fad91c1 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -666,7 +666,7 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
> /* Wa_1604278689:icl,ehl */
> wa_write(wal, IVB_FBC_RT_BASE, 0xFFFFFFFF & ~ILK_FBC_RT_VALID);
> wa_write_clr_set(wal, IVB_FBC_RT_BASE_UPPER,
> - 0, /* write-only register; skip validation */
> + 0,
> 0xFFFFFFFF);
>
> /* Wa_1406306137:icl,ehl */
In this particular example, since clear bits are 0, I don't think any
verification is happening at all.
--Ken
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs Lucas De Marchi
@ 2023-06-27 18:32 ` Kenneth Graunke
0 siblings, 0 replies; 15+ messages in thread
From: Kenneth Graunke @ 2023-06-27 18:32 UTC (permalink / raw)
To: intel-gfx, Lucas De Marchi; +Cc: Lucas De Marchi, Matt Roper, dri-devel
[-- Attachment #1: Type: text/plain, Size: 4740 bytes --]
On Saturday, June 24, 2023 10:17:54 AM PDT Lucas De Marchi wrote:
> Most of the context workarounds tweak masked registers, but not all. For
> masked registers, when writing the value it's sufficient to just write
> the wa->set_bits since that will take care of both the clr and set bits
> as well as not overwriting other bits.
>
> However there are some workarounds, the registers are non-masked. Up
> until now the driver was simply emitting a MI_LOAD_REGISTER_IMM with the
> set_bits to program the register via the GPU in the WA bb. This has the
> side effect of overwriting the content of the register outside of bits
> that should be set and also doesn't handle the bits that should be
> cleared.
>
> Kenneth reported that on DG2, mesa was seeing a weird behavior due to
> the kernel programming of L3SQCREG5 in dg2_ctx_gt_tuning_init(). With
> the GPU idle, that register could be read via intel_reg as 0x00e001ff,
> but during a 3D workload it would change to 0x0000007f. So the
> programming of that tuning was affecting more than the bits in
> L3_PWM_TIMER_INIT_VAL_MASK. Matt Roper noticed the lack of rmw for the
> context workarounds due to the use of MI_LOAD_REGISTER_IMM.
>
> So, for registers that are not masked, read its value via mmio, modify
> and then set it in the buffer to be written by the GPU. This should take
> care in a simple way of programming just the bits required by the
> tuning/workaround. If in future there are registers that involved that
> can't be read by the CPU, a more complex approach may be required like
> a) issuing additional instructions to read and modify; or b) scan the
> golden context and patch it in place before saving it; or something
> else. But for now this should suffice.
>
> Scanning the context workarounds for all platforms, these are the
> impacted ones with the respective registers
>
> mtl: DRAW_WATERMARK
> mtl/dg2: XEHP_L3SQCREG5, XEHP_FF_MODE2
>
> ICL has some non-masked registers in the context workarounds:
> GEN8_L3CNTLREG, IVB_FBC_RT_BASE and VB_FBC_RT_BASE_UPPER, but there
> shouldn't be an impact. The first is already being manually read and the
> other 2 are intentionally overwriting the entire register. Same
> reasoning applies to GEN12_FF_MODE2: the WA is intentionally
> overwriting all the bits to avoid a read-modify-write.
>
> v2: Reword commit message wrt GEN12_FF_MODE2 and the changed behavior
> on preparatory patches.
>
> Cc: Kenneth Graunke <kenneth@whitecape.org>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23783#note_1968971
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 27 ++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 7d48bd57b6ef..9291c2b4ca0e 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -986,6 +986,9 @@ void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
> int intel_engine_emit_ctx_wa(struct i915_request *rq)
> {
> struct i915_wa_list *wal = &rq->engine->ctx_wa_list;
> + struct intel_uncore *uncore = rq->engine->uncore;
> + enum forcewake_domains fw;
> + unsigned long flags;
> struct i915_wa *wa;
> unsigned int i;
> u32 *cs;
> @@ -1002,13 +1005,35 @@ int intel_engine_emit_ctx_wa(struct i915_request *rq)
> if (IS_ERR(cs))
> return PTR_ERR(cs);
>
> + fw = wal_get_fw_for_rmw(uncore, wal);
> +
> + intel_gt_mcr_lock(wal->gt, &flags);
> + spin_lock(&uncore->lock);
> + intel_uncore_forcewake_get__locked(uncore, fw);
> +
> *cs++ = MI_LOAD_REGISTER_IMM(wal->count);
> for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
> + u32 val;
> +
> + if (wa->masked_reg || wa->set == U32_MAX) {
I think you still want:
if (wa->masked_reg || wa->set == U32_MAX || wa->clr == U32_MAX) {
since there's no point to doing a read just to mask off 100% of the
values. Harmless, of course, but unnecessary.
Either way, patches 1-5 are:
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
> + val = wa->set;
> + } else {
> + val = wa->is_mcr ?
> + intel_gt_mcr_read_any_fw(wal->gt, wa->mcr_reg) :
> + intel_uncore_read_fw(uncore, wa->reg);
> + val &= ~wa->clr;
> + val |= wa->set;
> + }
> +
> *cs++ = i915_mmio_reg_offset(wa->reg);
> - *cs++ = wa->set;
> + *cs++ = val;
> }
> *cs++ = MI_NOOP;
>
> + intel_uncore_forcewake_put__locked(uncore, fw);
> + spin_unlock(&uncore->lock);
> + intel_gt_mcr_unlock(wal->gt, flags);
> +
> intel_ring_advance(rq, cs);
>
> ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER
2023-06-27 18:30 ` Kenneth Graunke
@ 2023-06-28 4:02 ` Lucas De Marchi
0 siblings, 0 replies; 15+ messages in thread
From: Lucas De Marchi @ 2023-06-28 4:02 UTC (permalink / raw)
To: Kenneth Graunke; +Cc: intel-gfx, Matt Roper, dri-devel
On Tue, Jun 27, 2023 at 11:30:26AM -0700, Kenneth Graunke wrote:
>On Saturday, June 24, 2023 10:17:57 AM PDT Lucas De Marchi wrote:
>> The comment on the parameter being 0 to avoid the read back doesn't
>> apply as this is not a call to wa_mcr_add(), but rather to
>> wa_mcr_clr_set(). So, this register is actually checked and it's
>> according to the Bspec that the register is RW, not RO.
>
>I think you mean wa_add and wa_write_clr_set here (not mcr).
>
>One thing I've been confused about while reading this code:
>
>static void
>wa_write_clr_set(struct i915_wa_list *wal, i915_reg_t reg, u32 clear, u32 set)
>{
> wa_add(wal, reg, clear, set, clear, false);
>}
>
>The second to last parameter is read_mask aka wa->read. We're
>initializing it to the...bits to clear. (I would think it should be
>(clear | set) to pick up all modified bits.)
>
>wa_verify seems to balk at ((cur ^ wa->set) & wa->read). But...if
>wa->read is just the clear mask, that wouldn't actually verify that
>any bits were set at all. Or am I misunderstanding something?
>
>If not, we may be failing to verify the majority of our workarounds :(
I can see it failing in some cases, but it should pass in the majority.
I think there's an issue when the clr bits are not a super set of the
set bits. For example, this works:
clr=0xf, set=1
This is what happens when we are setting a field. However it would fail
to verify for cases in which we have, .e.g
clr=0x1, set=0, i.e. we are just clearing one bit. Since wa->read in
this case would be 0, it wouldn't matter if cur is 0 or 1. It seems like
commit eeec73f8a4a4 ("drm/i915/gt: Skip rmw for masked registers")
is the one who broke it. Setting read_mask to set | clr seems to
suffice as then we would get any inconsistencies between what was read
from the bits that should be set.
thanks
Lucas De Marchi
>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index 848519b58e45..5fe85fad91c1 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -666,7 +666,7 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
>> /* Wa_1604278689:icl,ehl */
>> wa_write(wal, IVB_FBC_RT_BASE, 0xFFFFFFFF & ~ILK_FBC_RT_VALID);
>> wa_write_clr_set(wal, IVB_FBC_RT_BASE_UPPER,
>> - 0, /* write-only register; skip validation */
>> + 0,
>> 0xFFFFFFFF);
>>
>> /* Wa_1406306137:icl,ehl */
>
>In this particular example, since clear bits are 0, I don't think any
>verification is happening at all.
>
>--Ken
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for Fix ctx workarounds for non-masked regs (rev2)
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
` (6 preceding siblings ...)
2023-06-25 6:42 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Fix ctx workarounds for non-masked regs Patchwork
@ 2023-06-29 3:42 ` Patchwork
2023-06-29 8:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-29 16:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-06-29 3:42 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: Fix ctx workarounds for non-masked regs (rev2)
URL : https://patchwork.freedesktop.org/series/119826/
State : warning
== Summary ==
Error: patch https://patchwork.freedesktop.org/api/1.0/series/119826/revisions/2/mbox/ not found
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Fix ctx workarounds for non-masked regs (rev2)
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
` (7 preceding siblings ...)
2023-06-29 3:42 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Fix ctx workarounds for non-masked regs (rev2) Patchwork
@ 2023-06-29 8:46 ` Patchwork
2023-06-29 16:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-06-29 8:46 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9334 bytes --]
== Series Details ==
Series: Fix ctx workarounds for non-masked regs (rev2)
URL : https://patchwork.freedesktop.org/series/119826/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13332 -> Patchwork_119826v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/index.html
Participating hosts (39 -> 40)
------------------------------
Additional (2): fi-kbl-soraka fi-pnv-d510
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_119826v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- bat-adlp-11: [PASS][1] -> [ABORT][2] ([i915#8011])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-adlp-11/igt@core_auth@basic-auth.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-adlp-11/igt@core_auth@basic-auth.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_module_load@load:
- bat-adlp-11: [PASS][5] -> [DMESG-WARN][6] ([i915#4423])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-adlp-11/igt@i915_module_load@load.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][7] -> [DMESG-FAIL][8] ([i915#5334])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886] / [i915#7913])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][10] -> [DMESG-FAIL][11] ([i915#8497])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-mtlp-8/igt@i915_selftest@live@requests.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [PASS][12] -> [DMESG-WARN][13] ([i915#6367])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-rpls-2/igt@i915_selftest@live@slpc.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-rpls-2/igt@i915_selftest@live@slpc.html
- bat-mtlp-8: [PASS][14] -> [DMESG-WARN][15] ([i915#6367])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-mtlp-8/igt@i915_selftest@live@slpc.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-mtlp-8/igt@i915_selftest@live@slpc.html
- bat-rpls-1: NOTRUN -> [DMESG-WARN][16] ([i915#6367])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-rkl-11600: [PASS][17] -> [FAIL][18] ([fdo#103375])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/fi-rkl-11600/igt@i915_suspend@basic-s2idle-without-i915.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-rkl-11600/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][19] ([i915#6687] / [i915#7978])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-kbl-soraka: NOTRUN -> [SKIP][20] ([fdo#109271]) +14 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-kbl-soraka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][21] ([fdo#109271]) +37 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
- bat-rplp-1: NOTRUN -> [SKIP][22] ([i915#1072]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-rplp-1/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: NOTRUN -> [ABORT][23] ([i915#8442] / [i915#8712])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4579])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
- fi-pnv-d510: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4579])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/fi-pnv-d510/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][26] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-rpls-1/igt@i915_selftest@live@reset.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][28] ([i915#8442]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-3:
- bat-dg2-11: [INCOMPLETE][30] ([i915#7908]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-3.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-3.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7908]: https://gitlab.freedesktop.org/drm/intel/issues/7908
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8712]: https://gitlab.freedesktop.org/drm/intel/issues/8712
Build changes
-------------
* Linux: CI_DRM_13332 -> Patchwork_119826v2
CI-20190529: 20190529
CI_DRM_13332: 4d3f8cad525121f0d34faf4a63d6cb37e1a7039c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7354: 07fe9ec40f779a788946ad371b0b683cab3c2536 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119826v2: 4d3f8cad525121f0d34faf4a63d6cb37e1a7039c @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
4157218c4282 drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER
84e957b6777b drm/i915/gt: Enable read back on XEHP_FF_MODE2
08968858b37c drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround
6e4bb378e984 drm/i915/gt: Fix context workarounds with non-masked regs
79ad3aee5580 drm/i915/gt: Clear all bits from GEN12_FF_MODE2
9f296573d108 drm/i915/gt: Move wal_get_fw_for_rmw()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/index.html
[-- Attachment #2: Type: text/html, Size: 11057 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Fix ctx workarounds for non-masked regs (rev2)
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
` (8 preceding siblings ...)
2023-06-29 8:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-06-29 16:56 ` Patchwork
9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2023-06-29 16:56 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 34592 bytes --]
== Series Details ==
Series: Fix ctx workarounds for non-masked regs (rev2)
URL : https://patchwork.freedesktop.org/series/119826/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13332_full -> Patchwork_119826v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_119826v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_119826v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_119826v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_crc@cursor-sliding-128x42@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-9/igt@kms_cursor_crc@cursor-sliding-128x42@pipe-a-dp-4.html
Known issues
------------
Here are the changes found in Patchwork_119826v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [PASS][2] -> [FAIL][3] ([i915#7742])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_caching@writes:
- shard-mtlp: NOTRUN -> [SKIP][4] ([i915#4873])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_caching@writes.html
* igt@gem_exec_params@secure-non-master:
- shard-mtlp: NOTRUN -> [SKIP][5] ([fdo#112283])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_exec_params@secure-non-master.html
* igt@gem_exec_reloc@basic-wc-read:
- shard-mtlp: NOTRUN -> [SKIP][6] ([i915#3281])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_exec_reloc@basic-wc-read.html
* igt@gem_exec_schedule@deep@vcs1:
- shard-mtlp: [PASS][7] -> [FAIL][8] ([i915#8606])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-6/igt@gem_exec_schedule@deep@vcs1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_exec_schedule@deep@vcs1.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-mtlp: [PASS][9] -> [FAIL][10] ([i915#6363]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-8/igt@gem_exec_whisper@basic-queues-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-5/igt@gem_exec_whisper@basic-queues-all.html
* igt@gem_fenced_exec_thrash@no-spare-fences:
- shard-mtlp: NOTRUN -> [SKIP][11] ([i915#4860])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_fenced_exec_thrash@no-spare-fences.html
* igt@gem_gtt_cpu_tlb:
- shard-mtlp: NOTRUN -> [SKIP][12] ([i915#4077]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_gtt_cpu_tlb.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [PASS][13] -> [TIMEOUT][14] ([i915#5493])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-1/igt@gem_lmem_swapping@smem-oom@lmem0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-11/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_mmap_wc@copy:
- shard-mtlp: NOTRUN -> [SKIP][15] ([i915#4083])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-2/igt@gem_mmap_wc@copy.html
* igt@gem_render_copy@linear-to-vebox-yf-tiled:
- shard-mtlp: NOTRUN -> [SKIP][16] ([i915#8428])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-6/igt@gem_render_copy@linear-to-vebox-yf-tiled.html
* igt@gem_softpin@evict-snoop:
- shard-mtlp: NOTRUN -> [SKIP][17] ([i915#4885])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_softpin@evict-snoop.html
* igt@gem_userptr_blits@forbidden-operations:
- shard-mtlp: NOTRUN -> [SKIP][18] ([i915#3282])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_userptr_blits@forbidden-operations.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-mtlp: NOTRUN -> [SKIP][19] ([i915#3297]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-2/igt@gem_userptr_blits@unsync-overlap.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][20] -> [ABORT][21] ([i915#5566])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-glk4/igt@gen9_exec_parse@allowed-single.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-glk3/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [PASS][22] -> [SKIP][23] ([i915#1397]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-rkl-1/igt@i915_pm_rpm@dpms-non-lpsp.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rps@min-max-config-idle:
- shard-mtlp: NOTRUN -> [SKIP][24] ([i915#6621])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@i915_pm_rps@min-max-config-idle.html
* igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
- shard-mtlp: NOTRUN -> [SKIP][25] ([i915#4212])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs:
- shard-rkl: NOTRUN -> [SKIP][26] ([i915#8502]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-4/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-mtlp: [PASS][27] -> [FAIL][28] ([i915#3743])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-mtlp: NOTRUN -> [SKIP][29] ([fdo#111615]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs:
- shard-mtlp: NOTRUN -> [SKIP][30] ([i915#6095]) +6 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition@pipe-a-dp-4:
- shard-dg2: [PASS][31] -> [SKIP][32] ([i915#4087]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-9/igt@kms_cdclk@mode-transition@pipe-a-dp-4.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-11/igt@kms_cdclk@mode-transition@pipe-a-dp-4.html
* igt@kms_cdclk@mode-transition@pipe-d-dp-4:
- shard-dg2: [PASS][33] -> [SKIP][34] ([i915#4087] / [i915#4579])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-9/igt@kms_cdclk@mode-transition@pipe-d-dp-4.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-11/igt@kms_cdclk@mode-transition@pipe-d-dp-4.html
* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-mtlp: NOTRUN -> [SKIP][35] ([i915#7828]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@kms_chamelium_hpd@vga-hpd-fast.html
* igt@kms_content_protection@legacy:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#4579] / [i915#7118])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-7/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-mtlp: NOTRUN -> [SKIP][37] ([i915#4579]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-2/igt@kms_cursor_crc@cursor-sliding-32x32.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-mtlp: NOTRUN -> [SKIP][38] ([fdo#111767] / [i915#3546])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][39] -> [FAIL][40] ([i915#2346])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-glk7/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][42] -> [ABORT][43] ([i915#180])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-dg2: [PASS][44] -> [FAIL][45] ([i915#6880]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-mtlp: NOTRUN -> [SKIP][46] ([i915#1825]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-dg2: [PASS][47] -> [FAIL][48] ([fdo#103375]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-pri-indfb-multidraw:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-apl6/igt@kms_frontbuffer_tracking@fbcpsr-2p-pri-indfb-multidraw.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-rkl: NOTRUN -> [SKIP][50] ([i915#3555] / [i915#4579])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-2/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][51] ([i915#5176]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-5/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-3.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#4579] / [i915#5176])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-5/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-hdmi-a-3.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#4579]) +11 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-snb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][54] ([fdo#109271]) +15 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-snb6/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-c-dp-2:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#5235]) +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-12/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-c-dp-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][56] ([i915#5235]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-7/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][57] ([i915#4579] / [i915#5235]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][58] ([i915#4579] / [i915#5235]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-7/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-hdmi-a-3.html
* igt@kms_prime@d3hot:
- shard-mtlp: NOTRUN -> [SKIP][59] ([i915#6524])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-6/igt@kms_prime@d3hot.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [PASS][60] -> [FAIL][61] ([i915#7484])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-10/igt@perf@non-zero-reason@0-rcs0.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-10/igt@perf@non-zero-reason@0-rcs0.html
* igt@perf@stress-open-close@0-rcs0:
- shard-glk: [PASS][62] -> [ABORT][63] ([i915#5213] / [i915#7941])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-glk4/igt@perf@stress-open-close@0-rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-glk6/igt@perf@stress-open-close@0-rcs0.html
* igt@v3d/v3d_perfmon@create-perfmon-invalid-counters:
- shard-mtlp: NOTRUN -> [SKIP][64] ([i915#2575]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-5/igt@v3d/v3d_perfmon@create-perfmon-invalid-counters.html
* igt@vc4/vc4_purgeable_bo@access-purged-bo-mem:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#7711]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-2/igt@vc4/vc4_purgeable_bo@access-purged-bo-mem.html
#### Possible fixes ####
* igt@gem_ctx_persistence@many-contexts:
- shard-mtlp: [DMESG-WARN][66] ([i915#8634]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-2/igt@gem_ctx_persistence@many-contexts.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-2/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [FAIL][68] ([i915#2842]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][70] ([i915#2842]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-apl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [FAIL][72] ([i915#2842]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_schedule@deep@vecs0:
- shard-mtlp: [TIMEOUT][74] ([i915#8740]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-6/igt@gem_exec_schedule@deep@vecs0.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@gem_exec_schedule@deep@vecs0.html
* igt@gem_exec_whisper@basic-fds-all:
- shard-mtlp: [FAIL][76] ([i915#6363]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-6/igt@gem_exec_whisper@basic-fds-all.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-4/igt@gem_exec_whisper@basic-fds-all.html
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-snb: [INCOMPLETE][78] ([i915#8295]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctx0.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-snb4/igt@gem_ppgtt@blt-vs-render-ctx0.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [ABORT][80] ([i915#180]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_dc@dc9-dpms:
- shard-tglu: [SKIP][82] ([i915#4281]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-tglu-7/igt@i915_pm_dc@dc9-dpms.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html
* {igt@i915_pm_freq_api@freq-suspend@gt0}:
- shard-dg2: [FAIL][84] ([fdo#103375]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-5/igt@i915_pm_freq_api@freq-suspend@gt0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-6/igt@i915_pm_freq_api@freq-suspend@gt0.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][86] ([i915#3591]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg1-13/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: [SKIP][88] ([i915#1397]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-4/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_selftest@live@requests:
- shard-mtlp: [DMESG-FAIL][90] ([i915#8497]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-8/igt@i915_selftest@live@requests.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-1/igt@i915_selftest@live@requests.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-mtlp: [FAIL][92] ([i915#5138]) -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-7/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-4/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-mtlp: [FAIL][94] ([i915#3743]) -> [PASS][95] +2 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-rkl: [FAIL][96] ([i915#3743]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_cursor_edge_walk@256x256-right-edge@pipe-a-hdmi-a-1:
- shard-glk: [DMESG-FAIL][98] ([i915#118]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-glk8/igt@kms_cursor_edge_walk@256x256-right-edge@pipe-a-hdmi-a-1.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-glk7/igt@kms_cursor_edge_walk@256x256-right-edge@pipe-a-hdmi-a-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][100] ([i915#2346]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-mtlp: [FAIL][102] ([i915#4767]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-4/igt@kms_fbcon_fbt@psr-suspend.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-3/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [FAIL][104] ([i915#79]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-dg2: [FAIL][106] ([i915#6880]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-7/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-dp-4:
- shard-dg2: [SKIP][108] ([i915#5235]) -> [PASS][109] +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-9/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-dp-4.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-11/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-dp-4.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-dp-4:
- shard-dg2: [SKIP][110] ([i915#4579] / [i915#5235]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-9/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-dp-4.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-11/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-dp-4.html
* igt@syncobj_wait@multi-wait-for-submit-unsubmitted:
- shard-mtlp: [TIMEOUT][112] -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-6/igt@syncobj_wait@multi-wait-for-submit-unsubmitted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-8/igt@syncobj_wait@multi-wait-for-submit-unsubmitted.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- shard-tglu: [WARN][114] ([i915#2681]) -> [FAIL][115] ([i915#2681] / [i915#3591])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-tglu-5/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-tglu-7/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
* igt@kms_async_flips@crc@pipe-d-edp-1:
- shard-mtlp: [DMESG-FAIL][116] ([i915#8561]) -> [FAIL][117] ([i915#8247])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-mtlp-7/igt@kms_async_flips@crc@pipe-d-edp-1.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-mtlp-4/igt@kms_async_flips@crc@pipe-d-edp-1.html
* igt@kms_content_protection@content_type_change:
- shard-dg2: [SKIP][118] ([i915#4579] / [i915#7118] / [i915#7162]) -> [SKIP][119] ([i915#4579] / [i915#7118])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-11/igt@kms_content_protection@content_type_change.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-7/igt@kms_content_protection@content_type_change.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][120] ([i915#3955]) -> [SKIP][121] ([fdo#110189] / [i915#3955])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-rkl-2/igt@kms_fbcon_fbt@psr.html
* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [CRASH][122] ([i915#7331]) -> [INCOMPLETE][123] ([i915#5493])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13332/shard-dg2-11/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/shard-dg2-7/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6363]: https://gitlab.freedesktop.org/drm/intel/issues/6363
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
[i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561
[i915#8606]: https://gitlab.freedesktop.org/drm/intel/issues/8606
[i915#8634]: https://gitlab.freedesktop.org/drm/intel/issues/8634
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8740]: https://gitlab.freedesktop.org/drm/intel/issues/8740
Build changes
-------------
* Linux: CI_DRM_13332 -> Patchwork_119826v2
CI-20190529: 20190529
CI_DRM_13332: 4d3f8cad525121f0d34faf4a63d6cb37e1a7039c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7354: 07fe9ec40f779a788946ad371b0b683cab3c2536 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119826v2: 4d3f8cad525121f0d34faf4a63d6cb37e1a7039c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119826v2/index.html
[-- Attachment #2: Type: text/html, Size: 37244 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2023-06-29 16:56 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-24 17:17 [Intel-gfx] [PATCH v2 0/6] Fix ctx workarounds for non-masked regs Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 1/6] drm/i915/gt: Move wal_get_fw_for_rmw() Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/gt: Clear all bits from GEN12_FF_MODE2 Lucas De Marchi
2023-06-25 18:39 ` Matt Roper
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs Lucas De Marchi
2023-06-27 18:32 ` Kenneth Graunke
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 4/6] drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 5/6] drm/i915/gt: Enable read back on XEHP_FF_MODE2 Lucas De Marchi
2023-06-24 17:17 ` [Intel-gfx] [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER Lucas De Marchi
2023-06-27 18:30 ` Kenneth Graunke
2023-06-28 4:02 ` Lucas De Marchi
2023-06-25 6:42 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Fix ctx workarounds for non-masked regs Patchwork
2023-06-29 3:42 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Fix ctx workarounds for non-masked regs (rev2) Patchwork
2023-06-29 8:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-29 16:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox