* [Intel-gfx] [PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 [Intel-gfx] [PATCH 0/2] Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout() Nathan Chancellor
@ 2023-07-18 21:44 ` Nathan Chancellor
2023-07-21 18:36 ` Nick Desaulniers
2023-07-27 14:01 ` Maira Canal
2023-07-18 21:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: " Nathan Chancellor
` (3 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Nathan Chancellor @ 2023-07-18 21:44 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin, emma,
mwen
Cc: trix, intel-gfx, llvm, ndesaulniers, patches, dri-devel,
Nathan Chancellor, justinstitt
A proposed update to clang's -Wconstant-logical-operand to warn when the
left hand side is a constant shows the following instance in
nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
such as CONFIG_HZ=300:
In file included from drivers/gpu/drm/v3d/v3d_debugfs.c:12:
drivers/gpu/drm/v3d/v3d_drv.h:343:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
343 | if (NSEC_PER_SEC % HZ &&
| ~~~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: use '&' for a bitwise operation
343 | if (NSEC_PER_SEC % HZ &&
| ^~
| &
drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: remove constant to silence this warning
1 warning generated.
Turn this into an explicit comparison against zero to make the
expression a boolean to make it clear this should be a logical check,
not a bitwise one.
Link: https://reviews.llvm.org/D142609
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h
index b74b1351bfc8..7f664a4b2a75 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.h
+++ b/drivers/gpu/drm/v3d/v3d_drv.h
@@ -340,7 +340,7 @@ struct v3d_submit_ext {
static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
{
/* nsecs_to_jiffies64() does not guard against overflow */
- if (NSEC_PER_SEC % HZ &&
+ if ((NSEC_PER_SEC % HZ) != 0 &&
div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ)
return MAX_JIFFY_OFFSET;
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 ` [Intel-gfx] [PATCH 1/2] drm/v3d: " Nathan Chancellor
@ 2023-07-21 18:36 ` Nick Desaulniers
2023-07-27 14:01 ` Maira Canal
1 sibling, 0 replies; 11+ messages in thread
From: Nick Desaulniers @ 2023-07-21 18:36 UTC (permalink / raw)
To: Nathan Chancellor
Cc: justinstitt, emma, trix, intel-gfx, llvm, patches, mwen,
dri-devel, rodrigo.vivi
On Tue, Jul 18, 2023 at 2:44 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> A proposed update to clang's -Wconstant-logical-operand to warn when the
> left hand side is a constant shows the following instance in
> nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
> such as CONFIG_HZ=300:
>
> In file included from drivers/gpu/drm/v3d/v3d_debugfs.c:12:
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> 343 | if (NSEC_PER_SEC % HZ &&
> | ~~~~~~~~~~~~~~~~~ ^
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: use '&' for a bitwise operation
> 343 | if (NSEC_PER_SEC % HZ &&
> | ^~
> | &
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: remove constant to silence this warning
> 1 warning generated.
>
> Turn this into an explicit comparison against zero to make the
> expression a boolean to make it clear this should be a logical check,
> not a bitwise one.
>
> Link: https://reviews.llvm.org/D142609
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h
> index b74b1351bfc8..7f664a4b2a75 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.h
> +++ b/drivers/gpu/drm/v3d/v3d_drv.h
> @@ -340,7 +340,7 @@ struct v3d_submit_ext {
> static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
> {
> /* nsecs_to_jiffies64() does not guard against overflow */
> - if (NSEC_PER_SEC % HZ &&
> + if ((NSEC_PER_SEC % HZ) != 0 &&
> div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ)
> return MAX_JIFFY_OFFSET;
>
>
> --
> 2.41.0
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 ` [Intel-gfx] [PATCH 1/2] drm/v3d: " Nathan Chancellor
2023-07-21 18:36 ` Nick Desaulniers
@ 2023-07-27 14:01 ` Maira Canal
2023-07-27 14:41 ` Nathan Chancellor
1 sibling, 1 reply; 11+ messages in thread
From: Maira Canal @ 2023-07-27 14:01 UTC (permalink / raw)
To: Nathan Chancellor, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, emma, mwen
Cc: trix, intel-gfx, llvm, ndesaulniers, patches, dri-devel,
justinstitt
Hi Nathan,
On 7/18/23 18:44, Nathan Chancellor wrote:
> A proposed update to clang's -Wconstant-logical-operand to warn when the
> left hand side is a constant shows the following instance in
> nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
> such as CONFIG_HZ=300:
>
> In file included from drivers/gpu/drm/v3d/v3d_debugfs.c:12:
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> 343 | if (NSEC_PER_SEC % HZ &&
> | ~~~~~~~~~~~~~~~~~ ^
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: use '&' for a bitwise operation
> 343 | if (NSEC_PER_SEC % HZ &&
> | ^~
> | &
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: remove constant to silence this warning
> 1 warning generated.
>
> Turn this into an explicit comparison against zero to make the
> expression a boolean to make it clear this should be a logical check,
> not a bitwise one.
>
> Link: https://reviews.llvm.org/D142609
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Thanks for all the hard work with clang! Let me know if you need someone
to push it to drm-misc-next.
Best Regards,
- Maíra
> ---
> drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h
> index b74b1351bfc8..7f664a4b2a75 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.h
> +++ b/drivers/gpu/drm/v3d/v3d_drv.h
> @@ -340,7 +340,7 @@ struct v3d_submit_ext {
> static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
> {
> /* nsecs_to_jiffies64() does not guard against overflow */
> - if (NSEC_PER_SEC % HZ &&
> + if ((NSEC_PER_SEC % HZ) != 0 &&
> div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ)
> return MAX_JIFFY_OFFSET;
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-27 14:01 ` Maira Canal
@ 2023-07-27 14:41 ` Nathan Chancellor
0 siblings, 0 replies; 11+ messages in thread
From: Nathan Chancellor @ 2023-07-27 14:41 UTC (permalink / raw)
To: Maira Canal
Cc: justinstitt, llvm, emma, trix, intel-gfx, ndesaulniers, patches,
mwen, dri-devel, rodrigo.vivi
Hi Maira,
On Thu, Jul 27, 2023 at 11:01:27AM -0300, Maira Canal wrote:
> Hi Nathan,
>
> On 7/18/23 18:44, Nathan Chancellor wrote:
> > A proposed update to clang's -Wconstant-logical-operand to warn when the
> > left hand side is a constant shows the following instance in
> > nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
> > such as CONFIG_HZ=300:
> >
> > In file included from drivers/gpu/drm/v3d/v3d_debugfs.c:12:
> > drivers/gpu/drm/v3d/v3d_drv.h:343:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> > 343 | if (NSEC_PER_SEC % HZ &&
> > | ~~~~~~~~~~~~~~~~~ ^
> > drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: use '&' for a bitwise operation
> > 343 | if (NSEC_PER_SEC % HZ &&
> > | ^~
> > | &
> > drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: remove constant to silence this warning
> > 1 warning generated.
> >
> > Turn this into an explicit comparison against zero to make the
> > expression a boolean to make it clear this should be a logical check,
> > not a bitwise one.
> >
> > Link: https://reviews.llvm.org/D142609
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Reviewed-by: Maíra Canal <mcanal@igalia.com>
>
> Thanks for all the hard work with clang! Let me know if you need someone
> to push it to drm-misc-next.
Yes I will, I do not have drm commit rights. I think the i915 patch can
go to drm-misc as well with Tvrtko's ack. Thanks a lot for taking a
look!
Cheers,
Nathan
> Best Regards,
> - Maíra
>
> > ---
> > drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h
> > index b74b1351bfc8..7f664a4b2a75 100644
> > --- a/drivers/gpu/drm/v3d/v3d_drv.h
> > +++ b/drivers/gpu/drm/v3d/v3d_drv.h
> > @@ -340,7 +340,7 @@ struct v3d_submit_ext {
> > static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
> > {
> > /* nsecs_to_jiffies64() does not guard against overflow */
> > - if (NSEC_PER_SEC % HZ &&
> > + if ((NSEC_PER_SEC % HZ) != 0 &&
> > div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ)
> > return MAX_JIFFY_OFFSET;
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 [Intel-gfx] [PATCH 0/2] Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout() Nathan Chancellor
2023-07-18 21:44 ` [Intel-gfx] [PATCH 1/2] drm/v3d: " Nathan Chancellor
@ 2023-07-18 21:44 ` Nathan Chancellor
2023-07-20 8:43 ` Tvrtko Ursulin
2023-07-18 23:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Nathan Chancellor @ 2023-07-18 21:44 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin, emma,
mwen
Cc: trix, intel-gfx, llvm, ndesaulniers, patches, dri-devel,
Nathan Chancellor, justinstitt
A proposed update to clang's -Wconstant-logical-operand to warn when the
left hand side is a constant shows the following instance in
nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
such as CONFIG_HZ=300:
drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
189 | if (NSEC_PER_SEC % HZ &&
| ~~~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: use '&' for a bitwise operation
189 | if (NSEC_PER_SEC % HZ &&
| ^~
| &
drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: remove constant to silence this warning
1 warning generated.
Turn this into an explicit comparison against zero to make the
expression a boolean to make it clear this should be a logical check,
not a bitwise one.
Link: https://reviews.llvm.org/D142609
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
index 4a33ad2d122b..d4b918fb11ce 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
@@ -186,7 +186,7 @@ i915_gem_object_wait(struct drm_i915_gem_object *obj,
static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
{
/* nsecs_to_jiffies64() does not guard against overflow */
- if (NSEC_PER_SEC % HZ &&
+ if ((NSEC_PER_SEC % HZ) != 0 &&
div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ)
return MAX_JIFFY_OFFSET;
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: " Nathan Chancellor
@ 2023-07-20 8:43 ` Tvrtko Ursulin
2023-07-20 15:16 ` Nathan Chancellor
0 siblings, 1 reply; 11+ messages in thread
From: Tvrtko Ursulin @ 2023-07-20 8:43 UTC (permalink / raw)
To: Nathan Chancellor, jani.nikula, joonas.lahtinen, rodrigo.vivi,
emma, mwen
Cc: trix, intel-gfx, llvm, ndesaulniers, patches, dri-devel,
justinstitt
On 18/07/2023 22:44, Nathan Chancellor wrote:
> A proposed update to clang's -Wconstant-logical-operand to warn when the
> left hand side is a constant shows the following instance in
> nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
> such as CONFIG_HZ=300:
>
> drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> 189 | if (NSEC_PER_SEC % HZ &&
> | ~~~~~~~~~~~~~~~~~ ^
> drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: use '&' for a bitwise operation
> 189 | if (NSEC_PER_SEC % HZ &&
> | ^~
> | &
> drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: remove constant to silence this warning
> 1 warning generated.
>
> Turn this into an explicit comparison against zero to make the
> expression a boolean to make it clear this should be a logical check,
> not a bitwise one.
So -Wconstant-logical-operand only triggers when it is a constant but
not zero constant? Why does that make sense is not a kludge to avoid too
much noise?
Personally, it all feels a bit over the top as a warning, since code in
both cases should optimise away. And we may end up papering over it if
it becomes a default.
Then again this patch IMO does make the code more readable, so I am
happy to take this one via our tree. Or either give ack to bring it in
via drm-misc-next:
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Let me know which route works best.
Regards,
Tvrtko
> Link: https://reviews.llvm.org/D142609
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 4a33ad2d122b..d4b918fb11ce 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -186,7 +186,7 @@ i915_gem_object_wait(struct drm_i915_gem_object *obj,
> static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
> {
> /* nsecs_to_jiffies64() does not guard against overflow */
> - if (NSEC_PER_SEC % HZ &&
> + if ((NSEC_PER_SEC % HZ) != 0 &&
> div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ)
> return MAX_JIFFY_OFFSET;
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-20 8:43 ` Tvrtko Ursulin
@ 2023-07-20 15:16 ` Nathan Chancellor
0 siblings, 0 replies; 11+ messages in thread
From: Nathan Chancellor @ 2023-07-20 15:16 UTC (permalink / raw)
To: Tvrtko Ursulin
Cc: justinstitt, emma, trix, intel-gfx, ndesaulniers, patches, mwen,
dri-devel, llvm, rodrigo.vivi
On Thu, Jul 20, 2023 at 09:43:05AM +0100, Tvrtko Ursulin wrote:
>
> On 18/07/2023 22:44, Nathan Chancellor wrote:
> > A proposed update to clang's -Wconstant-logical-operand to warn when the
> > left hand side is a constant shows the following instance in
> > nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
> > such as CONFIG_HZ=300:
> >
> > drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> > 189 | if (NSEC_PER_SEC % HZ &&
> > | ~~~~~~~~~~~~~~~~~ ^
> > drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: use '&' for a bitwise operation
> > 189 | if (NSEC_PER_SEC % HZ &&
> > | ^~
> > | &
> > drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: remove constant to silence this warning
> > 1 warning generated.
> >
> > Turn this into an explicit comparison against zero to make the
> > expression a boolean to make it clear this should be a logical check,
> > not a bitwise one.
>
> So -Wconstant-logical-operand only triggers when it is a
> constant but not zero constant? Why does that make sense is not
> a kludge to avoid too much noise?
Yes, the warning purposefully does not trigger when the constant is a 1
or 0 (as those are usually indicative of an intentional logical
operation):
https://github.com/llvm/llvm-project/blob/dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976/clang/lib/Sema/SemaExpr.cpp#L13917-L13919
In this case, it is 100, so I kind of understand why this might be
ambiguous to the compiler.
> Personally, it all feels a bit over the top as a warning,
> since code in both cases should optimise away. And we may end
I do not necessarily disagree, as you can see from the differential
review that I linked in the message, but I also understand it is a fine
line to tread when writing compiler warnings between wanting to catch
as many potential problems as possible and having too much noise for
developers to sift through. I think this is erring on the side of
caution.
> up papering over it if it becomes a default.
diagtool tree tells me this warning is already on by default.
> Then again this patch IMO does make the code more readable, so
I think so too.
> I am happy to take this one via our tree. Or either give ack to
> bring it in via drm-misc-next:
>
> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Let me know which route works best.
Thanks for the feedback! Either route is fine with me but if the v3d
patch is going to go in via drm-misc-next, it seems like it would not be
too much trouble to push this one with it.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 [Intel-gfx] [PATCH 0/2] Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout() Nathan Chancellor
2023-07-18 21:44 ` [Intel-gfx] [PATCH 1/2] drm/v3d: " Nathan Chancellor
2023-07-18 21:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: " Nathan Chancellor
@ 2023-07-18 23:25 ` Patchwork
2023-07-19 0:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-07-27 16:08 ` [Intel-gfx] [PATCH 0/2] " Maira Canal
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-07-18 23:25 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10538 bytes --]
== Series Details ==
Series: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
URL : https://patchwork.freedesktop.org/series/120940/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394 -> Patchwork_120940v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/index.html
Participating hosts (44 -> 43)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_120940v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@debugfs_test@read_all_entries:
- {bat-dg2-13}: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-dg2-13/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-dg2-13/igt@debugfs_test@read_all_entries.html
Known issues
------------
Here are the changes found in Patchwork_120940v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-adlp-11: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-adlp-11/igt@debugfs_test@basic-hwmon.html
* igt@gem_tiled_pread_basic:
- bat-adlp-11: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-adlp-11/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-8: [PASS][5] -> [DMESG-FAIL][6] ([i915#7059])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][7] -> [ABORT][8] ([i915#4983] / [i915#7911] / [i915#7920])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-rpls-1/igt@i915_selftest@live@requests.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][9] ([i915#6367])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [PASS][10] -> [DMESG-FAIL][11] ([i915#6763])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][12] ([i915#6687] / [i915#7978] / [i915#8668])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-rpls-2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- bat-adlp-11: NOTRUN -> [SKIP][13] ([i915#7828]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-adlp-11/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-bsw-n3050: NOTRUN -> [SKIP][14] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/fi-bsw-n3050/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-11: NOTRUN -> [SKIP][15] ([i915#4103]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-adlp-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-11: NOTRUN -> [SKIP][16] ([i915#4093]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-adlp-11/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-11: NOTRUN -> [ABORT][17] ([i915#4423])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-adlp-11/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@primary_page_flip:
- bat-rplp-1: NOTRUN -> [ABORT][18] ([i915#8860])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-rplp-1/igt@kms_psr@primary_page_flip.html
#### Possible fixes ####
* igt@i915_module_load@load:
- bat-adlp-11: [ABORT][19] ([i915#4423]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-adlp-11/igt@i915_module_load@load.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-x1275: [SKIP][21] ([fdo#109271]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-tgl-1115g4: [FAIL][23] ([i915#7940]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/fi-tgl-1115g4/igt@i915_pm_rpm@basic-rte.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/fi-tgl-1115g4/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [ABORT][25] ([i915#7911] / [i915#7913]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][27] ([i915#5334] / [i915#7872]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][29] ([i915#7699]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-dg2-11/igt@i915_selftest@live@migrate.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [DMESG-FAIL][31] ([i915#8497]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-mtlp-8/igt@i915_selftest@live@requests.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][33] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-rpls-2/igt@i915_selftest@live@reset.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][35] ([i915#8442] / [i915#8668]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8860]: https://gitlab.freedesktop.org/drm/intel/issues/8860
Build changes
-------------
* Linux: CI_DRM_13394 -> Patchwork_120940v1
CI-20190529: 20190529
CI_DRM_13394: 4fab7ebb2e3675cb9fcd7a94a7b34caa0ea855cf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7392: 1e7c1d677d7ba57f342486bc522ed1bb6c19bf5e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120940v1: 4fab7ebb2e3675cb9fcd7a94a7b34caa0ea855cf @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
bae8f13b2a52 drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
b059bf3a085c drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/index.html
[-- Attachment #2: Type: text/html, Size: 12116 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 [Intel-gfx] [PATCH 0/2] Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout() Nathan Chancellor
` (2 preceding siblings ...)
2023-07-18 23:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-07-19 0:45 ` Patchwork
2023-07-27 16:08 ` [Intel-gfx] [PATCH 0/2] " Maira Canal
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-07-19 0:45 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 39097 bytes --]
== Series Details ==
Series: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
URL : https://patchwork.freedesktop.org/series/120940/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13394_full -> Patchwork_120940v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/index.html
Participating hosts (10 -> 9)
------------------------------
Missing (1): pig-kbl-iris
Known issues
------------
Here are the changes found in Patchwork_120940v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_barrier_race@remote-request@rcs0:
- shard-apl: NOTRUN -> [ABORT][1] ([i915#7461] / [i915#8211] / [i915#8234])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl1/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_create@create-ext-set-pat:
- shard-snb: NOTRUN -> [FAIL][2] ([i915#8621])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-snb1/igt@gem_create@create-ext-set-pat.html
* igt@gem_ctx_persistence@idempotent:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-snb5/igt@gem_ctx_persistence@idempotent.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [PASS][4] -> [TIMEOUT][5] ([i915#3063])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-apl3/igt@gem_eio@in-flight-contexts-1us.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl4/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-deadline:
- shard-rkl: [PASS][6] -> [FAIL][7] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-6/igt@gem_exec_fair@basic-deadline.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-rkl: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [PASS][9] -> [FAIL][10] ([i915#2842]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-7/igt@gem_exec_fair@basic-none@bcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-rkl: NOTRUN -> [SKIP][11] ([fdo#112283])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@gem_exec_params@secure-non-master.html
* igt@gem_exec_reloc@basic-gtt-read:
- shard-rkl: NOTRUN -> [SKIP][12] ([i915#3281]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@gem_exec_reloc@basic-gtt-read.html
* igt@gem_exec_reloc@basic-wc-gtt-active:
- shard-mtlp: NOTRUN -> [SKIP][13] ([i915#3281])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@gem_exec_reloc@basic-wc-gtt-active.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-mtlp: [PASS][14] -> [ABORT][15] ([i915#8131])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-1/igt@gem_exec_whisper@basic-contexts-forked-all.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@gem_lmem_swapping@basic:
- shard-rkl: NOTRUN -> [SKIP][16] ([i915#4613])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl1/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [PASS][18] -> [DMESG-WARN][19] ([i915#4936] / [i915#5493])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-10/igt@gem_lmem_swapping@smem-oom@lmem0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-2/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-mtlp: NOTRUN -> [SKIP][20] ([i915#4270])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-mtlp: NOTRUN -> [SKIP][21] ([i915#8428]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_set_tiling_vs_pwrite:
- shard-rkl: NOTRUN -> [SKIP][22] ([i915#3282]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@gem_set_tiling_vs_pwrite.html
* igt@gem_tiled_partial_pwrite_pread@writes:
- shard-mtlp: NOTRUN -> [SKIP][23] ([i915#4077])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@gem_tiled_partial_pwrite_pread@writes.html
* igt@gem_userptr_blits@coherency-sync:
- shard-rkl: NOTRUN -> [SKIP][24] ([fdo#110542])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@gem_userptr_blits@coherency-sync.html
* igt@i915_pm_rpm@cursor-dpms:
- shard-tglu: [PASS][25] -> [FAIL][26] ([i915#7940])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-tglu-3/igt@i915_pm_rpm@cursor-dpms.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-tglu-6/igt@i915_pm_rpm@cursor-dpms.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-mtlp: NOTRUN -> [SKIP][27] ([i915#1397])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-dg2: [PASS][28] -> [SKIP][29] ([i915#1397]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-5/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_selftest@live@requests:
- shard-mtlp: [PASS][30] -> [DMESG-FAIL][31] ([i915#8497])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-5/igt@i915_selftest@live@requests.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [PASS][32] -> [FAIL][33] ([fdo#103375])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-1/igt@i915_suspend@basic-s3-without-i915.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-4/igt@i915_suspend@basic-s3-without-i915.html
* igt@i915_suspend@fence-restore-untiled:
- shard-snb: NOTRUN -> [DMESG-WARN][34] ([i915#8841]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-snb1/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-mtlp: NOTRUN -> [SKIP][35] ([i915#5190])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_async_flips@crc@pipe-a-hdmi-a-2:
- shard-dg2: NOTRUN -> [FAIL][36] ([i915#8247]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-2/igt@kms_async_flips@crc@pipe-a-hdmi-a-2.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][37] ([i915#5286])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_big_fb@4-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-mtlp: [PASS][38] -> [FAIL][39] ([i915#3743])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-mtlp: [PASS][40] -> [FAIL][41] ([i915#5138])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-6/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-mtlp: NOTRUN -> [FAIL][42] ([i915#3743])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-mtlp: NOTRUN -> [SKIP][43] ([fdo#111615])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][44] ([fdo#110723]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_big_fb@yf-tiled-64bpp-rotate-90.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs:
- shard-rkl: NOTRUN -> [SKIP][45] ([i915#3734] / [i915#5354] / [i915#6095]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
- shard-mtlp: NOTRUN -> [SKIP][46] ([i915#6095]) +4 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-rkl: NOTRUN -> [SKIP][48] ([i915#5354]) +5 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271]) +274 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-snb6/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][50] ([i915#3886] / [i915#6095]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][51] ([i915#4087] / [i915#7213]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-5/igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3.html
* igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode:
- shard-rkl: NOTRUN -> [SKIP][52] ([i915#7828]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode.html
* igt@kms_chamelium_hpd@vga-hpd-without-ddc:
- shard-mtlp: NOTRUN -> [SKIP][53] ([i915#7828])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_chamelium_hpd@vga-hpd-without-ddc.html
* igt@kms_content_protection@atomic@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][54] ([i915#7173])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-11/igt@kms_content_protection@atomic@pipe-a-dp-4.html
* igt@kms_content_protection@srm:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#7118])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-1/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@cursor-rapid-movement-max-size:
- shard-rkl: NOTRUN -> [SKIP][56] ([i915#3555])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_cursor_crc@cursor-rapid-movement-max-size.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-mtlp: NOTRUN -> [SKIP][57] ([i915#3546])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-4/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
- shard-mtlp: NOTRUN -> [SKIP][58] ([fdo#111767] / [i915#3546])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][59] -> [FAIL][60] ([i915#2346])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_display_modes@extended-mode-basic:
- shard-mtlp: NOTRUN -> [SKIP][61] ([i915#8827])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_display_modes@extended-mode-basic.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc:
- shard-dg2: NOTRUN -> [SKIP][62] ([i915#3555])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-2/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][63] ([i915#3804])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-rkl: NOTRUN -> [SKIP][64] ([fdo#111825])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_flip@2x-dpms-vs-vblank-race.html
* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#3637]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][66] ([i915#2672])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-render:
- shard-rkl: NOTRUN -> [SKIP][67] ([fdo#111825] / [i915#1825]) +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt:
- shard-mtlp: NOTRUN -> [SKIP][68] ([i915#1825]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt:
- shard-rkl: NOTRUN -> [SKIP][69] ([i915#3023]) +5 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][70] ([i915#8708]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_hdr@static-toggle:
- shard-rkl: NOTRUN -> [SKIP][71] ([i915#3555] / [i915#8228])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_hdr@static-toggle.html
* igt@kms_hdr@static-toggle-dpms:
- shard-dg2: NOTRUN -> [SKIP][72] ([i915#3555] / [i915#8228])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-2/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c:
- shard-rkl: NOTRUN -> [SKIP][73] ([fdo#109289])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][74] ([i915#8292])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-4/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][75] ([i915#5176]) +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][76] ([i915#5176]) +3 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-5/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-3.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][77] ([i915#5176]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][78] ([i915#5235]) +19 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-10/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][79] ([i915#5235]) +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-rkl: NOTRUN -> [SKIP][80] ([fdo#111068] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr@primary_page_flip:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271]) +10 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl1/igt@kms_psr@primary_page_flip.html
* igt@kms_rotation_crc@bad-pixel-format:
- shard-mtlp: NOTRUN -> [SKIP][82] ([i915#4235]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@kms_rotation_crc@bad-pixel-format.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-270:
- shard-rkl: [PASS][83] -> [ABORT][84] ([i915#7461] / [i915#8178])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-7/igt@kms_rotation_crc@primary-y-tiled-reflect-x-270.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-2/igt@kms_rotation_crc@primary-y-tiled-reflect-x-270.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-dg2: [PASS][85] -> [FAIL][86] ([fdo#103375]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-5/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#533])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-check-output:
- shard-rkl: NOTRUN -> [SKIP][88] ([i915#2437])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_writeback@writeback-check-output.html
* igt@perf@stress-open-close@0-rcs0:
- shard-glk: [PASS][89] -> [ABORT][90] ([i915#5213] / [i915#7941])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-glk9/igt@perf@stress-open-close@0-rcs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-glk4/igt@perf@stress-open-close@0-rcs0.html
* igt@tools_test@sysfs_l3_parity:
- shard-rkl: NOTRUN -> [SKIP][91] ([fdo#109307])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@tools_test@sysfs_l3_parity.html
* igt@v3d/v3d_submit_cl@multisync-out-syncs:
- shard-mtlp: NOTRUN -> [SKIP][92] ([i915#2575])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@v3d/v3d_submit_cl@multisync-out-syncs.html
* igt@v3d/v3d_submit_csd@job-perfmon:
- shard-rkl: NOTRUN -> [SKIP][93] ([fdo#109315]) +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@v3d/v3d_submit_csd@job-perfmon.html
* igt@vc4/vc4_tiling@get-bad-flags:
- shard-rkl: NOTRUN -> [SKIP][94] ([i915#7711]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@vc4/vc4_tiling@get-bad-flags.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [FAIL][95] ([i915#7742]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-2/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][97] ([i915#5784]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg1-14/igt@gem_eio@reset-stress.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg1-19/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [FAIL][99] ([i915#2842]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_mmap_gtt@basic-small-copy-odd:
- shard-snb: [ABORT][101] -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-snb7/igt@gem_mmap_gtt@basic-small-copy-odd.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-snb2/igt@gem_mmap_gtt@basic-small-copy-odd.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [DMESG-WARN][103] ([i915#7061]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-3/igt@i915_module_load@reload-with-fault-injection.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-1/igt@i915_module_load@reload-with-fault-injection.html
- shard-mtlp: [ABORT][105] ([i915#8489] / [i915#8668]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-3/igt@i915_module_load@reload-with-fault-injection.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-2/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-mtlp: [FAIL][107] ([i915#8691]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-6/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-7/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][109] ([i915#1397]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-6/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- shard-tglu: [FAIL][111] ([i915#7940]) -> [PASS][112] +3 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-tglu-7/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-tglu-5/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-dg2: [SKIP][113] ([i915#1397]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-2/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-mtlp: [FAIL][115] ([i915#3743]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-mtlp: [FAIL][117] ([i915#2346]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-3/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-3/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [ABORT][119] ([i915#180]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-180:
- shard-rkl: [ABORT][121] ([i915#7461]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-7/igt@kms_rotation_crc@primary-y-tiled-reflect-x-180.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_rotation_crc@primary-y-tiled-reflect-x-180.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-dg2: [INCOMPLETE][123] ([i915#7892]) -> [INCOMPLETE][124] ([i915#1982] / [i915#7892])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-3/igt@gem_eio@kms.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-3/igt@gem_eio@kms.html
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- shard-tglu: [FAIL][125] ([i915#2681] / [i915#3591]) -> [WARN][126] ([i915#2681])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-tglu-4/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-tglu-10/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@kms_async_flips@crc@pipe-a-edp-1:
- shard-mtlp: [DMESG-FAIL][127] ([i915#1982] / [i915#8561]) -> [DMESG-FAIL][128] ([i915#8561])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-5/igt@kms_async_flips@crc@pipe-a-edp-1.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-4/igt@kms_async_flips@crc@pipe-a-edp-1.html
* igt@kms_content_protection@mei_interface:
- shard-dg2: [SKIP][129] ([i915#7118]) -> [SKIP][130] ([i915#7118] / [i915#7162])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-1/igt@kms_content_protection@mei_interface.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-12/igt@kms_content_protection@mei_interface.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-mtlp: [DMESG-FAIL][131] ([i915#2017] / [i915#5954]) -> [FAIL][132] ([i915#2346])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][133] ([fdo#110189] / [i915#3955]) -> [SKIP][134] ([i915#3955])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-2/igt@kms_fbcon_fbt@psr.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][135] ([i915#3955]) -> [SKIP][136] ([fdo#110189] / [i915#3955])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-rkl-4/igt@kms_fbcon_fbt@psr-suspend.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html
* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [CRASH][137] ([i915#7331]) -> [INCOMPLETE][138] ([i915#5493])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-dg2-12/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-dg2-2/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-mtlp: [TIMEOUT][139] ([i915#6950]) -> [ABORT][140] ([i915#8521])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13394/shard-mtlp-4/igt@sysfs_timeslice_duration@timeout@vecs0.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/shard-mtlp-8/igt@sysfs_timeslice_duration@timeout@vecs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6333]: https://gitlab.freedesktop.org/drm/intel/issues/6333
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6950]: https://gitlab.freedesktop.org/drm/intel/issues/6950
[i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213
[i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7892]: https://gitlab.freedesktop.org/drm/intel/issues/7892
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131
[i915#8178]: https://gitlab.freedesktop.org/drm/intel/issues/8178
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
[i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8521]: https://gitlab.freedesktop.org/drm/intel/issues/8521
[i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561
[i915#8621]: https://gitlab.freedesktop.org/drm/intel/issues/8621
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8827]: https://gitlab.freedesktop.org/drm/intel/issues/8827
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8889]: https://gitlab.freedesktop.org/drm/intel/issues/8889
Build changes
-------------
* Linux: CI_DRM_13394 -> Patchwork_120940v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13394: 4fab7ebb2e3675cb9fcd7a94a7b34caa0ea855cf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7392: 1e7c1d677d7ba57f342486bc522ed1bb6c19bf5e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120940v1: 4fab7ebb2e3675cb9fcd7a94a7b34caa0ea855cf @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120940v1/index.html
[-- Attachment #2: Type: text/html, Size: 44775 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH 0/2] Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
2023-07-18 21:44 [Intel-gfx] [PATCH 0/2] Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout() Nathan Chancellor
` (3 preceding siblings ...)
2023-07-19 0:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-07-27 16:08 ` Maira Canal
4 siblings, 0 replies; 11+ messages in thread
From: Maira Canal @ 2023-07-27 16:08 UTC (permalink / raw)
To: Nathan Chancellor, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, emma, mwen
Cc: trix, intel-gfx, llvm, ndesaulniers, patches, dri-devel,
justinstitt
On 7/18/23 18:44, Nathan Chancellor wrote:
> Hi all,
>
> A proposed update to clang's -Wconstant-logical-operand [1] to warn when
> the left hand side is a constant as well now triggers with the modulo
> expression in nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a
> multiple of HZ, such as CONFIG_HZ=300:
>
> drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> 189 | if (NSEC_PER_SEC % HZ &&
> | ~~~~~~~~~~~~~~~~~ ^
> drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: use '&' for a bitwise operation
> 189 | if (NSEC_PER_SEC % HZ &&
> | ^~
> | &
> drivers/gpu/drm/i915/gem/i915_gem_wait.c:189:24: note: remove constant to silence this warning
> 1 warning generated.
>
> In file included from drivers/gpu/drm/v3d/v3d_debugfs.c:12:
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
> 343 | if (NSEC_PER_SEC % HZ &&
> | ~~~~~~~~~~~~~~~~~ ^
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: use '&' for a bitwise operation
> 343 | if (NSEC_PER_SEC % HZ &&
> | ^~
> | &
> drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: remove constant to silence this warning
> 1 warning generated.
>
> These patches add an explicit comparison to zero to make the
> expression a boolean, which clears up the warning.
>
> The patches have no real dependency on each other but I felt like they
> made send together since it is the same code.
>
> If these could go into mainline sooner rather than later to avoid
> breaking builds that can hit this with CONFIG_WERROR, that would be
> nice, but I won't insist since I don't think our own CI has builds that
> has those conditions, but others might.
>
> ---
> Nathan Chancellor (2):
> drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
> drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()
Applied both patches to drm-misc/drm-misc-next!
Best Regards,
- Maíra
>
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +-
> drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> ---
> base-commit: fdf0eaf11452d72945af31804e2a1048ee1b574c
> change-id: 20230718-nsecs_to_jiffies_timeout-constant-logical-operand-4a944690f3e9
>
> Best regards,
^ permalink raw reply [flat|nested] 11+ messages in thread