From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
Subject: Re: forcewake v5
Date: Thu, 21 Apr 2011 07:39:27 +0100 [thread overview]
Message-ID: <1bdc18$ka879k@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1303343599-18509-1-git-send-email-ben@bwidawsk.net>
On Wed, 20 Apr 2011 16:53:14 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
>
> Once you're done laughing that I got up to v5 (I think I skipped a v3,
> and v1 was the IOCTls, so it's really more like a v3) for patches meant
> to simply allow register reads and wites...
>
> Back to struct_mutex since it turned out to be my mistake regarding the
> IIR problem. The only issue in the interrupt handler was rps, which has
> been moved to a workqueue.
>
> Struct_mutex must be held to forcewake, or relinquish forcwake.
Ok, I got to the end. I feel really squeamish that our register read/write
routines are getting seriously overcomplicated for interrupt work and
would like a cut down version for IRQ context.
But other than that and some silly code that needs to be improved in light
of your review, it's looking good.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-21 6:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 23:53 forcewake v5 Ben Widawsky
2011-04-20 23:53 ` [PATCH 1/5] drm/i915: proper use of forcewake Ben Widawsky
2011-04-25 18:22 ` Ben Widawsky
2011-04-20 23:53 ` [PATCH 2/5] drm/i915: reference counted forcewake Ben Widawsky
2011-04-25 18:23 ` Ben Widawsky
2011-04-20 23:53 ` [PATCH 3/5] drm/i915: forcewake struct mutex locking fixes Ben Widawsky
2011-04-21 6:18 ` Chris Wilson
2011-04-22 16:20 ` Ben Widawsky
2011-04-22 16:41 ` Ben Widawsky
2011-04-22 17:00 ` Chris Wilson
2011-04-25 18:24 ` Ben Widawsky
2011-04-20 23:53 ` [PATCH 4/5] drm/i915: move gen6 rps handling to workqueue Ben Widawsky
2011-04-21 6:34 ` Chris Wilson
2011-04-22 16:12 ` Ben Widawsky
2011-04-25 18:25 ` Ben Widawsky
2011-04-20 23:53 ` [PATCH 5/5] drm/i915: debugfs interface for forcewake reference count Ben Widawsky
2011-04-25 18:25 ` Ben Widawsky
2011-04-25 19:28 ` Chris Wilson
2011-04-25 21:46 ` Ben Widawsky
2011-04-26 7:57 ` Chris Wilson
2011-04-21 6:39 ` Chris Wilson [this message]
2011-04-25 18:21 ` forcewake v5 Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1bdc18$ka879k@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox