public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 5/6] drm/i915: Introduce i915_reg_types.h
Date: Fri, 16 Aug 2019 08:35:46 -0700	[thread overview]
Message-ID: <1bebe0ee-8aa8-c1db-2326-408fd094623e@intel.com> (raw)
In-Reply-To: <op.z6lztocexaggs7@mwajdecz-mobl1.ger.corp.intel.com>



On 8/16/19 2:40 AM, Michal Wajdeczko wrote:
> On Fri, 16 Aug 2019 03:23:42 +0200, Daniele Ceraolo Spurio 
> <daniele.ceraolospurio@intel.com> wrote:
> 
>> With the introduction of display uncore, we want to categorize registers
>> between display and non-display. To help us getting it right, it will
>> be useful to move the display registers to a new file that can be used
>> without including i915_reg.h. To allow that, move all the basic register
>> type definitions and helpers to i915_reg_types.h and include that
>> instead of i915_reg.h from header files in the driver. We'll then
>> be able to replace i915_reg.h with the new display-only header in
>> display files and make sure the registers are correctly
>> compartmentalized.
>>
> 
> maybe this split should another way:
> 
>      i915_reg.h = basic typedefs and macros
>      intel_reg.h = register definitions
> and
>      intel_display_reg.h = display related regs (your goal)
>      intel_guc_reg.h = GuC related regs (we already have that!)
> 
> then we follow the rule to use i915_ prefix for driver specific
> code and intel_ prefix for hardware originated definitions
> 

Around the code we're using the *_types.h format for the headers with 
the basic defs, so I'd prefer to stick with that. But I can go with 
intel_* prefix and rename i915_reg.h to intel_reg.h.

Daniele

> Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-08-16 15:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16  1:23 [PATCH 0/6] Some more display uncore prep work Daniele Ceraolo Spurio
2019-08-16  1:23 ` [PATCH 1/6] drm/i915: Move i915_power_well_id out of i915_reg.h Daniele Ceraolo Spurio
2019-08-16  4:52   ` Lucas De Marchi
2019-08-16 15:27     ` Daniele Ceraolo Spurio
2019-08-16 15:28       ` Daniele Ceraolo Spurio
2019-08-16  1:23 ` [PATCH 2/6] drm/i915: Move engine IDs " Daniele Ceraolo Spurio
2019-08-16  4:56   ` Lucas De Marchi
2019-08-16  1:23 ` [PATCH 3/6] drm/i915: Move gmbus definitions " Daniele Ceraolo Spurio
2019-08-16  5:03   ` Lucas De Marchi
2019-08-16  1:23 ` [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV Daniele Ceraolo Spurio
2019-08-16  5:09   ` Lucas De Marchi
2019-08-16 15:30     ` Daniele Ceraolo Spurio
2019-08-16  9:35   ` Jani Nikula
2019-08-16  9:40     ` Chris Wilson
2019-08-16 10:32       ` Jani Nikula
2019-08-16 15:33     ` Daniele Ceraolo Spurio
2019-08-16  1:23 ` [PATCH 5/6] drm/i915: Introduce i915_reg_types.h Daniele Ceraolo Spurio
2019-08-16  9:40   ` Michal Wajdeczko
2019-08-16 15:35     ` Daniele Ceraolo Spurio [this message]
2019-08-16  1:23 ` [PATCH 6/6] drm/i915: Wrappers for display register waits Daniele Ceraolo Spurio
2019-08-16  7:17   ` Chris Wilson
2019-08-16  1:46 ` ✗ Fi.CI.CHECKPATCH: warning for Some more display uncore prep work Patchwork
2019-08-16  2:19 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-16 17:30 ` ✓ Fi.CI.IGT: " Patchwork
2019-08-16 21:22 ` [PATCH 0/6] " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bebe0ee-8aa8-c1db-2326-408fd094623e@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox