Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 17/02/2022 17:04, Belgaumkar, Vinay wrote:
> 
> On 2/17/2022 1:41 AM, Tvrtko Ursulin wrote:
>>
>> On 16/02/2022 18:15, Vinay Belgaumkar wrote:
>>> SLPC unset param H2G only needs one parameter - the id of the
>>> param.
>>>
>>> Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency 
>>> limits")
>>
>> How serious is this? Does it need backporting? If so:
>>
>> Cc: <stable@vger.kernel.org> # v5.15+
>>
>> ?
> 
> This path (unset_param) is not being exercised currently, so not very 
> serious.

Got it, and looking at the code it seems to hold - no possible entry to 
the path at the moment.

Note for the future - this is useful stuff to put in commit messages, 
especially when Fixes: is present. ;)

Regards,

Tvrtko


> Thanks,
> 
> Vinay.
> 
>>
>> Regards,
>>
>> Tvrtko
>>
>>> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c 
>>> b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>>> index 13b27b8ff74e..ba21ace973da 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>>> @@ -110,7 +110,7 @@ static int guc_action_slpc_unset_param(struct 
>>> intel_guc *guc, u8 id)
>>>   {
>>>       u32 request[] = {
>>>           GUC_ACTION_HOST2GUC_PC_SLPC_REQUEST,
>>> -        SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 2),
>>> +        SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 1),
>>>           id,
>>>       };